The comment line "When building external modules ..." explains the same thing as "Include the module's Makefile ..." a few lines below. The comment "they may be used when building the .mod.c file" is no longer true; .mod.c file is compiled in scripts/Makefile.modfinal since commit 9b9a3f20cbe0 ("kbuild: split final module linking out into Makefile.modfinal"). I still keep the code in case $(obj) or $(src) is used in the external module Makefile.
Showing the changes to scripts (1 of 1 file). Show all
Unified · Split
| @@ -67,10 +67,9 @@ __modpost: · 66 unmodified lines | ||
| 67 | 67 | |
| 68 | 68 | else |
| 69 | 69 | |
| 70 | −# When building external modules load the Kbuild file to retrieve EXTRA_SYMBOLS info | |
| 71 | 70 | ifneq ($(KBUILD_EXTMOD),) |
| 72 | 71 | |
| 73 | −# set src + obj - they may be used when building the .mod.c file | |
| 72 | +# set src + obj - they may be used in the modules's Makefile | |
| 74 | 73 | obj := $(KBUILD_EXTMOD) |
| 75 | 74 | src := $(obj) |
| 76 | 75 | |