In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid intentionally writing across neighboring fields. Wrap the target region in struct_group(). This additionally fixes a theoretical misalignment of the copy (since the size of "buf" changes between 64-bit and 32-bit, but this is likely never built for 64-bit). FWIW, I think this code is totally broken on 64-bit (which appears to not be a "real" build configuration): it would either always fail (with an uninitialized data->buf_size) or would cause corruption in userspace due to the copy_to_user() in the call path against an uninitialized data->buf value: omap3isp_stat_request_statistics_time32(...) struct omap3isp_stat_data data64; ... omap3isp_stat_request_statistics(stat, &data64); int omap3isp_stat_request_statistics(struct ispstat *stat, struct omap3isp_stat_data *data) ... buf = isp_stat_buf_get(stat, data); static struct ispstat_buffer *isp_stat_buf_get(struct ispstat *stat, struct omap3isp_stat_data *data) ... if (buf->buf_size > data->buf_size) { ... return ERR_PTR(-EINVAL); } ... rval = copy_to_user(data->buf, buf->virt_addr, buf->buf_size); Regardless, additionally initialize data64 to be zero-filled to avoid undefined behavior.
Showing the changes to include/uapi (1 of 2 files). Show all
Unified · Split
| @@ -162,6 +162,7 @@ struct omap3isp_h3a_aewb_config { · 161 unmodified lines | |||
| 162 | * struct omap3isp_stat_data - Statistic data sent to or received from user | 162 | * struct omap3isp_stat_data - Statistic data sent to or received from user |
| 163 | * @ts: Timestamp of returned framestats. | 163 | * @ts: Timestamp of returned framestats. |
| 164 | * @buf: Pointer to pass to user. | 164 | * @buf: Pointer to pass to user. |
| 165 | * @buf_size: Size of buffer. | ||
| 165 | * @frame_number: Frame number of requested stats. | 166 | * @frame_number: Frame number of requested stats. |
| 166 | * @cur_frame: Current frame number being processed. | 167 | * @cur_frame: Current frame number being processed. |
| 167 | * @config_counter: Number of the configuration associated with the data. | 168 | * @config_counter: Number of the configuration associated with the data. |
| @@ -176,10 +177,12 @@ struct omap3isp_stat_data { · 8 unmodified lines | |||
| 176 | struct timeval ts; | 177 | struct timeval ts; |
| 177 | #endif | 178 | #endif |
| 178 | void __user *buf; | 179 | void __user *buf; |
| 179 | __u32 buf_size; | 180 | __struct_group(/* no tag */, frame, /* no attrs */, |
| 180 | __u16 frame_number; | 181 | __u32 buf_size; |
| 181 | __u16 cur_frame; | 182 | __u16 frame_number; |
| 182 | __u16 config_counter; | 183 | __u16 cur_frame; |
| 184 | __u16 config_counter; | ||
| 185 | ); | ||
| 183 | }; | 186 | }; |
| 184 | 187 | ||
| 185 | #ifdef __KERNEL__ | 188 | #ifdef __KERNEL__ |
| @@ -189,10 +192,12 @@ struct omap3isp_stat_data_time32 { · 3 unmodified lines | |||
| 189 | __s32 tv_usec; | 192 | __s32 tv_usec; |
| 190 | } ts; | 193 | } ts; |
| 191 | __u32 buf; | 194 | __u32 buf; |
| 192 | __u32 buf_size; | 195 | __struct_group(/* no tag */, frame, /* no attrs */, |
| 193 | __u16 frame_number; | 196 | __u32 buf_size; |
| 194 | __u16 cur_frame; | 197 | __u16 frame_number; |
| 195 | __u16 config_counter; | 198 | __u16 cur_frame; |
| 199 | __u16 config_counter; | ||
| 200 | ); | ||
| 196 | }; | 201 | }; |
| 197 | #endif | 202 | #endif |
| 198 | 203 | ||