Only check EC for MKBP events when the ACPI notify value indicates the notify is due to an MKBP host event. This reduces unnecessary queries to the EC. Notify value 0x80 is reserved for devices specific notifies. It is used by many devices to indicate various events. It's only used by cros_ec for MKBP events.
Unified · Split
| @@ -419,7 +419,7 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data) · 418 unmodified lines | |||
| 419 | return; | 419 | return; |
| 420 | } | 420 | } |
| 421 | 421 | ||
| 422 | if (ec_dev->mkbp_event_supported) | 422 | if (value == ACPI_NOTIFY_CROS_EC_MKBP && ec_dev->mkbp_event_supported) |
| 423 | do { | 423 | do { |
| 424 | ret = cros_ec_get_next_event(ec_dev, NULL, | 424 | ret = cros_ec_get_next_event(ec_dev, NULL, |
| 425 | &ec_has_more_events); | 425 | &ec_has_more_events); |
| @@ -41,6 +41,11 @@ · 40 unmodified lines | |||
| 41 | #define EC_MAX_REQUEST_OVERHEAD 1 | 41 | #define EC_MAX_REQUEST_OVERHEAD 1 |
| 42 | #define EC_MAX_RESPONSE_OVERHEAD 32 | 42 | #define EC_MAX_RESPONSE_OVERHEAD 32 |
| 43 | 43 | ||
| 44 | /* | ||
| 45 | * ACPI notify value for MKBP host event. | ||
| 46 | */ | ||
| 47 | #define ACPI_NOTIFY_CROS_EC_MKBP 0x80 | ||
| 48 | |||
| 44 | /* | 49 | /* |
| 45 | * EC panic is not covered by the standard (0-F) ACPI notify values. | 50 | * EC panic is not covered by the standard (0-F) ACPI notify values. |
| 46 | * Arbitrarily choosing B0 to notify ec panic, which is in the 84-BF | 51 | * Arbitrarily choosing B0 to notify ec panic, which is in the 84-BF |