History

drivers: Remove explicit invocations of mmiowb()

mmiowb() is now implied by spin_unlock() on architectures that require it, so there is no reason to call it from driver code. This patch was generated using coccinelle: @mmiowb@ @@ - mmiowb(); and invoked as: $ for d in drivers include/linux/qed sound; do \ spatch --include-headers --sp-file mmiowb.cocci --dir $d --in-place; done NOTE: mmiowb() has only ever guaranteed ordering in conjunction with spin_unlock(). However, pairing each mmiowb() removal in this patch with the corresponding call to spin_unlock() is not at all trivial, so there is a small chance that this change may regress any drivers incorrectly relying on mmiowb() to order MMIO writes between CPUs using lock-free synchronisation. If you've ended up bisecting to this commit, you can reintroduce the mmiowb() calls using wmb() instead, which should restore the old behaviour on all architectures other than some esoteric ia64 systems.

Will Deacon committed 7 years ago

Commit fb24ea51 parent 949b8c7123 files · +1 −508Browse files

Unified · Split

123 files
  1. drivers/crypto/cavium/nitrox/nitrox_reqmgr.c +0 −4
  2. drivers/dma/txx9dmac.c +0 −3
  3. drivers/firewire/ohci.c +0 −1
  4. drivers/gpu/drm/i915/intel_hdmi.c +0 −10
  5. drivers/ide/tx4939ide.c +0 −2
  6. drivers/infiniband/hw/hfi1/chip.c +0 −3
  7. drivers/infiniband/hw/hfi1/pio.c +0 −1
  8. drivers/infiniband/hw/hns/hns_roce_hw_v1.c +0 −2
  9. drivers/infiniband/hw/mlx4/qp.c +0 −6
  10. drivers/infiniband/hw/mlx5/qp.c +0 −1
  11. drivers/infiniband/hw/mthca/mthca_cmd.c +0 −6
  12. drivers/infiniband/hw/mthca/mthca_cq.c +0 −5
  13. drivers/infiniband/hw/mthca/mthca_qp.c +0 −17
  14. drivers/infiniband/hw/mthca/mthca_srq.c +0 −6
  15. drivers/infiniband/hw/qedr/verbs.c +0 −12
  16. drivers/infiniband/hw/qib/qib_iba6120.c +0 −4
  17. drivers/infiniband/hw/qib/qib_iba7220.c +0 −3
  18. drivers/infiniband/hw/qib/qib_iba7322.c +0 −3
  19. drivers/infiniband/hw/qib/qib_sd7220.c +0 −4
  20. drivers/media/pci/dt3155/dt3155.c +0 −8
  21. drivers/memstick/host/jmb38x_ms.c +0 −4
  22. drivers/misc/ioc4.c +0 −2
  23. drivers/misc/mei/hw-me.c +0 −3
  24. drivers/misc/tifm_7xx1.c +0 −1
  25. drivers/mmc/host/alcor.c +0 −1
  26. drivers/mmc/host/sdhci.c +0 −13
  27. drivers/mmc/host/tifm_sd.c +0 −3
  28. drivers/mmc/host/via-sdmmc.c +0 −10
  29. drivers/mtd/nand/raw/r852.c +0 −2
  30. drivers/mtd/nand/raw/txx9ndfmc.c +0 −1
  31. drivers/net/ethernet/aeroflex/greth.c +0 −1
  32. drivers/net/ethernet/alacritech/slicoss.c +0 −4
  33. drivers/net/ethernet/amazon/ena/ena_com.c +0 −1
  34. drivers/net/ethernet/atheros/atlx/atl1.c +0 −1
  35. drivers/net/ethernet/atheros/atlx/atl2.c +0 −1
  36. drivers/net/ethernet/broadcom/bnx2.c +0 −4
  37. drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c +0 −2
  38. drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h +0 −4
  39. drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +0 −1
  40. drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +0 −29
  41. drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c +0 −1
  42. drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +0 −2
  43. drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c +0 −4
  44. drivers/net/ethernet/broadcom/bnxt/bnxt.c +0 −3
  45. drivers/net/ethernet/broadcom/tg3.c +0 −6
  46. drivers/net/ethernet/cavium/liquidio/cn66xx_device.c +0 −10
  47. drivers/net/ethernet/cavium/liquidio/octeon_device.c +0 −1
  48. drivers/net/ethernet/cavium/liquidio/octeon_droq.c +0 −4
  49. drivers/net/ethernet/cavium/liquidio/request_manager.c +0 −1
  50. drivers/net/ethernet/intel/e1000/e1000_main.c +0 −5
  51. drivers/net/ethernet/intel/e1000e/netdev.c +0 −7
  52. drivers/net/ethernet/intel/fm10k/fm10k_iov.c +0 −2
  53. drivers/net/ethernet/intel/fm10k/fm10k_main.c +0 −5
  54. drivers/net/ethernet/intel/i40e/i40e_txrx.c +0 −5
  55. drivers/net/ethernet/intel/iavf/iavf_txrx.c +0 −5
  56. drivers/net/ethernet/intel/ice/ice_txrx.c +0 −5
  57. drivers/net/ethernet/intel/igb/igb_main.c +0 −5
  58. drivers/net/ethernet/intel/igbvf/netdev.c +0 −4
  59. drivers/net/ethernet/intel/igc/igc_main.c +0 −5
  60. drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +0 −5
  61. drivers/net/ethernet/marvell/sky2.c +0 −4
  62. drivers/net/ethernet/mellanox/mlx4/catas.c +0 −4
  63. drivers/net/ethernet/mellanox/mlx4/cmd.c +0 −13
  64. drivers/net/ethernet/mellanox/mlx5/core/cmd.c +0 −1
  65. drivers/net/ethernet/myricom/myri10ge/myri10ge.c +0 −2
  66. drivers/net/ethernet/neterion/s2io.c +0 −2
  67. drivers/net/ethernet/neterion/vxge/vxge-main.c +0 −5
  68. drivers/net/ethernet/neterion/vxge/vxge-traffic.c +0 −4
  69. drivers/net/ethernet/qlogic/qed/qed_int.c +0 −13
  70. drivers/net/ethernet/qlogic/qed/qed_spq.c +0 −3
  71. drivers/net/ethernet/qlogic/qede/qede_ethtool.c +0 −8
  72. drivers/net/ethernet/qlogic/qede/qede_fp.c +0 −8
  73. drivers/net/ethernet/qlogic/qla3xxx.c +0 −1
  74. drivers/net/ethernet/qlogic/qlge/qlge.h +0 −1
  75. drivers/net/ethernet/qlogic/qlge/qlge_main.c +0 −1
  76. drivers/net/ethernet/renesas/ravb_main.c +0 −9
  77. drivers/net/ethernet/renesas/ravb_ptp.c +0 −3
  78. drivers/net/ethernet/renesas/sh_eth.c +0 −1
  79. drivers/net/ethernet/sfc/falcon/io.h +0 −2
  80. drivers/net/ethernet/sfc/io.h +0 −2
  81. drivers/net/ethernet/silan/sc92031.c +0 −14
  82. drivers/net/ethernet/via/via-rhine.c +0 −3
  83. drivers/net/ethernet/wiznet/w5100.c +0 −6
  84. drivers/net/ethernet/wiznet/w5300.c +0 −15
  85. drivers/net/wireless/ath/ath5k/base.c +0 −4
  86. drivers/net/wireless/ath/ath5k/mac80211-ops.c +0 −2
  87. drivers/net/wireless/broadcom/b43/main.c +0 −7
  88. drivers/net/wireless/broadcom/b43/sysfs.c +0 −1
  89. drivers/net/wireless/broadcom/b43legacy/ilt.c +0 −2
  90. drivers/net/wireless/broadcom/b43legacy/main.c +0 −20
  91. drivers/net/wireless/broadcom/b43legacy/phy.c +0 −1
  92. drivers/net/wireless/broadcom/b43legacy/pio.h +0 −1
  93. drivers/net/wireless/broadcom/b43legacy/radio.c +0 −4
  94. drivers/net/wireless/broadcom/b43legacy/sysfs.c +0 −1
  95. drivers/net/wireless/intel/iwlegacy/common.h +0 −7
  96. drivers/net/wireless/intel/iwlwifi/pcie/trans.c +0 −1
  97. drivers/ntb/hw/idt/ntb_hw_idt.c +0 −7
  98. drivers/ntb/test/ntb_perf.c +0 −3
  99. drivers/scsi/bfa/bfa.h +1 −2
  100. drivers/scsi/bfa/bfa_hw_cb.c +0 −2
  101. drivers/scsi/bfa/bfa_hw_ct.c +0 −2
  102. drivers/scsi/bnx2fc/bnx2fc_hwi.c +0 −2
  103. drivers/scsi/bnx2i/bnx2i_hwi.c +0 −3
  104. drivers/scsi/megaraid/megaraid_sas_base.c +0 −1
  105. drivers/scsi/megaraid/megaraid_sas_fusion.c +0 −1
  106. drivers/scsi/mpt3sas/mpt3sas_base.c +0 −1
  107. drivers/scsi/qedf/qedf_io.c +0 −1
  108. drivers/scsi/qedi/qedi_fw.c +0 −1
  109. drivers/scsi/qla1280.c +0 −5
  110. drivers/ssb/pci.c +0 −1
  111. drivers/ssb/pcmcia.c +0 −4
  112. drivers/staging/comedi/drivers/mite.c +0 −3
  113. drivers/staging/comedi/drivers/ni_660x.c +0 −2
  114. drivers/staging/comedi/drivers/ni_mio_common.c +0 −1
  115. drivers/staging/comedi/drivers/ni_pcidio.c +0 −2
  116. drivers/staging/comedi/drivers/ni_tio.c +0 −1
  117. drivers/staging/comedi/drivers/s626.c +0 −2
  118. drivers/tty/serial/men_z135_uart.c +0 −1
  119. drivers/tty/serial/serial_txx9.c +0 −1
  120. drivers/usb/early/xhci-dbc.c +0 −4
  121. drivers/usb/host/xhci-dbgcap.c +0 −2
  122. include/linux/qed/qed_if.h +0 −2
  123. sound/soc/txx9/txx9aclc-ac97.c +0 −1
drivers/crypto/cavium/nitrox/nitrox_reqmgr.c+0−4
@@ -303,8 +303,6 @@ static void post_se_instr(struct nitrox_softreq *sr, · 302 unmodified lines
303303
304304 /* Ring doorbell with count 1 */
305305 writeq(1, cmdq->dbell_csr_addr);
306− /* orders the doorbell rings */
307− mmiowb();
308306
309307 cmdq->write_idx = incr_index(idx, 1, ndev->qlen);
310308
@@ -599,8 +597,6 @@ void pkt_slc_resp_tasklet(unsigned long data) · 288 unmodified lines
599597 * MSI-X interrupt generates if Completion count > Threshold
600598 */
601599 writeq(slc_cnts.value, cmdq->compl_cnt_csr_addr);
602− /* order the writes */
603− mmiowb();
604600
605601 if (atomic_read(&cmdq->backlog_count))
606602 schedule_work(&cmdq->backlog_qflush);
drivers/dma/txx9dmac.c+0−3
@@ -327,7 +327,6 @@ static void txx9dmac_reset_chan(struct txx9dmac_chan *dc) · 326 unmodified lines
327327 channel_writel(dc, SAIR, 0);
328328 channel_writel(dc, DAIR, 0);
329329 channel_writel(dc, CCR, 0);
330− mmiowb();
331330 }
332331
333332 /* Called with dc->lock held and bh disabled */
@@ -954,7 +953,6 @@ static void txx9dmac_chain_dynamic(struct txx9dmac_chan *dc, · 620 unmodified lines
954953 dma_sync_single_for_device(chan2parent(&dc->chan),
955954 prev->txd.phys, ddev->descsize,
956955 DMA_TO_DEVICE);
957− mmiowb();
958956 if (!(channel_readl(dc, CSR) & TXX9_DMA_CSR_CHNEN) &&
959957 channel_read_CHAR(dc) == prev->txd.phys)
960958 /* Restart chain DMA */
@@ -1080,7 +1078,6 @@ static void txx9dmac_free_chan_resources(struct dma_chan *chan) · 119 unmodified lines
10801078 static void txx9dmac_off(struct txx9dmac_dev *ddev)
10811079 {
10821080 dma_writel(ddev, MCR, 0);
1083− mmiowb();
10841081 }
10851082
10861083 static int __init txx9dmac_chan_probe(struct platform_device *pdev)
drivers/firewire/ohci.c+0−1
@@ -2939,7 +2939,6 @@ static void set_multichannel_mask(struct fw_ohci *ohci, u64 channels) · 2938 unmodified lines
29392939 reg_write(ohci, OHCI1394_IRMultiChanMaskLoClear, ~lo);
29402940 reg_write(ohci, OHCI1394_IRMultiChanMaskHiSet, hi);
29412941 reg_write(ohci, OHCI1394_IRMultiChanMaskLoSet, lo);
2942− mmiowb();
29432942 ohci->mc_channels = channels;
29442943 }
29452944
drivers/gpu/drm/i915/intel_hdmi.c+0−10
@@ -182,7 +182,6 @@ static void g4x_write_infoframe(struct intel_encoder *encoder, · 181 unmodified lines
182182
183183 I915_WRITE(VIDEO_DIP_CTL, val);
184184
185− mmiowb();
186185 for (i = 0; i < len; i += 4) {
187186 I915_WRITE(VIDEO_DIP_DATA, *data);
188187 data++;
@@ -190,7 +189,6 @@ static void g4x_write_infoframe(struct intel_encoder *encoder, · 1 unmodified line
190189 /* Write every possible data byte to force correct ECC calculation. */
191190 for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
192191 I915_WRITE(VIDEO_DIP_DATA, 0);
193− mmiowb();
194192
195193 val |= g4x_infoframe_enable(type);
196194 val &= ~VIDEO_DIP_FREQ_MASK;
@@ -237,7 +235,6 @@ static void ibx_write_infoframe(struct intel_encoder *encoder, · 40 unmodified lines
237235
238236 I915_WRITE(reg, val);
239237
240− mmiowb();
241238 for (i = 0; i < len; i += 4) {
242239 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
243240 data++;
@@ -245,7 +242,6 @@ static void ibx_write_infoframe(struct intel_encoder *encoder, · 1 unmodified line
245242 /* Write every possible data byte to force correct ECC calculation. */
246243 for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
247244 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
248− mmiowb();
249245
250246 val |= g4x_infoframe_enable(type);
251247 val &= ~VIDEO_DIP_FREQ_MASK;
@@ -298,7 +294,6 @@ static void cpt_write_infoframe(struct intel_encoder *encoder, · 46 unmodified lines
298294
299295 I915_WRITE(reg, val);
300296
301− mmiowb();
302297 for (i = 0; i < len; i += 4) {
303298 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
304299 data++;
@@ -306,7 +301,6 @@ static void cpt_write_infoframe(struct intel_encoder *encoder, · 1 unmodified line
306301 /* Write every possible data byte to force correct ECC calculation. */
307302 for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
308303 I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
309− mmiowb();
310304
311305 val |= g4x_infoframe_enable(type);
312306 val &= ~VIDEO_DIP_FREQ_MASK;
@@ -352,7 +346,6 @@ static void vlv_write_infoframe(struct intel_encoder *encoder, · 39 unmodified lines
352346
353347 I915_WRITE(reg, val);
354348
355− mmiowb();
356349 for (i = 0; i < len; i += 4) {
357350 I915_WRITE(VLV_TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
358351 data++;
@@ -360,7 +353,6 @@ static void vlv_write_infoframe(struct intel_encoder *encoder, · 1 unmodified line
360353 /* Write every possible data byte to force correct ECC calculation. */
361354 for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
362355 I915_WRITE(VLV_TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
363− mmiowb();
364356
365357 val |= g4x_infoframe_enable(type);
366358 val &= ~VIDEO_DIP_FREQ_MASK;
@@ -406,7 +398,6 @@ static void hsw_write_infoframe(struct intel_encoder *encoder, · 39 unmodified lines
406398 val &= ~hsw_infoframe_enable(type);
407399 I915_WRITE(ctl_reg, val);
408400
409− mmiowb();
410401 for (i = 0; i < len; i += 4) {
411402 I915_WRITE(hsw_dip_data_reg(dev_priv, cpu_transcoder,
412403 type, i >> 2), *data);
@@ -416,7 +407,6 @@ static void hsw_write_infoframe(struct intel_encoder *encoder, · 3 unmodified lines
416407 for (; i < data_size; i += 4)
417408 I915_WRITE(hsw_dip_data_reg(dev_priv, cpu_transcoder,
418409 type, i >> 2), 0);
419− mmiowb();
420410
421411 val |= hsw_infoframe_enable(type);
422412 I915_WRITE(ctl_reg, val);
drivers/ide/tx4939ide.c+0−2
@@ -156,7 +156,6 @@ static u16 tx4939ide_check_error_ints(ide_hwif_t *hwif) · 155 unmodified lines
156156 u16 sysctl = tx4939ide_readw(base, TX4939IDE_Sys_Ctl);
157157
158158 tx4939ide_writew(sysctl | 0x4000, base, TX4939IDE_Sys_Ctl);
159− mmiowb();
160159 /* wait 12GBUSCLK (typ. 60ns @ GBUS200MHz, max 270ns) */
161160 ndelay(270);
162161 tx4939ide_writew(sysctl, base, TX4939IDE_Sys_Ctl);
@@ -396,7 +395,6 @@ static void tx4939ide_init_hwif(ide_hwif_t *hwif) · 233 unmodified lines
396395
397396 /* Soft Reset */
398397 tx4939ide_writew(0x8000, base, TX4939IDE_Sys_Ctl);
399− mmiowb();
400398 /* at least 20 GBUSCLK (typ. 100ns @ GBUS200MHz, max 450ns) */
401399 ndelay(450);
402400 tx4939ide_writew(0x0000, base, TX4939IDE_Sys_Ctl);
drivers/infiniband/hw/hfi1/chip.c+0−3
@@ -8365,7 +8365,6 @@ static inline void clear_recv_intr(struct hfi1_ctxtdata *rcd) · 8364 unmodified lines
83658365 struct hfi1_devdata *dd = rcd->dd;
83668366 u32 addr = CCE_INT_CLEAR + (8 * rcd->ireg);
83678367
8368− mmiowb();
83698368 write_csr(dd, addr, rcd->imask);
83708369 /* force the above write on the chip and get a value back */
83718370 (void)read_csr(dd, addr);
@@ -11803,12 +11802,10 @@ void update_usrhead(struct hfi1_ctxtdata *rcd, u32 hd, u32 updegr, u32 egrhd, · 3431 unmodified lines
1180311802 << RCV_EGR_INDEX_HEAD_HEAD_SHIFT;
1180411803 write_uctxt_csr(dd, ctxt, RCV_EGR_INDEX_HEAD, reg);
1180511804 }
11806− mmiowb();
1180711805 reg = ((u64)rcv_intr_count << RCV_HDR_HEAD_COUNTER_SHIFT) |
1180811806 (((u64)hd & RCV_HDR_HEAD_HEAD_MASK)
1180911807 << RCV_HDR_HEAD_HEAD_SHIFT);
1181011808 write_uctxt_csr(dd, ctxt, RCV_HDR_HEAD, reg);
11811− mmiowb();
1181211809 }
1181311810
1181411811 u32 hdrqempty(struct hfi1_ctxtdata *rcd)
drivers/infiniband/hw/hfi1/pio.c+0−1
@@ -1578,7 +1578,6 @@ void hfi1_sc_wantpiobuf_intr(struct send_context *sc, u32 needint) · 1577 unmodified lines
15781578 sc_del_credit_return_intr(sc);
15791579 trace_hfi1_wantpiointr(sc, needint, sc->credit_ctrl);
15801580 if (needint) {
1581− mmiowb();
15821581 sc_return_credits(sc);
15831582 }
15841583 }
drivers/infiniband/hw/hns/hns_roce_hw_v1.c+0−2
@@ -1750,8 +1750,6 @@ static int hns_roce_v1_post_mbox(struct hns_roce_dev *hr_dev, u64 in_param, · 1749 unmodified lines
17501750
17511751 writel(val, hcr + 5);
17521752
1753− mmiowb();
1754−
17551753 return 0;
17561754 }
17571755
drivers/infiniband/hw/mlx4/qp.c+0−6
@@ -3744,12 +3744,6 @@ out: · 3743 unmodified lines
37443744 writel_relaxed(qp->doorbell_qpn,
37453745 to_mdev(ibqp->device)->uar_map + MLX4_SEND_DOORBELL);
37463746
3747− /*
3748− * Make sure doorbells don't leak out of SQ spinlock
3749− * and reach the HCA out of order.
3750− */
3751− mmiowb();
3752−
37533747 stamp_send_wqe(qp, ind + qp->sq_spare_wqes - 1);
37543748
37553749 qp->sq_next_wqe = ind;
drivers/infiniband/hw/mlx5/qp.c+0−1
@@ -5123,7 +5123,6 @@ out: · 5122 unmodified lines
51235123 /* Make sure doorbells don't leak out of SQ spinlock
51245124 * and reach the HCA out of order.
51255125 */
5126− mmiowb();
51275126 bf->offset ^= bf->buf_size;
51285127 }
51295128
drivers/infiniband/hw/mthca/mthca_cmd.c+0−6
@@ -292,12 +292,6 @@ static int mthca_cmd_post(struct mthca_dev *dev, · 291 unmodified lines
292292 err = mthca_cmd_post_hcr(dev, in_param, out_param, in_modifier,
293293 op_modifier, op, token, event);
294294
295− /*
296− * Make sure that our HCR writes don't get mixed in with
297− * writes from another CPU starting a FW command.
298− */
299− mmiowb();
300−
301295 mutex_unlock(&dev->cmd.hcr_mutex);
302296 return err;
303297 }
drivers/infiniband/hw/mthca/mthca_cq.c+0−5
@@ -211,11 +211,6 @@ static inline void update_cons_index(struct mthca_dev *dev, struct mthca_cq *cq, · 210 unmodified lines
211211 mthca_write64(MTHCA_TAVOR_CQ_DB_INC_CI | cq->cqn, incr - 1,
212212 dev->kar + MTHCA_CQ_DOORBELL,
213213 MTHCA_GET_DOORBELL_LOCK(&dev->doorbell_lock));
214− /*
215− * Make sure doorbells don't leak out of CQ spinlock
216− * and reach the HCA out of order:
217− */
218− mmiowb();
219214 }
220215 }
221216
drivers/infiniband/hw/mthca/mthca_qp.c+0−17
@@ -1809,11 +1809,6 @@ out: · 1808 unmodified lines
18091809 (qp->qpn << 8) | size0,
18101810 dev->kar + MTHCA_SEND_DOORBELL,
18111811 MTHCA_GET_DOORBELL_LOCK(&dev->doorbell_lock));
1812− /*
1813− * Make sure doorbells don't leak out of SQ spinlock
1814− * and reach the HCA out of order:
1815− */
1816− mmiowb();
18171812 }
18181813
18191814 qp->sq.next_ind = ind;
@@ -1924,12 +1919,6 @@ out: · 104 unmodified lines
19241919 qp->rq.next_ind = ind;
19251920 qp->rq.head += nreq;
19261921
1927− /*
1928− * Make sure doorbells don't leak out of RQ spinlock and reach
1929− * the HCA out of order:
1930− */
1931− mmiowb();
1932−
19331922 spin_unlock_irqrestore(&qp->rq.lock, flags);
19341923 return err;
19351924 }
@@ -2164,12 +2153,6 @@ out: · 228 unmodified lines
21642153 MTHCA_GET_DOORBELL_LOCK(&dev->doorbell_lock));
21652154 }
21662155
2167− /*
2168− * Make sure doorbells don't leak out of SQ spinlock and reach
2169− * the HCA out of order:
2170− */
2171− mmiowb();
2172−
21732156 spin_unlock_irqrestore(&qp->sq.lock, flags);
21742157 return err;
21752158 }
drivers/infiniband/hw/mthca/mthca_srq.c+0−6
@@ -570,12 +570,6 @@ int mthca_tavor_post_srq_recv(struct ib_srq *ibsrq, const struct ib_recv_wr *wr, · 569 unmodified lines
570570 MTHCA_GET_DOORBELL_LOCK(&dev->doorbell_lock));
571571 }
572572
573− /*
574− * Make sure doorbells don't leak out of SRQ spinlock and
575− * reach the HCA out of order:
576− */
577− mmiowb();
578−
579573 spin_unlock_irqrestore(&srq->lock, flags);
580574 return err;
581575 }
drivers/infiniband/hw/qedr/verbs.c+0−12
@@ -773,9 +773,6 @@ static void doorbell_cq(struct qedr_cq *cq, u32 cons, u8 flags) · 772 unmodified lines
773773 cq->db.data.agg_flags = flags;
774774 cq->db.data.value = cpu_to_le32(cons);
775775 writeq(cq->db.raw, cq->db_addr);
776−
777− /* Make sure write would stick */
778− mmiowb();
779776 }
780777
781778 int qedr_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags)
@@ -2084,8 +2081,6 @@ static int qedr_update_qp_state(struct qedr_dev *dev, · 1302 unmodified lines
20842081
20852082 if (rdma_protocol_roce(&dev->ibdev, 1)) {
20862083 writel(qp->rq.db_data.raw, qp->rq.db);
2087− /* Make sure write takes effect */
2088− mmiowb();
20892084 }
20902085 break;
20912086 case QED_ROCE_QP_STATE_ERR:
@@ -3502,9 +3497,6 @@ int qedr_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, · 1410 unmodified lines
35023497 smp_wmb();
35033498 writel(qp->sq.db_data.raw, qp->sq.db);
35043499
3505− /* Make sure write sticks */
3506− mmiowb();
3507−
35083500 spin_unlock_irqrestore(&qp->q_lock, flags);
35093501
35103502 return rc;
@@ -3695,12 +3687,8 @@ int qedr_post_recv(struct ib_qp *ibqp, const struct ib_recv_wr *wr, · 184 unmodified lines
36953687
36963688 writel(qp->rq.db_data.raw, qp->rq.db);
36973689
3698− /* Make sure write sticks */
3699− mmiowb();
3700−
37013690 if (rdma_protocol_iwarp(&dev->ibdev, 1)) {
37023691 writel(qp->rq.iwarp_db2_data.raw, qp->rq.iwarp_db2);
3703− mmiowb();
37043692 }
37053693
37063694 wr = wr->next;
drivers/infiniband/hw/qib/qib_iba6120.c+0−4
@@ -1884,7 +1884,6 @@ static void qib_6120_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, · 1883 unmodified lines
18841884 qib_write_kreg(dd, kr_scratch, 0xfeeddeaf);
18851885 writel(pa, tidp32);
18861886 qib_write_kreg(dd, kr_scratch, 0xdeadbeef);
1887− mmiowb();
18881887 spin_unlock_irqrestore(tidlockp, flags);
18891888 }
18901889
@@ -1928,7 +1927,6 @@ static void qib_6120_put_tid_2(struct qib_devdata *dd, u64 __iomem *tidptr, · 37 unmodified lines
19281927 pa |= 2 << 29;
19291928 }
19301929 writel(pa, tidp32);
1931− mmiowb();
19321930 }
19331931
19341932
@@ -2053,9 +2051,7 @@ static void qib_update_6120_usrhead(struct qib_ctxtdata *rcd, u64 hd, · 118 unmodified lines
20532051 {
20542052 if (updegr)
20552053 qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
2056− mmiowb();
20572054 qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
2058− mmiowb();
20592055 }
20602056
20612057 static u32 qib_6120_hdrqempty(struct qib_ctxtdata *rcd)
drivers/infiniband/hw/qib/qib_iba7220.c+0−3
@@ -2175,7 +2175,6 @@ static void qib_7220_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, · 2174 unmodified lines
21752175 pa = chippa;
21762176 }
21772177 writeq(pa, tidptr);
2178− mmiowb();
21792178 }
21802179
21812180 /**
@@ -2704,9 +2703,7 @@ static void qib_update_7220_usrhead(struct qib_ctxtdata *rcd, u64 hd, · 522 unmodified lines
27042703 {
27052704 if (updegr)
27062705 qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
2707− mmiowb();
27082706 qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
2709− mmiowb();
27102707 }
27112708
27122709 static u32 qib_7220_hdrqempty(struct qib_ctxtdata *rcd)
drivers/infiniband/hw/qib/qib_iba7322.c+0−3
@@ -3793,7 +3793,6 @@ static void qib_7322_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, · 3792 unmodified lines
37933793 pa = chippa;
37943794 }
37953795 writeq(pa, tidptr);
3796− mmiowb();
37973796 }
37983797
37993798 /**
@@ -4440,10 +4439,8 @@ static void qib_update_7322_usrhead(struct qib_ctxtdata *rcd, u64 hd, · 640 unmodified lines
44404439 adjust_rcv_timeout(rcd, npkts);
44414440 if (updegr)
44424441 qib_write_ureg(rcd->dd, ur_rcvegrindexhead, egrhd, rcd->ctxt);
4443− mmiowb();
44444442 qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
44454443 qib_write_ureg(rcd->dd, ur_rcvhdrhead, hd, rcd->ctxt);
4446− mmiowb();
44474444 }
44484445
44494446 static u32 qib_7322_hdrqempty(struct qib_ctxtdata *rcd)
drivers/infiniband/hw/qib/qib_sd7220.c+0−4
@@ -1068,7 +1068,6 @@ static int qib_sd_setvals(struct qib_devdata *dd) · 1067 unmodified lines
10681068 for (idx = 0; idx < NUM_DDS_REGS; ++idx) {
10691069 data = ((dds_reg_map & 0xF) << 4) | TX_FAST_ELT;
10701070 writeq(data, iaddr + idx);
1071− mmiowb();
10721071 qib_read_kreg32(dd, kr_scratch);
10731072 dds_reg_map >>= 4;
10741073 for (midx = 0; midx < DDS_ROWS; ++midx) {
@@ -1076,7 +1075,6 @@ static int qib_sd_setvals(struct qib_devdata *dd) · 1 unmodified line
10761075
10771076 data = dds_init_vals[midx].reg_vals[idx];
10781077 writeq(data, daddr);
1079− mmiowb();
10801078 qib_read_kreg32(dd, kr_scratch);
10811079 } /* End inner for (vals for this reg, each row) */
10821080 } /* end outer for (regs to be stored) */
@@ -1098,13 +1096,11 @@ static int qib_sd_setvals(struct qib_devdata *dd) · 15 unmodified lines
10981096 didx = idx + min_idx;
10991097 /* Store the next RXEQ register address */
11001098 writeq(rxeq_init_vals[idx].rdesc, iaddr + didx);
1101− mmiowb();
11021099 qib_read_kreg32(dd, kr_scratch);
11031100 /* Iterate through RXEQ values */
11041101 for (vidx = 0; vidx < 4; vidx++) {
11051102 data = rxeq_init_vals[idx].rdata[vidx];
11061103 writeq(data, taddr + (vidx << 6) + idx);
1107− mmiowb();
11081104 qib_read_kreg32(dd, kr_scratch);
11091105 }
11101106 } /* end outer for (Reg-writes for RXEQ) */
drivers/media/pci/dt3155/dt3155.c+0−8
@@ -46,7 +46,6 @@ static int read_i2c_reg(void __iomem *addr, u8 index, u8 *data) · 45 unmodified lines
4646 u32 tmp = index;
4747
4848 iowrite32((tmp << 17) | IIC_READ, addr + IIC_CSR2);
49− mmiowb();
5049 udelay(45); /* wait at least 43 usec for NEW_CYCLE to clear */
5150 if (ioread32(addr + IIC_CSR2) & NEW_CYCLE)
5251 return -EIO; /* error: NEW_CYCLE not cleared */
@@ -77,7 +76,6 @@ static int write_i2c_reg(void __iomem *addr, u8 index, u8 data) · 24 unmodified lines
7776 u32 tmp = index;
7877
7978 iowrite32((tmp << 17) | IIC_WRITE | data, addr + IIC_CSR2);
80− mmiowb();
8179 udelay(65); /* wait at least 63 usec for NEW_CYCLE to clear */
8280 if (ioread32(addr + IIC_CSR2) & NEW_CYCLE)
8381 return -EIO; /* error: NEW_CYCLE not cleared */
@@ -104,7 +102,6 @@ static void write_i2c_reg_nowait(void __iomem *addr, u8 index, u8 data) · 20 unmodified lines
104102 u32 tmp = index;
105103
106104 iowrite32((tmp << 17) | IIC_WRITE | data, addr + IIC_CSR2);
107− mmiowb();
108105 }
109106
110107 /**
@@ -264,7 +261,6 @@ static irqreturn_t dt3155_irq_handler_even(int irq, void *dev_id) · 153 unmodified lines
264261 FLD_DN_ODD | FLD_DN_EVEN |
265262 CAP_CONT_EVEN | CAP_CONT_ODD,
266263 ipd->regs + CSR1);
267− mmiowb();
268264 }
269265
270266 spin_lock(&ipd->lock);
@@ -282,7 +278,6 @@ static irqreturn_t dt3155_irq_handler_even(int irq, void *dev_id) · 11 unmodified lines
282278 iowrite32(dma_addr + ipd->width, ipd->regs + ODD_DMA_START);
283279 iowrite32(ipd->width, ipd->regs + EVEN_DMA_STRIDE);
284280 iowrite32(ipd->width, ipd->regs + ODD_DMA_STRIDE);
285− mmiowb();
286281 }
287282
288283 /* enable interrupts, clear all irq flags */
@@ -437,12 +432,10 @@ static int dt3155_init_board(struct dt3155_priv *pd) · 148 unmodified lines
437432 /* resetting the adapter */
438433 iowrite32(ADDR_ERR_ODD | ADDR_ERR_EVEN | FLD_CRPT_ODD | FLD_CRPT_EVEN |
439434 FLD_DN_ODD | FLD_DN_EVEN, pd->regs + CSR1);
440− mmiowb();
441435 msleep(20);
442436
443437 /* initializing adapter registers */
444438 iowrite32(FIFO_EN | SRST, pd->regs + CSR1);
445− mmiowb();
446439 iowrite32(0xEEEEEE01, pd->regs + EVEN_PIXEL_FMT);
447440 iowrite32(0xEEEEEE01, pd->regs + ODD_PIXEL_FMT);
448441 iowrite32(0x00000020, pd->regs + FIFO_TRIGER);
@@ -454,7 +447,6 @@ static int dt3155_init_board(struct dt3155_priv *pd) · 5 unmodified lines
454447 iowrite32(0, pd->regs + MASK_LENGTH);
455448 iowrite32(0x0005007C, pd->regs + FIFO_FLAG_CNT);
456449 iowrite32(0x01010101, pd->regs + IIC_CLK_DUR);
457− mmiowb();
458450
459451 /* verifying that we have a DT3155 board (not just a SAA7116 chip) */
460452 read_i2c_reg(pd->regs, DT_ID, &tmp);
drivers/memstick/host/jmb38x_ms.c+0−4
@@ -644,7 +644,6 @@ static int jmb38x_ms_reset(struct jmb38x_ms_host *host) · 643 unmodified lines
644644 writel(HOST_CONTROL_RESET_REQ | HOST_CONTROL_CLOCK_EN
645645 | readl(host->addr + HOST_CONTROL),
646646 host->addr + HOST_CONTROL);
647− mmiowb();
648647
649648 for (cnt = 0; cnt < 20; ++cnt) {
650649 if (!(HOST_CONTROL_RESET_REQ
@@ -659,7 +658,6 @@ reset_next: · 8 unmodified lines
659658 writel(HOST_CONTROL_RESET | HOST_CONTROL_CLOCK_EN
660659 | readl(host->addr + HOST_CONTROL),
661660 host->addr + HOST_CONTROL);
662− mmiowb();
663661
664662 for (cnt = 0; cnt < 20; ++cnt) {
665663 if (!(HOST_CONTROL_RESET
@@ -672,7 +670,6 @@ reset_next: · 6 unmodified lines
672670 return -EIO;
673671
674672 reset_ok:
675− mmiowb();
676673 writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
677674 writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
678675 return 0;
@@ -1009,7 +1006,6 @@ static void jmb38x_ms_remove(struct pci_dev *dev) · 330 unmodified lines
10091006 tasklet_kill(&host->notify);
10101007 writel(0, host->addr + INT_SIGNAL_ENABLE);
10111008 writel(0, host->addr + INT_STATUS_ENABLE);
1012− mmiowb();
10131009 dev_dbg(&jm->pdev->dev, "interrupts off\n");
10141010 spin_lock_irqsave(&host->lock, flags);
10151011 if (host->req) {
drivers/misc/ioc4.c+0−2
@@ -156,7 +156,6 @@ ioc4_clock_calibrate(struct ioc4_driver_data *idd) · 155 unmodified lines
156156
157157 /* Reset to power-on state */
158158 writel(0, &idd->idd_misc_regs->int_out.raw);
159− mmiowb();
160159
161160 /* Set up square wave */
162161 int_out.raw = 0;
@@ -164,7 +163,6 @@ ioc4_clock_calibrate(struct ioc4_driver_data *idd) · 1 unmodified line
164163 int_out.fields.mode = IOC4_INT_OUT_MODE_TOGGLE;
165164 int_out.fields.diag = 0;
166165 writel(int_out.raw, &idd->idd_misc_regs->int_out.raw);
167− mmiowb();
168166
169167 /* Check square wave period averaged over some number of cycles */
170168 start = ktime_get_ns();
drivers/misc/mei/hw-me.c+0−3
@@ -350,9 +350,6 @@ static void mei_me_hw_reset_release(struct mei_device *dev) · 349 unmodified lines
350350 hcsr |= H_IG;
351351 hcsr &= ~H_RST;
352352 mei_hcsr_set(dev, hcsr);
353−
354− /* complete this write before we set host ready on another CPU */
355− mmiowb();
356353 }
357354
358355 /**
drivers/misc/tifm_7xx1.c+0−1
@@ -403,7 +403,6 @@ static void tifm_7xx1_remove(struct pci_dev *dev) · 402 unmodified lines
403403 fm->eject = tifm_7xx1_dummy_eject;
404404 fm->has_ms_pif = tifm_7xx1_dummy_has_ms_pif;
405405 writel(TIFM_IRQ_SETALL, fm->addr + FM_CLEAR_INTERRUPT_ENABLE);
406− mmiowb();
407406 free_irq(dev->irq, fm);
408407
409408 tifm_remove_adapter(fm);
drivers/mmc/host/alcor.c+0−1
@@ -967,7 +967,6 @@ static void alcor_timeout_timer(struct work_struct *work) · 966 unmodified lines
967967 alcor_request_complete(host, 0);
968968 }
969969
970− mmiowb();
971970 mutex_unlock(&host->cmd_mutex);
972971 }
973972
drivers/mmc/host/sdhci.c+0−13
@@ -1807,7 +1807,6 @@ void sdhci_request(struct mmc_host *mmc, struct mmc_request *mrq) · 1806 unmodified lines
18071807 sdhci_send_command(host, mrq->cmd);
18081808 }
18091809
1810− mmiowb();
18111810 spin_unlock_irqrestore(&host->lock, flags);
18121811 }
18131812 EXPORT_SYMBOL_GPL(sdhci_request);
@@ -2010,8 +2009,6 @@ void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) · 196 unmodified lines
20102009 */
20112010 if (host->quirks & SDHCI_QUIRK_RESET_CMD_DATA_ON_IOS)
20122011 sdhci_do_reset(host, SDHCI_RESET_CMD | SDHCI_RESET_DATA);
2013−
2014− mmiowb();
20152012 }
20162013 EXPORT_SYMBOL_GPL(sdhci_set_ios);
20172014
@@ -2105,7 +2102,6 @@ static void sdhci_enable_sdio_irq_nolock(struct sdhci_host *host, int enable) · 87 unmodified lines
21052102
21062103 sdhci_writel(host, host->ier, SDHCI_INT_ENABLE);
21072104 sdhci_writel(host, host->ier, SDHCI_SIGNAL_ENABLE);
2108− mmiowb();
21092105 }
21102106 }
21112107
@@ -2353,7 +2349,6 @@ void sdhci_send_tuning(struct sdhci_host *host, u32 opcode) · 241 unmodified lines
23532349
23542350 host->tuning_done = 0;
23552351
2356− mmiowb();
23572352 spin_unlock_irqrestore(&host->lock, flags);
23582353
23592354 /* Wait for Buffer Read Ready interrupt */
@@ -2705,7 +2700,6 @@ static bool sdhci_request_done(struct sdhci_host *host) · 345 unmodified lines
27052700
27062701 host->mrqs_done[i] = NULL;
27072702
2708− mmiowb();
27092703 spin_unlock_irqrestore(&host->lock, flags);
27102704
27112705 mmc_request_done(host->mmc, mrq);
@@ -2739,7 +2733,6 @@ static void sdhci_timeout_timer(struct timer_list *t) · 27 unmodified lines
27392733 sdhci_finish_mrq(host, host->cmd->mrq);
27402734 }
27412735
2742− mmiowb();
27432736 spin_unlock_irqrestore(&host->lock, flags);
27442737 }
27452738
@@ -2770,7 +2763,6 @@ static void sdhci_timeout_data_timer(struct timer_list *t) · 24 unmodified lines
27702763 }
27712764 }
27722765
2773− mmiowb();
27742766 spin_unlock_irqrestore(&host->lock, flags);
27752767 }
27762768
@@ -3251,7 +3243,6 @@ int sdhci_resume_host(struct sdhci_host *host) · 474 unmodified lines
32513243 mmc->ops->set_ios(mmc, &mmc->ios);
32523244 } else {
32533245 sdhci_init(host, (host->mmc->pm_flags & MMC_PM_KEEP_POWER));
3254− mmiowb();
32553246 }
32563247
32573248 if (host->irq_wake_enabled) {
@@ -3391,7 +3382,6 @@ void sdhci_cqe_enable(struct mmc_host *mmc) · 133 unmodified lines
33913382 mmc_hostname(mmc), host->ier,
33923383 sdhci_readl(host, SDHCI_INT_STATUS));
33933384
3394− mmiowb();
33953385 spin_unlock_irqrestore(&host->lock, flags);
33963386 }
33973387 EXPORT_SYMBOL_GPL(sdhci_cqe_enable);
@@ -3416,7 +3406,6 @@ void sdhci_cqe_disable(struct mmc_host *mmc, bool recovery) · 18 unmodified lines
34163406 mmc_hostname(mmc), host->ier,
34173407 sdhci_readl(host, SDHCI_INT_STATUS));
34183408
3419− mmiowb();
34203409 spin_unlock_irqrestore(&host->lock, flags);
34213410 }
34223411 EXPORT_SYMBOL_GPL(sdhci_cqe_disable);
@@ -4255,8 +4244,6 @@ int __sdhci_add_host(struct sdhci_host *host) · 832 unmodified lines
42554244 goto unirq;
42564245 }
42574246
4258− mmiowb();
4259−
42604247 ret = mmc_add_host(mmc);
42614248 if (ret)
42624249 goto unled;
drivers/mmc/host/tifm_sd.c+0−3
@@ -889,7 +889,6 @@ static int tifm_sd_initialize_host(struct tifm_sd *host) · 888 unmodified lines
889889 struct tifm_dev *sock = host->dev;
890890
891891 writel(0, sock->addr + SOCK_MMCSD_INT_ENABLE);
892− mmiowb();
893892 host->clk_div = 61;
894893 host->clk_freq = 20000000;
895894 writel(TIFM_MMCSD_RESET, sock->addr + SOCK_MMCSD_SYSTEM_CONTROL);
@@ -940,7 +939,6 @@ static int tifm_sd_initialize_host(struct tifm_sd *host) · 44 unmodified lines
940939 writel(TIFM_MMCSD_CERR | TIFM_MMCSD_BRS | TIFM_MMCSD_EOC
941940 | TIFM_MMCSD_ERRMASK,
942941 sock->addr + SOCK_MMCSD_INT_ENABLE);
943− mmiowb();
944942
945943 return 0;
946944 }
@@ -1005,7 +1003,6 @@ static void tifm_sd_remove(struct tifm_dev *sock) · 58 unmodified lines
10051003 spin_lock_irqsave(&sock->lock, flags);
10061004 host->eject = 1;
10071005 writel(0, sock->addr + SOCK_MMCSD_INT_ENABLE);
1008− mmiowb();
10091006 spin_unlock_irqrestore(&sock->lock, flags);
10101007
10111008 tasklet_kill(&host->finish_tasklet);
drivers/mmc/host/via-sdmmc.c+0−10
@@ -686,7 +686,6 @@ static void via_sdc_request(struct mmc_host *mmc, struct mmc_request *mrq) · 685 unmodified lines
686686 via_sdc_send_command(host, mrq->cmd);
687687 }
688688
689− mmiowb();
690689 spin_unlock_irqrestore(&host->lock, flags);
691690 }
692691
@@ -711,7 +710,6 @@ static void via_sdc_set_power(struct via_crdr_mmc_host *host, · 18 unmodified lines
711710 gatt &= ~VIA_CRDR_PCICLKGATT_PAD_PWRON;
712711 writeb(gatt, host->pcictrl_mmiobase + VIA_CRDR_PCICLKGATT);
713712
714− mmiowb();
715713 spin_unlock_irqrestore(&host->lock, flags);
716714
717715 via_pwron_sleep(host);
@@ -770,7 +768,6 @@ static void via_sdc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) · 52 unmodified lines
770768 if (readb(addrbase + VIA_CRDR_PCISDCCLK) != clock)
771769 writeb(clock, addrbase + VIA_CRDR_PCISDCCLK);
772770
773− mmiowb();
774771 spin_unlock_irqrestore(&host->lock, flags);
775772
776773 if (ios->power_mode != MMC_POWER_OFF)
@@ -830,7 +827,6 @@ static void via_reset_pcictrl(struct via_crdr_mmc_host *host) · 53 unmodified lines
830827 via_restore_pcictrlreg(host);
831828 via_restore_sdcreg(host);
832829
833− mmiowb();
834830 spin_unlock_irqrestore(&host->lock, flags);
835831 }
836832
@@ -925,7 +921,6 @@ static irqreturn_t via_sdc_isr(int irq, void *dev_id) · 88 unmodified lines
925921
926922 result = IRQ_HANDLED;
927923
928− mmiowb();
929924 out:
930925 spin_unlock(&sdhost->lock);
931926
@@ -960,7 +955,6 @@ static void via_sdc_timeout(struct timer_list *t) · 28 unmodified lines
960955 }
961956 }
962957
963− mmiowb();
964958 spin_unlock_irqrestore(&sdhost->lock, flags);
965959 }
966960
@@ -1012,7 +1006,6 @@ static void via_sdc_card_detect(struct work_struct *work) · 45 unmodified lines
10121006 tasklet_schedule(&host->finish_tasklet);
10131007 }
10141008
1015− mmiowb();
10161009 spin_unlock_irqrestore(&host->lock, flags);
10171010
10181011 via_reset_pcictrl(host);
@@ -1020,7 +1013,6 @@ static void via_sdc_card_detect(struct work_struct *work) · 1 unmodified line
10201013 spin_lock_irqsave(&host->lock, flags);
10211014 }
10221015
1023− mmiowb();
10241016 spin_unlock_irqrestore(&host->lock, flags);
10251017
10261018 via_print_pcictrl(host);
@@ -1188,7 +1180,6 @@ static void via_sd_remove(struct pci_dev *pcidev) · 161 unmodified lines
11881180
11891181 /* Disable generating further interrupts */
11901182 writeb(0x0, sdhost->pcictrl_mmiobase + VIA_CRDR_PCIINTCTRL);
1191− mmiowb();
11921183
11931184 if (sdhost->mrq) {
11941185 pr_err("%s: Controller removed during "
@@ -1197,7 +1188,6 @@ static void via_sd_remove(struct pci_dev *pcidev) · 2 unmodified lines
11971188 /* make sure all DMA is stopped */
11981189 writel(VIA_CRDR_DMACTRL_SFTRST,
11991190 sdhost->ddma_mmiobase + VIA_CRDR_DMACTRL);
1200− mmiowb();
12011191 sdhost->mrq->cmd->error = -ENOMEDIUM;
12021192 if (sdhost->mrq->stop)
12031193 sdhost->mrq->stop->error = -ENOMEDIUM;
drivers/mtd/nand/raw/r852.c+0−2
@@ -45,7 +45,6 @@ static inline void r852_write_reg(struct r852_device *dev, · 44 unmodified lines
4545 int address, uint8_t value)
4646 {
4747 writeb(value, dev->mmio + address);
48− mmiowb();
4948 }
5049
5150
@@ -61,7 +60,6 @@ static inline void r852_write_reg_dword(struct r852_device *dev, · 9 unmodified lines
6160 int address, uint32_t value)
6261 {
6362 writel(cpu_to_le32(value), dev->mmio + address);
64− mmiowb();
6563 }
6664
6765 /* returns pointer to our private structure */
drivers/mtd/nand/raw/txx9ndfmc.c+0−1
@@ -159,7 +159,6 @@ static void txx9ndfmc_cmd_ctrl(struct nand_chip *chip, int cmd, · 158 unmodified lines
159159 if ((ctrl & NAND_CTRL_CHANGE) && cmd == NAND_CMD_NONE)
160160 txx9ndfmc_write(dev, 0, TXX9_NDFDTR);
161161 }
162− mmiowb();
163162 }
164163
165164 static int txx9ndfmc_dev_ready(struct nand_chip *chip)
drivers/net/ethernet/aeroflex/greth.c+0−1
@@ -613,7 +613,6 @@ static irqreturn_t greth_interrupt(int irq, void *dev_id) · 612 unmodified lines
613613 napi_schedule(&greth->napi);
614614 }
615615
616− mmiowb();
617616 spin_unlock(&greth->devlock);
618617
619618 return retval;
drivers/net/ethernet/alacritech/slicoss.c+0−4
@@ -345,8 +345,6 @@ static void slic_set_rx_mode(struct net_device *dev) · 344 unmodified lines
345345 if (sdev->promisc != set_promisc) {
346346 sdev->promisc = set_promisc;
347347 slic_configure_rcv(sdev);
348− /* make sure writes to receiver cant leak out of the lock */
349− mmiowb();
350348 }
351349 spin_unlock_bh(&sdev->link_lock);
352350 }
@@ -1461,8 +1459,6 @@ static netdev_tx_t slic_xmit(struct sk_buff *skb, struct net_device *dev) · 1108 unmodified lines
14611459
14621460 if (slic_get_free_tx_descs(txq) < SLIC_MAX_REQ_TX_DESCS)
14631461 netif_stop_queue(dev);
1464− /* make sure writes to io-memory cant leak out of tx queue lock */
1465− mmiowb();
14661462
14671463 return NETDEV_TX_OK;
14681464 drop_skb:
drivers/net/ethernet/amazon/ena/ena_com.c+0−1
@@ -2016,7 +2016,6 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *dev, void *data) · 2015 unmodified lines
20162016 mb();
20172017 writel_relaxed((u32)aenq->head,
20182018 dev->reg_bar + ENA_REGS_AENQ_HEAD_DB_OFF);
2019− mmiowb();
20202019 }
20212020
20222021 int ena_com_dev_reset(struct ena_com_dev *ena_dev,
drivers/net/ethernet/atheros/atlx/atl1.c+0−1
@@ -2439,7 +2439,6 @@ static netdev_tx_t atl1_xmit_frame(struct sk_buff *skb, · 2438 unmodified lines
24392439 atl1_tx_map(adapter, skb, ptpd);
24402440 atl1_tx_queue(adapter, count, ptpd);
24412441 atl1_update_mailbox(adapter);
2442− mmiowb();
24432442 return NETDEV_TX_OK;
24442443 }
24452444
drivers/net/ethernet/atheros/atlx/atl2.c+0−1
@@ -908,7 +908,6 @@ static netdev_tx_t atl2_xmit_frame(struct sk_buff *skb, · 907 unmodified lines
908908 ATL2_WRITE_REGW(&adapter->hw, REG_MB_TXD_WR_IDX,
909909 (adapter->txd_write_ptr >> 2));
910910
911− mmiowb();
912911 dev_consume_skb_any(skb);
913912 return NETDEV_TX_OK;
914913 }
drivers/net/ethernet/broadcom/bnx2.c+0−4
@@ -3305,8 +3305,6 @@ next_rx: · 3304 unmodified lines
33053305
33063306 BNX2_WR(bp, rxr->rx_bseq_addr, rxr->rx_prod_bseq);
33073307
3308− mmiowb();
3309−
33103308 return rx_pkt;
33113309
33123310 }
@@ -6723,8 +6721,6 @@ bnx2_start_xmit(struct sk_buff *skb, struct net_device *dev) · 3410 unmodified lines
67236721 BNX2_WR16(bp, txr->tx_bidx_addr, prod);
67246722 BNX2_WR(bp, txr->tx_bseq_addr, txr->tx_prod_bseq);
67256723
6726− mmiowb();
6727−
67286724 txr->tx_prod = prod;
67296725
67306726 if (unlikely(bnx2_tx_avail(bp, txr) <= MAX_SKB_FRAGS)) {
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+0−2
@@ -4166,8 +4166,6 @@ netdev_tx_t bnx2x_start_xmit(struct sk_buff *skb, struct net_device *dev) · 4165 unmodified lines
41664166
41674167 DOORBELL_RELAXED(bp, txdata->cid, txdata->tx_db.raw);
41684168
4169− mmiowb();
4170−
41714169 txdata->tx_bd_prod += nbd;
41724170
41734171 if (unlikely(bnx2x_tx_avail(bp, txdata) < MAX_DESC_PER_TX_PKT)) {
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h+0−4
@@ -527,8 +527,6 @@ static inline void bnx2x_update_rx_prod(struct bnx2x *bp, · 526 unmodified lines
527527 REG_WR_RELAXED(bp, fp->ustorm_rx_prods_offset + i * 4,
528528 ((u32 *)&rx_prods)[i]);
529529
530− mmiowb();
531−
532530 DP(NETIF_MSG_RX_STATUS,
533531 "queue[%d]: wrote bd_prod %u cqe_prod %u sge_prod %u\n",
534532 fp->index, bd_prod, rx_comp_prod, rx_sge_prod);
@@ -653,7 +651,6 @@ static inline void bnx2x_igu_ack_sb_gen(struct bnx2x *bp, u8 igu_sb_id, · 118 unmodified lines
653651 REG_WR(bp, igu_addr, cmd_data.sb_id_and_flags);
654652
655653 /* Make sure that ACK is written */
656− mmiowb();
657654 barrier();
658655 }
659656
@@ -674,7 +671,6 @@ static inline void bnx2x_hc_ack_sb(struct bnx2x *bp, u8 sb_id, · 14 unmodified lines
674671 REG_WR(bp, hc_addr, (*(u32 *)&igu_ack));
675672
676673 /* Make sure that ACK is written */
677− mmiowb();
678674 barrier();
679675 }
680676
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c+0−1
@@ -2623,7 +2623,6 @@ static int bnx2x_run_loopback(struct bnx2x *bp, int loopback_mode) · 2622 unmodified lines
26232623 wmb();
26242624 DOORBELL_RELAXED(bp, txdata->cid, txdata->tx_db.raw);
26252625
2626− mmiowb();
26272626 barrier();
26282627
26292628 num_pkts++;
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c+0−29
@@ -869,9 +869,6 @@ static void bnx2x_hc_int_disable(struct bnx2x *bp) · 868 unmodified lines
869869 "write %x to HC %d (addr 0x%x)\n",
870870 val, port, addr);
871871
872− /* flush all outstanding writes */
873− mmiowb();
874−
875872 REG_WR(bp, addr, val);
876873 if (REG_RD(bp, addr) != val)
877874 BNX2X_ERR("BUG! Proper val not read from IGU!\n");
@@ -887,9 +884,6 @@ static void bnx2x_igu_int_disable(struct bnx2x *bp) · 9 unmodified lines
887884
888885 DP(NETIF_MSG_IFDOWN, "write %x to IGU\n", val);
889886
890− /* flush all outstanding writes */
891− mmiowb();
892−
893887 REG_WR(bp, IGU_REG_PF_CONFIGURATION, val);
894888 if (REG_RD(bp, IGU_REG_PF_CONFIGURATION) != val)
895889 BNX2X_ERR("BUG! Proper val not read from IGU!\n");
@@ -1595,7 +1589,6 @@ static void bnx2x_hc_int_enable(struct bnx2x *bp) · 699 unmodified lines
15951589 /*
15961590 * Ensure that HC_CONFIG is written before leading/trailing edge config
15971591 */
1598− mmiowb();
15991592 barrier();
16001593
16011594 if (!CHIP_IS_E1(bp)) {
@@ -1611,9 +1604,6 @@ static void bnx2x_hc_int_enable(struct bnx2x *bp) · 9 unmodified lines
16111604 REG_WR(bp, HC_REG_TRAILING_EDGE_0 + port*8, val);
16121605 REG_WR(bp, HC_REG_LEADING_EDGE_0 + port*8, val);
16131606 }
1614−
1615− /* Make sure that interrupts are indeed enabled from here on */
1616− mmiowb();
16171607 }
16181608
16191609 static void bnx2x_igu_int_enable(struct bnx2x *bp)
@@ -1674,9 +1664,6 @@ static void bnx2x_igu_int_enable(struct bnx2x *bp) · 54 unmodified lines
16741664
16751665 REG_WR(bp, IGU_REG_TRAILING_EDGE_LATCH, val);
16761666 REG_WR(bp, IGU_REG_LEADING_EDGE_LATCH, val);
1677−
1678− /* Make sure that interrupts are indeed enabled from here on */
1679− mmiowb();
16801667 }
16811668
16821669 void bnx2x_int_enable(struct bnx2x *bp)
@@ -3833,7 +3820,6 @@ static void bnx2x_sp_prod_update(struct bnx2x *bp) · 2150 unmodified lines
38333820
38343821 REG_WR16_RELAXED(bp, BAR_XSTRORM_INTMEM + XSTORM_SPQ_PROD_OFFSET(func),
38353822 bp->spq_prod_idx);
3836− mmiowb();
38373823 }
38383824
38393825 /**
@@ -5244,7 +5230,6 @@ static void bnx2x_update_eq_prod(struct bnx2x *bp, u16 prod) · 1404 unmodified lines
52445230 {
52455231 /* No memory barriers */
52465232 storm_memset_eq_prod(bp, prod, BP_FUNC(bp));
5247− mmiowb();
52485233 }
52495234
52505235 static int bnx2x_cnic_handle_cfc_del(struct bnx2x *bp, u32 cid,
@@ -6513,7 +6498,6 @@ void bnx2x_nic_init_cnic(struct bnx2x *bp) · 1262 unmodified lines
65136498
65146499 /* flush all */
65156500 mb();
6516− mmiowb();
65176501 }
65186502
65196503 void bnx2x_pre_irq_nic_init(struct bnx2x *bp)
@@ -6553,7 +6537,6 @@ void bnx2x_post_irq_nic_init(struct bnx2x *bp, u32 load_code) · 33 unmodified lines
65536537
65546538 /* flush all before enabling interrupts */
65556539 mb();
6556− mmiowb();
65576540
65586541 bnx2x_int_enable(bp);
65596542
@@ -7775,12 +7758,10 @@ void bnx2x_igu_clear_sb_gen(struct bnx2x *bp, u8 func, u8 idu_sb_id, bool is_pf) · 1215 unmodified lines
77757758 DP(NETIF_MSG_HW, "write 0x%08x to IGU(via GRC) addr 0x%x\n",
77767759 data, igu_addr_data);
77777760 REG_WR(bp, igu_addr_data, data);
7778− mmiowb();
77797761 barrier();
77807762 DP(NETIF_MSG_HW, "write 0x%08x to IGU(via GRC) addr 0x%x\n",
77817763 ctl, igu_addr_ctl);
77827764 REG_WR(bp, igu_addr_ctl, ctl);
7783− mmiowb();
77847765 barrier();
77857766
77867767 /* wait for clean up to finish */
@@ -9550,7 +9531,6 @@ static void bnx2x_set_234_gates(struct bnx2x *bp, bool close) · 1763 unmodified lines
95509531
95519532 DP(NETIF_MSG_HW | NETIF_MSG_IFUP, "%s gates #2, #3 and #4\n",
95529533 close ? "closing" : "opening");
9553− mmiowb();
95549534 }
95559535
95569536 #define SHARED_MF_CLP_MAGIC 0x80000000 /* `magic' bit */
@@ -9674,7 +9654,6 @@ static void bnx2x_pxp_prep(struct bnx2x *bp) · 117 unmodified lines
96749654 if (!CHIP_IS_E1(bp)) {
96759655 REG_WR(bp, PXP2_REG_RD_START_INIT, 0);
96769656 REG_WR(bp, PXP2_REG_RQ_RBC_DONE, 0);
9677− mmiowb();
96789657 }
96799658 }
96809659
@@ -9774,16 +9753,13 @@ static void bnx2x_process_kill_chip_reset(struct bnx2x *bp, bool global) · 93 unmodified lines
97749753 reset_mask1 & (~not_reset_mask1));
97759754
97769755 barrier();
9777− mmiowb();
97789756
97799757 REG_WR(bp, GRCBASE_MISC + MISC_REGISTERS_RESET_REG_2_SET,
97809758 reset_mask2 & (~stay_reset2));
97819759
97829760 barrier();
9783− mmiowb();
97849761
97859762 REG_WR(bp, GRCBASE_MISC + MISC_REGISTERS_RESET_REG_1_SET, reset_mask1);
9786− mmiowb();
97879763 }
97889764
97899765 /**
@@ -9867,9 +9843,6 @@ static int bnx2x_process_kill(struct bnx2x *bp, bool global) · 77 unmodified lines
98679843 REG_WR(bp, MISC_REG_UNPREPARED, 0);
98689844 barrier();
98699845
9870− /* Make sure all is written to the chip before the reset */
9871− mmiowb();
9872−
98739846 /* Wait for 1ms to empty GLUE and PCI-E core queues,
98749847 * PSWHST, GRC and PSWRD Tetris buffer.
98759848 */
@@ -14828,7 +14801,6 @@ static int bnx2x_drv_ctl(struct net_device *dev, struct drv_ctl_info *ctl) · 4952 unmodified lines
1482814801 if (rc)
1482914802 break;
1483014803
14831− mmiowb();
1483214804 barrier();
1483314805
1483414806 /* Start accepting on iSCSI L2 ring */
@@ -14863,7 +14835,6 @@ static int bnx2x_drv_ctl(struct net_device *dev, struct drv_ctl_info *ctl) · 28 unmodified lines
1486314835 if (!bnx2x_wait_sp_comp(bp, sp_bits))
1486414836 BNX2X_ERR("rx_mode completion timed out!\n");
1486514837
14866− mmiowb();
1486714838 barrier();
1486814839
1486914840 /* Unset iSCSI L2 MAC */
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c+0−1
@@ -5039,7 +5039,6 @@ static inline int bnx2x_q_init(struct bnx2x *bp, · 5038 unmodified lines
50395039 /* As no ramrod is sent, complete the command immediately */
50405040 o->complete_cmd(bp, o, BNX2X_Q_CMD_INIT);
50415041
5042− mmiowb();
50435042 smp_mb();
50445043
50455044 return 0;
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c+0−2
@@ -100,13 +100,11 @@ static void bnx2x_vf_igu_ack_sb(struct bnx2x *bp, struct bnx2x_virtf *vf, · 99 unmodified lines
100100 DP(NETIF_MSG_HW, "write 0x%08x to IGU(via GRC) addr 0x%x\n",
101101 cmd_data.sb_id_and_flags, igu_addr_data);
102102 REG_WR(bp, igu_addr_data, cmd_data.sb_id_and_flags);
103− mmiowb();
104103 barrier();
105104
106105 DP(NETIF_MSG_HW, "write 0x%08x to IGU(via GRC) addr 0x%x\n",
107106 ctl, igu_addr_ctl);
108107 REG_WR(bp, igu_addr_ctl, ctl);
109− mmiowb();
110108 barrier();
111109 }
112110
drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c+0−4
@@ -172,8 +172,6 @@ static int bnx2x_send_msg2pf(struct bnx2x *bp, u8 *done, dma_addr_t msg_mapping) · 171 unmodified lines
172172 /* Trigger the PF FW */
173173 writeb_relaxed(1, &zone_data->trigger.vf_pf_channel.addr_valid);
174174
175− mmiowb();
176−
177175 /* Wait for PF to complete */
178176 while ((tout >= 0) && (!*done)) {
179177 msleep(interval);
@@ -1179,7 +1177,6 @@ static void bnx2x_vf_mbx_resp_send_msg(struct bnx2x *bp, · 999 unmodified lines
11791177
11801178 /* ack the FW */
11811179 storm_memset_vf_mbx_ack(bp, vf->abs_vfid);
1182− mmiowb();
11831180
11841181 /* copy the response header including status-done field,
11851182 * must be last dmae, must be after FW is acked
@@ -2174,7 +2171,6 @@ static void bnx2x_vf_mbx_request(struct bnx2x *bp, struct bnx2x_virtf *vf, · 988 unmodified lines
21742171 */
21752172 storm_memset_vf_mbx_ack(bp, vf->abs_vfid);
21762173 /* Firmware ack should be written before unlocking channel */
2177− mmiowb();
21782174 bnx2x_unlock_vf_pf_channel(bp, vf, mbx->first_tlv.tl.type);
21792175 }
21802176 }
drivers/net/ethernet/broadcom/bnxt/bnxt.c+0−3
@@ -556,8 +556,6 @@ normal_tx: · 555 unmodified lines
556556
557557 tx_done:
558558
559− mmiowb();
560−
561559 if (unlikely(bnxt_tx_avail(bp, txr) <= MAX_SKB_FRAGS + 1)) {
562560 if (skb->xmit_more && !tx_buf->is_push)
563561 bnxt_db_write(bp, &txr->tx_db, prod);
@@ -2123,7 +2121,6 @@ static int bnxt_poll(struct napi_struct *napi, int budget) · 1559 unmodified lines
21232121 &dim_sample);
21242122 net_dim(&cpr->dim, dim_sample);
21252123 }
2126− mmiowb();
21272124 return work_done;
21282125 }
21292126
drivers/net/ethernet/broadcom/tg3.c+0−6
@@ -1073,7 +1073,6 @@ static void tg3_int_reenable(struct tg3_napi *tnapi) · 1072 unmodified lines
10731073 struct tg3 *tp = tnapi->tp;
10741074
10751075 tw32_mailbox(tnapi->int_mbox, tnapi->last_tag << 24);
1076− mmiowb();
10771076
10781077 /* When doing tagged status, this work check is unnecessary.
10791078 * The last_tag we write above tells the chip which piece of
@@ -6999,7 +6998,6 @@ next_pkt_nopost: · 5919 unmodified lines
69996998 tw32_rx_mbox(TG3_RX_JMB_PROD_IDX_REG,
70006999 tpr->rx_jmb_prod_idx);
70017000 }
7002− mmiowb();
70037001 } else if (work_mask) {
70047002 /* rx_std_buffers[] and rx_jmb_buffers[] entries must be
70057003 * updated before the producer indices can be updated.
@@ -7210,8 +7208,6 @@ static int tg3_poll_work(struct tg3_napi *tnapi, int work_done, int budget) · 204 unmodified lines
72107208 tw32_rx_mbox(TG3_RX_JMB_PROD_IDX_REG,
72117209 dpr->rx_jmb_prod_idx);
72127210
7213− mmiowb();
7214−
72157211 if (err)
72167212 tw32_f(HOSTCC_MODE, tp->coal_now);
72177213 }
@@ -7278,7 +7274,6 @@ static int tg3_poll_msix(struct napi_struct *napi, int budget) · 60 unmodified lines
72787274 HOSTCC_MODE_ENABLE |
72797275 tnapi->coal_now);
72807276 }
7281− mmiowb();
72827277 break;
72837278 }
72847279 }
@@ -8159,7 +8154,6 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, struct net_device *dev) · 874 unmodified lines
81598154 if (!skb->xmit_more || netif_xmit_stopped(txq)) {
81608155 /* Packets are ready, update Tx producer idx on card. */
81618156 tw32_tx_mbox(tnapi->prodmbox, entry);
8162− mmiowb();
81638157 }
81648158
81658159 return NETDEV_TX_OK;
drivers/net/ethernet/cavium/liquidio/cn66xx_device.c+0−10
@@ -38,9 +38,6 @@ int lio_cn6xxx_soft_reset(struct octeon_device *oct) · 37 unmodified lines
3838 lio_pci_readq(oct, CN6XXX_CIU_SOFT_RST);
3939 lio_pci_writeq(oct, 1, CN6XXX_CIU_SOFT_RST);
4040
41− /* make sure that the reset is written before starting timer */
42− mmiowb();
43−
4441 /* Wait for 10ms as Octeon resets. */
4542 mdelay(100);
4643
@@ -487,9 +484,6 @@ void lio_cn6xxx_disable_interrupt(struct octeon_device *oct, · 440 unmodified lines
487484
488485 /* Disable Interrupts */
489486 writeq(0, cn6xxx->intr_enb_reg64);
490−
491− /* make sure interrupts are really disabled */
492− mmiowb();
493487 }
494488
495489 static void lio_cn6xxx_get_pcie_qlmport(struct octeon_device *oct)
@@ -555,10 +549,6 @@ static int lio_cn6xxx_process_droq_intr_regs(struct octeon_device *oct) · 59 unmodified lines
555549 value &= ~(1 << oq_no);
556550 octeon_write_csr(oct, reg, value);
557551
558− /* Ensure that the enable register is written.
559− */
560− mmiowb();
561−
562552 spin_unlock(&cn6xxx->lock_for_droq_int_enb_reg);
563553 }
564554 }
drivers/net/ethernet/cavium/liquidio/octeon_device.c+0−1
@@ -1449,7 +1449,6 @@ void lio_enable_irq(struct octeon_droq *droq, struct octeon_instr_queue *iq) · 1448 unmodified lines
14491449 iq->pkt_in_done -= iq->pkts_processed;
14501450 iq->pkts_processed = 0;
14511451 /* this write needs to be flushed before we release the lock */
1452− mmiowb();
14531452 spin_unlock_bh(&iq->lock);
14541453 oct = iq->oct_dev;
14551454 }
drivers/net/ethernet/cavium/liquidio/octeon_droq.c+0−4
@@ -513,8 +513,6 @@ int octeon_retry_droq_refill(struct octeon_droq *droq) · 512 unmodified lines
513513 */
514514 wmb();
515515 writel(desc_refilled, droq->pkts_credit_reg);
516− /* make sure mmio write completes */
517− mmiowb();
518516
519517 if (pkts_credit + desc_refilled >= CN23XX_SLI_DEF_BP)
520518 reschedule = 0;
@@ -712,8 +710,6 @@ octeon_droq_fast_process_packets(struct octeon_device *oct, · 191 unmodified lines
712710 */
713711 wmb();
714712 writel(desc_refilled, droq->pkts_credit_reg);
715− /* make sure mmio write completes */
716− mmiowb();
717713 }
718714 }
719715 } /* for (each packet)... */
drivers/net/ethernet/cavium/liquidio/request_manager.c+0−1
@@ -278,7 +278,6 @@ ring_doorbell(struct octeon_device *oct, struct octeon_instr_queue *iq) · 277 unmodified lines
278278 if (atomic_read(&oct->status) == OCT_DEV_RUNNING) {
279279 writel(iq->fill_cnt, iq->doorbell_reg);
280280 /* make sure doorbell write goes through */
281− mmiowb();
282281 iq->fill_cnt = 0;
283282 iq->last_db_time = jiffies;
284283 return;
drivers/net/ethernet/intel/e1000/e1000_main.c+0−5
@@ -3270,11 +3270,6 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb, · 3269 unmodified lines
32703270 if (!skb->xmit_more ||
32713271 netif_xmit_stopped(netdev_get_tx_queue(netdev, 0))) {
32723272 writel(tx_ring->next_to_use, hw->hw_addr + tx_ring->tdt);
3273− /* we need this if more than one processor can write to
3274− * our tail at a time, it synchronizes IO on IA64/Altix
3275− * systems
3276− */
3277− mmiowb();
32783273 }
32793274 } else {
32803275 dev_kfree_skb_any(skb);
drivers/net/ethernet/intel/e1000e/netdev.c+0−7
@@ -3816,7 +3816,6 @@ static void e1000_flush_tx_ring(struct e1000_adapter *adapter) · 3815 unmodified lines
38163816 if (tx_ring->next_to_use == tx_ring->count)
38173817 tx_ring->next_to_use = 0;
38183818 ew32(TDT(0), tx_ring->next_to_use);
3819− mmiowb();
38203819 usleep_range(200, 250);
38213820 }
38223821
@@ -5904,12 +5903,6 @@ static netdev_tx_t e1000_xmit_frame(struct sk_buff *skb, · 2081 unmodified lines
59045903 tx_ring->next_to_use);
59055904 else
59065905 writel(tx_ring->next_to_use, tx_ring->tail);
5907−
5908− /* we need this if more than one processor can write
5909− * to our tail at a time, it synchronizes IO on
5910− *IA64/Altix systems
5911− */
5912− mmiowb();
59135906 }
59145907 } else {
59155908 dev_kfree_skb_any(skb);
drivers/net/ethernet/intel/fm10k/fm10k_iov.c+0−2
@@ -321,8 +321,6 @@ static void fm10k_mask_aer_comp_abort(struct pci_dev *pdev) · 320 unmodified lines
321321 pci_read_config_dword(pdev, pos + PCI_ERR_UNCOR_MASK, &err_mask);
322322 err_mask |= PCI_ERR_UNC_COMP_ABORT;
323323 pci_write_config_dword(pdev, pos + PCI_ERR_UNCOR_MASK, err_mask);
324−
325− mmiowb();
326324 }
327325
328326 int fm10k_iov_resume(struct pci_dev *pdev)
drivers/net/ethernet/intel/fm10k/fm10k_main.c+0−5
@@ -1037,11 +1037,6 @@ static void fm10k_tx_map(struct fm10k_ring *tx_ring, · 1036 unmodified lines
10371037 /* notify HW of packet */
10381038 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
10391039 writel(i, tx_ring->tail);
1040−
1041− /* we need this if more than one processor can write to our tail
1042− * at a time, it synchronizes IO on IA64/Altix systems
1043− */
1044− mmiowb();
10451040 }
10461041
10471042 return;
drivers/net/ethernet/intel/i40e/i40e_txrx.c+0−5
@@ -3471,11 +3471,6 @@ static inline int i40e_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, · 3470 unmodified lines
34713471 /* notify HW of packet */
34723472 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
34733473 writel(i, tx_ring->tail);
3474−
3475− /* we need this if more than one processor can write to our tail
3476− * at a time, it synchronizes IO on IA64/Altix systems
3477− */
3478− mmiowb();
34793474 }
34803475
34813476 return 0;
drivers/net/ethernet/intel/iavf/iavf_txrx.c+0−5
@@ -2360,11 +2360,6 @@ static inline void iavf_tx_map(struct iavf_ring *tx_ring, struct sk_buff *skb, · 2359 unmodified lines
23602360 /* notify HW of packet */
23612361 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
23622362 writel(i, tx_ring->tail);
2363−
2364− /* we need this if more than one processor can write to our tail
2365− * at a time, it synchronizes IO on IA64/Altix systems
2366− */
2367− mmiowb();
23682363 }
23692364
23702365 return;
drivers/net/ethernet/intel/ice/ice_txrx.c+0−5
@@ -1356,11 +1356,6 @@ ice_tx_map(struct ice_ring *tx_ring, struct ice_tx_buf *first, · 1355 unmodified lines
13561356 /* notify HW of packet */
13571357 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
13581358 writel(i, tx_ring->tail);
1359−
1360− /* we need this if more than one processor can write to our tail
1361− * at a time, it synchronizes IO on IA64/Altix systems
1362− */
1363− mmiowb();
13641359 }
13651360
13661361 return;
drivers/net/ethernet/intel/igb/igb_main.c+0−5
@@ -6028,11 +6028,6 @@ static int igb_tx_map(struct igb_ring *tx_ring, · 6027 unmodified lines
60286028
60296029 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
60306030 writel(i, tx_ring->tail);
6031−
6032− /* we need this if more than one processor can write to our tail
6033− * at a time, it synchronizes IO on IA64/Altix systems
6034− */
6035− mmiowb();
60366031 }
60376032 return 0;
60386033
drivers/net/ethernet/intel/igbvf/netdev.c+0−4
@@ -2279,10 +2279,6 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter, · 2278 unmodified lines
22792279 tx_ring->buffer_info[first].next_to_watch = tx_desc;
22802280 tx_ring->next_to_use = i;
22812281 writel(i, adapter->hw.hw_addr + tx_ring->tail);
2282− /* we need this if more than one processor can write to our tail
2283− * at a time, it synchronizes IO on IA64/Altix systems
2284− */
2285− mmiowb();
22862282 }
22872283
22882284 static netdev_tx_t igbvf_xmit_frame_ring_adv(struct sk_buff *skb,
drivers/net/ethernet/intel/igc/igc_main.c+0−5
@@ -892,11 +892,6 @@ static int igc_tx_map(struct igc_ring *tx_ring, · 891 unmodified lines
892892
893893 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
894894 writel(i, tx_ring->tail);
895−
896− /* we need this if more than one processor can write to our tail
897− * at a time, it synchronizes IO on IA64/Altix systems
898− */
899− mmiowb();
900895 }
901896
902897 return 0;
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+0−5
@@ -8299,11 +8299,6 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring, · 8298 unmodified lines
82998299
83008300 if (netif_xmit_stopped(txring_txq(tx_ring)) || !skb->xmit_more) {
83018301 writel(i, tx_ring->tail);
8302−
8303− /* we need this if more than one processor can write to our tail
8304− * at a time, it synchronizes IO on IA64/Altix systems
8305− */
8306− mmiowb();
83078302 }
83088303
83098304 return 0;
drivers/net/ethernet/marvell/sky2.c+0−4
@@ -1139,9 +1139,6 @@ static inline void sky2_put_idx(struct sky2_hw *hw, unsigned q, u16 idx) · 1138 unmodified lines
11391139 /* Make sure write' to descriptors are complete before we tell hardware */
11401140 wmb();
11411141 sky2_write16(hw, Y2_QADDR(q, PREF_UNIT_PUT_IDX), idx);
1142−
1143− /* Synchronize I/O on since next processor may write to tail */
1144− mmiowb();
11451142 }
11461143
11471144
@@ -1354,7 +1351,6 @@ stopped: · 206 unmodified lines
13541351
13551352 /* reset the Rx prefetch unit */
13561353 sky2_write32(hw, Y2_QADDR(rxq, PREF_UNIT_CTRL), PREF_UNIT_RST_SET);
1357− mmiowb();
13581354 }
13591355
13601356 /* Clean out receive buffer area, assumes receiver hardware stopped */
drivers/net/ethernet/mellanox/mlx4/catas.c+0−4
@@ -129,10 +129,6 @@ static int mlx4_reset_slave(struct mlx4_dev *dev) · 128 unmodified lines
129129 comm_flags = rst_req << COM_CHAN_RST_REQ_OFFSET;
130130 __raw_writel((__force u32)cpu_to_be32(comm_flags),
131131 (__iomem char *)priv->mfunc.comm + MLX4_COMM_CHAN_FLAGS);
132− /* Make sure that our comm channel write doesn't
133− * get mixed in with writes from another CPU.
134− */
135− mmiowb();
136132
137133 end = msecs_to_jiffies(MLX4_COMM_TIME) + jiffies;
138134 while (time_before(jiffies, end)) {
drivers/net/ethernet/mellanox/mlx4/cmd.c+0−13
@@ -281,7 +281,6 @@ static int mlx4_comm_cmd_post(struct mlx4_dev *dev, u8 cmd, u16 param) · 280 unmodified lines
281281 val = param | (cmd << 16) | (priv->cmd.comm_toggle << 31);
282282 __raw_writel((__force u32) cpu_to_be32(val),
283283 &priv->mfunc.comm->slave_write);
284− mmiowb();
285284 mutex_unlock(&dev->persist->device_state_mutex);
286285 return 0;
287286 }
@@ -496,12 +495,6 @@ static int mlx4_cmd_post(struct mlx4_dev *dev, u64 in_param, u64 out_param, · 208 unmodified lines
496495 (op_modifier << HCR_OPMOD_SHIFT) |
497496 op), hcr + 6);
498497
499− /*
500− * Make sure that our HCR writes don't get mixed in with
501− * writes from another CPU starting a FW command.
502− */
503− mmiowb();
504−
505498 cmd->toggle = cmd->toggle ^ 1;
506499
507500 ret = 0;
@@ -2206,7 +2199,6 @@ static void mlx4_master_do_cmd(struct mlx4_dev *dev, int slave, u8 cmd, · 1698 unmodified lines
22062199 }
22072200 __raw_writel((__force u32) cpu_to_be32(reply),
22082201 &priv->mfunc.comm[slave].slave_read);
2209− mmiowb();
22102202
22112203 return;
22122204
@@ -2410,7 +2402,6 @@ int mlx4_multi_func_init(struct mlx4_dev *dev) · 197 unmodified lines
24102402 &priv->mfunc.comm[i].slave_write);
24112403 __raw_writel((__force u32) 0,
24122404 &priv->mfunc.comm[i].slave_read);
2413− mmiowb();
24142405 for (port = 1; port <= MLX4_MAX_PORTS; port++) {
24152406 struct mlx4_vport_state *admin_vport;
24162407 struct mlx4_vport_state *oper_vport;
@@ -2576,10 +2567,6 @@ void mlx4_report_internal_err_comm_event(struct mlx4_dev *dev) · 159 unmodified lines
25762567 slave_read |= (u32)COMM_CHAN_EVENT_INTERNAL_ERR;
25772568 __raw_writel((__force u32)cpu_to_be32(slave_read),
25782569 &priv->mfunc.comm[slave].slave_read);
2579− /* Make sure that our comm channel write doesn't
2580− * get mixed in with writes from another CPU.
2581− */
2582− mmiowb();
25832570 }
25842571 }
25852572
drivers/net/ethernet/mellanox/mlx5/core/cmd.c+0−1
@@ -917,7 +917,6 @@ static void cmd_work_handler(struct work_struct *work) · 916 unmodified lines
917917 mlx5_core_dbg(dev, "writing 0x%x to command doorbell\n", 1 << ent->idx);
918918 wmb();
919919 iowrite32be(1 << ent->idx, &dev->iseg->cmd_dbell);
920− mmiowb();
921920 /* if not in polling don't use ent after this point */
922921 if (cmd_mode == CMD_MODE_POLLING || poll_cmd) {
923922 poll_timeout(ent);
drivers/net/ethernet/myricom/myri10ge/myri10ge.c+0−2
@@ -1439,7 +1439,6 @@ myri10ge_tx_done(struct myri10ge_slice_state *ss, int mcp_index) · 1438 unmodified lines
14391439 tx->queue_active = 0;
14401440 put_be32(htonl(1), tx->send_stop);
14411441 mb();
1442− mmiowb();
14431442 }
14441443 __netif_tx_unlock(dev_queue);
14451444 }
@@ -2861,7 +2860,6 @@ again: · 1415 unmodified lines
28612860 tx->queue_active = 1;
28622861 put_be32(htonl(1), tx->send_go);
28632862 mb();
2864− mmiowb();
28652863 }
28662864 tx->pkt_start++;
28672865 if ((avail - count) < MXGEFW_MAX_SEND_DESC) {
drivers/net/ethernet/neterion/s2io.c+0−2
@@ -4153,8 +4153,6 @@ static netdev_tx_t s2io_xmit(struct sk_buff *skb, struct net_device *dev) · 4152 unmodified lines
41534153
41544154 writeq(val64, &tx_fifo->List_Control);
41554155
4156− mmiowb();
4157−
41584156 put_off++;
41594157 if (put_off == fifo->tx_curr_put_info.fifo_len + 1)
41604158 put_off = 0;
drivers/net/ethernet/neterion/vxge/vxge-main.c+0−5
@@ -1826,7 +1826,6 @@ static int vxge_poll_msix(struct napi_struct *napi, int budget) · 1825 unmodified lines
18261826 vxge_hw_channel_msix_unmask(
18271827 (struct __vxge_hw_channel *)ring->handle,
18281828 ring->rx_vector_no);
1829− mmiowb();
18301829 }
18311830
18321831 /* We are copying and returning the local variable, in case if after
@@ -2234,8 +2233,6 @@ static irqreturn_t vxge_tx_msix_handle(int irq, void *dev_id) · 401 unmodified lines
22342233 vxge_hw_channel_msix_unmask((struct __vxge_hw_channel *)fifo->handle,
22352234 fifo->tx_vector_no);
22362235
2237− mmiowb();
2238−
22392236 return IRQ_HANDLED;
22402237 }
22412238
@@ -2272,14 +2269,12 @@ vxge_alarm_msix_handle(int irq, void *dev_id) · 30 unmodified lines
22722269 */
22732270 vxge_hw_vpath_msix_mask(vdev->vpaths[i].handle, msix_id);
22742271 vxge_hw_vpath_msix_clear(vdev->vpaths[i].handle, msix_id);
2275− mmiowb();
22762272
22772273 status = vxge_hw_vpath_alarm_process(vdev->vpaths[i].handle,
22782274 vdev->exec_mode);
22792275 if (status == VXGE_HW_OK) {
22802276 vxge_hw_vpath_msix_unmask(vdev->vpaths[i].handle,
22812277 msix_id);
2282− mmiowb();
22832278 continue;
22842279 }
22852280 vxge_debug_intr(VXGE_ERR,
drivers/net/ethernet/neterion/vxge/vxge-traffic.c+0−4
@@ -1399,11 +1399,7 @@ static void __vxge_hw_non_offload_db_post(struct __vxge_hw_fifo *fifo, · 1398 unmodified lines
13991399 VXGE_HW_NODBW_GET_NO_SNOOP(no_snoop),
14001400 &fifo->nofl_db->control_0);
14011401
1402− mmiowb();
1403−
14041402 writeq(txdl_ptr, &fifo->nofl_db->txdl_ptr);
1405−
1406− mmiowb();
14071403 }
14081404
14091405 /**
drivers/net/ethernet/qlogic/qed/qed_int.c+0−13
@@ -774,18 +774,12 @@ static inline u16 qed_attn_update_idx(struct qed_hwfn *p_hwfn, · 773 unmodified lines
774774 {
775775 u16 rc = 0, index;
776776
777− /* Make certain HW write took affect */
778− mmiowb();
779−
780777 index = le16_to_cpu(p_sb_desc->sb_attn->sb_index);
781778 if (p_sb_desc->index != index) {
782779 p_sb_desc->index = index;
783780 rc = QED_SB_ATT_IDX;
784781 }
785782
786− /* Make certain we got a consistent view with HW */
787− mmiowb();
788−
789783 return rc;
790784 }
791785
@@ -1170,7 +1164,6 @@ static void qed_sb_ack_attn(struct qed_hwfn *p_hwfn, · 378 unmodified lines
11701164 /* Both segments (interrupts & acks) are written to same place address;
11711165 * Need to guarantee all commands will be received (in-order) by HW.
11721166 */
1173− mmiowb();
11741167 barrier();
11751168 }
11761169
@@ -1805,9 +1798,6 @@ static void qed_int_igu_enable_attn(struct qed_hwfn *p_hwfn, · 628 unmodified lines
18051798 qed_wr(p_hwfn, p_ptt, IGU_REG_TRAILING_EDGE_LATCH, 0xfff);
18061799 qed_wr(p_hwfn, p_ptt, IGU_REG_ATTENTION_ENABLE, 0xfff);
18071800
1808− /* Flush the writes to IGU */
1809− mmiowb();
1810−
18111801 /* Unmask AEU signals toward IGU */
18121802 qed_wr(p_hwfn, p_ptt, MISC_REG_AEU_MASK_ATTN_IGU, 0xff);
18131803 }
@@ -1871,9 +1861,6 @@ static void qed_int_igu_cleanup_sb(struct qed_hwfn *p_hwfn, · 57 unmodified lines
18711861
18721862 qed_wr(p_hwfn, p_ptt, IGU_REG_COMMAND_REG_CTRL, cmd_ctrl);
18731863
1874− /* Flush the write to IGU */
1875− mmiowb();
1876−
18771864 /* calculate where to read the status bit from */
18781865 sb_bit = 1 << (igu_sb_id % 32);
18791866 sb_bit_addr = igu_sb_id / 32 * sizeof(u32);
drivers/net/ethernet/qlogic/qed/qed_spq.c+0−3
@@ -341,9 +341,6 @@ void qed_eq_prod_update(struct qed_hwfn *p_hwfn, u16 prod) · 340 unmodified lines
341341 USTORM_EQE_CONS_OFFSET(p_hwfn->rel_pf_id);
342342
343343 REG_WR16(p_hwfn, addr, prod);
344−
345− /* keep prod updates ordered */
346− mmiowb();
347344 }
348345
349346 int qed_eq_completion(struct qed_hwfn *p_hwfn, void *cookie)
drivers/net/ethernet/qlogic/qede/qede_ethtool.c+0−8
@@ -1526,14 +1526,6 @@ static int qede_selftest_transmit_traffic(struct qede_dev *edev, · 1525 unmodified lines
15261526 barrier();
15271527 writel(txq->tx_db.raw, txq->doorbell_addr);
15281528
1529− /* mmiowb is needed to synchronize doorbell writes from more than one
1530− * processor. It guarantees that the write arrives to the device before
1531− * the queue lock is released and another start_xmit is called (possibly
1532− * on another CPU). Without this barrier, the next doorbell can bypass
1533− * this doorbell. This is applicable to IA64/Altix systems.
1534− */
1535− mmiowb();
1536−
15371529 for (i = 0; i < QEDE_SELFTEST_POLL_COUNT; i++) {
15381530 if (qede_txq_has_work(txq))
15391531 break;
drivers/net/ethernet/qlogic/qede/qede_fp.c+0−8
@@ -580,14 +580,6 @@ void qede_update_rx_prod(struct qede_dev *edev, struct qede_rx_queue *rxq) · 579 unmodified lines
580580
581581 internal_ram_wr(rxq->hw_rxq_prod_addr, sizeof(rx_prods),
582582 (u32 *)&rx_prods);
583−
584− /* mmiowb is needed to synchronize doorbell writes from more than one
585− * processor. It guarantees that the write arrives to the device before
586− * the napi lock is released and another qede_poll is called (possibly
587− * on another CPU). Without this barrier, the next doorbell can bypass
588− * this doorbell. This is applicable to IA64/Altix systems.
589− */
590− mmiowb();
591583 }
592584
593585 static void qede_get_rxhash(struct sk_buff *skb, u8 bitfields, __le32 rss_hash)
drivers/net/ethernet/qlogic/qla3xxx.c+0−1
@@ -1858,7 +1858,6 @@ static void ql_update_small_bufq_prod_index(struct ql3_adapter *qdev) · 1857 unmodified lines
18581858 wmb();
18591859 writel_relaxed(qdev->small_buf_q_producer_index,
18601860 &port_regs->CommonRegs.rxSmallQProducerIndex);
1861− mmiowb();
18621861 }
18631862 }
18641863
drivers/net/ethernet/qlogic/qlge/qlge.h+0−1
@@ -2181,7 +2181,6 @@ static inline void ql_write32(const struct ql_adapter *qdev, int reg, u32 val) · 2180 unmodified lines
21812181 static inline void ql_write_db_reg(u32 val, void __iomem *addr)
21822182 {
21832183 writel(val, addr);
2184− mmiowb();
21852184 }
21862185
21872186 /*
drivers/net/ethernet/qlogic/qlge/qlge_main.c+0−1
@@ -2695,7 +2695,6 @@ static netdev_tx_t qlge_send(struct sk_buff *skb, struct net_device *ndev) · 2694 unmodified lines
26952695 wmb();
26962696
26972697 ql_write_db_reg_relaxed(tx_ring->prod_idx, tx_ring->prod_idx_db_reg);
2698− mmiowb();
26992698 netif_printk(qdev, tx_queued, KERN_DEBUG, qdev->ndev,
27002699 "tx queued, slot %d, len %d\n",
27012700 tx_ring->prod_idx, skb->len);
drivers/net/ethernet/renesas/ravb_main.c+0−9
@@ -728,7 +728,6 @@ static irqreturn_t ravb_emac_interrupt(int irq, void *dev_id) · 727 unmodified lines
728728
729729 spin_lock(&priv->lock);
730730 ravb_emac_interrupt_unlocked(ndev);
731− mmiowb();
732731 spin_unlock(&priv->lock);
733732 return IRQ_HANDLED;
734733 }
@@ -848,7 +847,6 @@ static irqreturn_t ravb_interrupt(int irq, void *dev_id) · 113 unmodified lines
848847 result = IRQ_HANDLED;
849848 }
850849
851− mmiowb();
852850 spin_unlock(&priv->lock);
853851 return result;
854852 }
@@ -881,7 +879,6 @@ static irqreturn_t ravb_multi_interrupt(int irq, void *dev_id) · 26 unmodified lines
881879 result = IRQ_HANDLED;
882880 }
883881
884− mmiowb();
885882 spin_unlock(&priv->lock);
886883 return result;
887884 }
@@ -898,7 +895,6 @@ static irqreturn_t ravb_dma_interrupt(int irq, void *dev_id, int q) · 10 unmodified lines
898895 if (ravb_queue_interrupt(ndev, q))
899896 result = IRQ_HANDLED;
900897
901− mmiowb();
902898 spin_unlock(&priv->lock);
903899 return result;
904900 }
@@ -943,7 +939,6 @@ static int ravb_poll(struct napi_struct *napi, int budget) · 38 unmodified lines
943939 ravb_write(ndev, ~(mask | TIS_RESERVED), TIS);
944940 ravb_tx_free(ndev, q, true);
945941 netif_wake_subqueue(ndev, q);
946− mmiowb();
947942 spin_unlock_irqrestore(&priv->lock, flags);
948943 }
949944 }
@@ -959,7 +954,6 @@ static int ravb_poll(struct napi_struct *napi, int budget) · 9 unmodified lines
959954 ravb_write(ndev, mask, RIE0);
960955 ravb_write(ndev, mask, TIE);
961956 }
962− mmiowb();
963957 spin_unlock_irqrestore(&priv->lock, flags);
964958
965959 /* Receive error message handling */
@@ -1008,7 +1002,6 @@ static void ravb_adjust_link(struct net_device *ndev) · 42 unmodified lines
10081002 if (priv->no_avb_link && phydev->link)
10091003 ravb_rcv_snd_enable(ndev);
10101004
1011− mmiowb();
10121005 spin_unlock_irqrestore(&priv->lock, flags);
10131006
10141007 if (new_state && netif_msg_link(priv))
@@ -1601,7 +1594,6 @@ static netdev_tx_t ravb_start_xmit(struct sk_buff *skb, struct net_device *ndev) · 586 unmodified lines
16011594 netif_stop_subqueue(ndev, q);
16021595
16031596 exit:
1604− mmiowb();
16051597 spin_unlock_irqrestore(&priv->lock, flags);
16061598 return NETDEV_TX_OK;
16071599
@@ -1673,7 +1665,6 @@ static void ravb_set_rx_mode(struct net_device *ndev) · 65 unmodified lines
16731665 spin_lock_irqsave(&priv->lock, flags);
16741666 ravb_modify(ndev, ECMR, ECMR_PRM,
16751667 ndev->flags & IFF_PROMISC ? ECMR_PRM : 0);
1676− mmiowb();
16771668 spin_unlock_irqrestore(&priv->lock, flags);
16781669 }
16791670
drivers/net/ethernet/renesas/ravb_ptp.c+0−3
@@ -196,7 +196,6 @@ static int ravb_ptp_extts(struct ptp_clock_info *ptp, · 195 unmodified lines
196196 ravb_write(ndev, GIE_PTCS, GIE);
197197 else
198198 ravb_write(ndev, GID_PTCD, GID);
199− mmiowb();
200199 spin_unlock_irqrestore(&priv->lock, flags);
201200
202201 return 0;
@@ -259,7 +258,6 @@ static int ravb_ptp_perout(struct ptp_clock_info *ptp, · 56 unmodified lines
259258 else
260259 ravb_write(ndev, GID_PTMD0, GID);
261260 }
262− mmiowb();
263261 spin_unlock_irqrestore(&priv->lock, flags);
264262
265263 return error;
@@ -331,7 +329,6 @@ void ravb_ptp_init(struct net_device *ndev, struct platform_device *pdev) · 65 unmodified lines
331329 spin_lock_irqsave(&priv->lock, flags);
332330 ravb_wait(ndev, GCCR, GCCR_TCR, GCCR_TCR_NOREQ);
333331 ravb_modify(ndev, GCCR, GCCR_TCSS, GCCR_TCSS_ADJGPTP);
334− mmiowb();
335332 spin_unlock_irqrestore(&priv->lock, flags);
336333
337334 priv->ptp.clock = ptp_clock_register(&priv->ptp.info, &pdev->dev);
drivers/net/ethernet/renesas/sh_eth.c+0−1
@@ -2010,7 +2010,6 @@ static void sh_eth_adjust_link(struct net_device *ndev) · 2009 unmodified lines
20102010 if ((mdp->cd->no_psr || mdp->no_ether_link) && phydev->link)
20112011 sh_eth_rcv_snd_enable(ndev);
20122012
2013− mmiowb();
20142013 spin_unlock_irqrestore(&mdp->lock, flags);
20152014
20162015 if (new_state && netif_msg_link(mdp))
drivers/net/ethernet/sfc/falcon/io.h+0−2
@@ -108,7 +108,6 @@ static inline void ef4_writeo(struct ef4_nic *efx, const ef4_oword_t *value, · 107 unmodified lines
108108 _ef4_writed(efx, value->u32[2], reg + 8);
109109 _ef4_writed(efx, value->u32[3], reg + 12);
110110 #endif
111− mmiowb();
112111 spin_unlock_irqrestore(&efx->biu_lock, flags);
113112 }
114113
@@ -130,7 +129,6 @@ static inline void ef4_sram_writeq(struct ef4_nic *efx, void __iomem *membase, · 15 unmodified lines
130129 __raw_writel((__force u32)value->u32[0], membase + addr);
131130 __raw_writel((__force u32)value->u32[1], membase + addr + 4);
132131 #endif
133− mmiowb();
134132 spin_unlock_irqrestore(&efx->biu_lock, flags);
135133 }
136134
drivers/net/ethernet/sfc/io.h+0−2
@@ -120,7 +120,6 @@ static inline void efx_writeo(struct efx_nic *efx, const efx_oword_t *value, · 119 unmodified lines
120120 _efx_writed(efx, value->u32[2], reg + 8);
121121 _efx_writed(efx, value->u32[3], reg + 12);
122122 #endif
123− mmiowb();
124123 spin_unlock_irqrestore(&efx->biu_lock, flags);
125124 }
126125
@@ -142,7 +141,6 @@ static inline void efx_sram_writeq(struct efx_nic *efx, void __iomem *membase, · 15 unmodified lines
142141 __raw_writel((__force u32)value->u32[0], membase + addr);
143142 __raw_writel((__force u32)value->u32[1], membase + addr + 4);
144143 #endif
145− mmiowb();
146144 spin_unlock_irqrestore(&efx->biu_lock, flags);
147145 }
148146
drivers/net/ethernet/silan/sc92031.c+0−14
@@ -361,7 +361,6 @@ static void sc92031_disable_interrupts(struct net_device *dev) · 360 unmodified lines
361361 /* stop interrupts */
362362 iowrite32(0, port_base + IntrMask);
363363 _sc92031_dummy_read(port_base);
364− mmiowb();
365364
366365 /* wait for any concurrent interrupt/tasklet to finish */
367366 synchronize_irq(priv->pdev->irq);
@@ -379,7 +378,6 @@ static void sc92031_enable_interrupts(struct net_device *dev) · 11 unmodified lines
379378 wmb();
380379
381380 iowrite32(IntrBits, port_base + IntrMask);
382− mmiowb();
383381 }
384382
385383 static void _sc92031_disable_tx_rx(struct net_device *dev)
@@ -867,7 +865,6 @@ out: · 481 unmodified lines
867865 rmb();
868866
869867 iowrite32(intr_mask, port_base + IntrMask);
870− mmiowb();
871868
872869 spin_unlock(&priv->lock);
873870 }
@@ -901,7 +898,6 @@ out_none: · 27 unmodified lines
901898 rmb();
902899
903900 iowrite32(intr_mask, port_base + IntrMask);
904− mmiowb();
905901
906902 return IRQ_NONE;
907903 }
@@ -978,7 +974,6 @@ static netdev_tx_t sc92031_start_xmit(struct sk_buff *skb, · 70 unmodified lines
978974 iowrite32(priv->tx_bufs_dma_addr + entry * TX_BUF_SIZE,
979975 port_base + TxAddr0 + entry * 4);
980976 iowrite32(tx_status, port_base + TxStatus0 + entry * 4);
981− mmiowb();
982977
983978 if (priv->tx_head - priv->tx_tail >= NUM_TX_DESC)
984979 netif_stop_queue(dev);
@@ -1024,7 +1019,6 @@ static int sc92031_open(struct net_device *dev) · 39 unmodified lines
10241019 spin_lock_bh(&priv->lock);
10251020
10261021 _sc92031_reset(dev);
1027− mmiowb();
10281022
10291023 spin_unlock_bh(&priv->lock);
10301024 sc92031_enable_interrupts(dev);
@@ -1060,7 +1054,6 @@ static int sc92031_stop(struct net_device *dev) · 29 unmodified lines
10601054
10611055 _sc92031_disable_tx_rx(dev);
10621056 _sc92031_tx_clear(dev);
1063− mmiowb();
10641057
10651058 spin_unlock_bh(&priv->lock);
10661059
@@ -1081,7 +1074,6 @@ static void sc92031_set_multicast_list(struct net_device *dev) · 14 unmodified lines
10811074
10821075 _sc92031_set_mar(dev);
10831076 _sc92031_set_rx_config(dev);
1084− mmiowb();
10851077
10861078 spin_unlock_bh(&priv->lock);
10871079 }
@@ -1098,7 +1090,6 @@ static void sc92031_tx_timeout(struct net_device *dev) · 10 unmodified lines
10981090 priv->tx_timeouts++;
10991091
11001092 _sc92031_reset(dev);
1101− mmiowb();
11021093
11031094 spin_unlock(&priv->lock);
11041095
@@ -1140,7 +1131,6 @@ sc92031_ethtool_get_link_ksettings(struct net_device *dev, · 35 unmodified lines
11401131
11411132 output_status = _sc92031_mii_read(port_base, MII_OutputStatus);
11421133 _sc92031_mii_scan(port_base);
1143− mmiowb();
11441134
11451135 spin_unlock_bh(&priv->lock);
11461136
@@ -1311,7 +1301,6 @@ static int sc92031_ethtool_set_wol(struct net_device *dev, · 164 unmodified lines
13111301
13121302 priv->pm_config = pm_config;
13131303 iowrite32(pm_config, port_base + PMConfig);
1314− mmiowb();
13151304
13161305 spin_unlock_bh(&priv->lock);
13171306
@@ -1337,7 +1326,6 @@ static int sc92031_ethtool_nway_reset(struct net_device *dev) · 19 unmodified lines
13371326
13381327 out:
13391328 _sc92031_mii_scan(port_base);
1340− mmiowb();
13411329
13421330 spin_unlock_bh(&priv->lock);
13431331
@@ -1530,7 +1518,6 @@ static int sc92031_suspend(struct pci_dev *pdev, pm_message_t state) · 186 unmodified lines
15301518
15311519 _sc92031_disable_tx_rx(dev);
15321520 _sc92031_tx_clear(dev);
1533− mmiowb();
15341521
15351522 spin_unlock_bh(&priv->lock);
15361523
@@ -1555,7 +1542,6 @@ static int sc92031_resume(struct pci_dev *pdev) · 18 unmodified lines
15551542 spin_lock_bh(&priv->lock);
15561543
15571544 _sc92031_reset(dev);
1558− mmiowb();
15591545
15601546 spin_unlock_bh(&priv->lock);
15611547 sc92031_enable_interrupts(dev);
drivers/net/ethernet/via/via-rhine.c+0−3
@@ -571,7 +571,6 @@ static void rhine_ack_events(struct rhine_private *rp, u32 mask) · 570 unmodified lines
571571 if (rp->quirks & rqStatusWBRace)
572572 iowrite8(mask >> 16, ioaddr + IntrStatus2);
573573 iowrite16(mask, ioaddr + IntrStatus);
574− mmiowb();
575574 }
576575
577576 /*
@@ -863,7 +862,6 @@ static int rhine_napipoll(struct napi_struct *napi, int budget) · 285 unmodified lines
863862 if (work_done < budget) {
864863 napi_complete_done(napi, work_done);
865864 iowrite16(enable_mask, ioaddr + IntrEnable);
866− mmiowb();
867865 }
868866 return work_done;
869867 }
@@ -1893,7 +1891,6 @@ static netdev_tx_t rhine_start_tx(struct sk_buff *skb, · 1023 unmodified lines
18931891 static void rhine_irq_disable(struct rhine_private *rp)
18941892 {
18951893 iowrite16(0x0000, rp->base + IntrEnable);
1896− mmiowb();
18971894 }
18981895
18991896 /* The interrupt handler does all of the Rx thread work and cleans up
drivers/net/ethernet/wiznet/w5100.c+0−6
@@ -219,7 +219,6 @@ static inline int __w5100_write_direct(struct net_device *ndev, u32 addr, · 218 unmodified lines
219219 static inline int w5100_write_direct(struct net_device *ndev, u32 addr, u8 data)
220220 {
221221 __w5100_write_direct(ndev, addr, data);
222− mmiowb();
223222
224223 return 0;
225224 }
@@ -236,7 +235,6 @@ static int w5100_write16_direct(struct net_device *ndev, u32 addr, u16 data) · 10 unmodified lines
236235 {
237236 __w5100_write_direct(ndev, addr, data >> 8);
238237 __w5100_write_direct(ndev, addr + 1, data);
239− mmiowb();
240238
241239 return 0;
242240 }
@@ -260,8 +258,6 @@ static int w5100_writebulk_direct(struct net_device *ndev, u32 addr, · 17 unmodified lines
260258 for (i = 0; i < len; i++, addr++)
261259 __w5100_write_direct(ndev, addr, *buf++);
262260
263− mmiowb();
264−
265261 return 0;
266262 }
267263
@@ -375,7 +371,6 @@ static int w5100_readbulk_indirect(struct net_device *ndev, u32 addr, u8 *buf, · 107 unmodified lines
375371 for (i = 0; i < len; i++)
376372 *buf++ = w5100_read_direct(ndev, W5100_IDM_DR);
377373
378− mmiowb();
379374 spin_unlock_irqrestore(&mmio_priv->reg_lock, flags);
380375
381376 return 0;
@@ -394,7 +389,6 @@ static int w5100_writebulk_indirect(struct net_device *ndev, u32 addr, · 12 unmodified lines
394389 for (i = 0; i < len; i++)
395390 __w5100_write_direct(ndev, W5100_IDM_DR, *buf++);
396391
397− mmiowb();
398392 spin_unlock_irqrestore(&mmio_priv->reg_lock, flags);
399393
400394 return 0;
drivers/net/ethernet/wiznet/w5300.c+0−15
@@ -141,7 +141,6 @@ static u16 w5300_read_indirect(struct w5300_priv *priv, u16 addr) · 140 unmodified lines
141141
142142 spin_lock_irqsave(&priv->reg_lock, flags);
143143 w5300_write_direct(priv, W5300_IDM_AR, addr);
144− mmiowb();
145144 data = w5300_read_direct(priv, W5300_IDM_DR);
146145 spin_unlock_irqrestore(&priv->reg_lock, flags);
147146
@@ -154,9 +153,7 @@ static void w5300_write_indirect(struct w5300_priv *priv, u16 addr, u16 data) · 6 unmodified lines
154153
155154 spin_lock_irqsave(&priv->reg_lock, flags);
156155 w5300_write_direct(priv, W5300_IDM_AR, addr);
157− mmiowb();
158156 w5300_write_direct(priv, W5300_IDM_DR, data);
159− mmiowb();
160157 spin_unlock_irqrestore(&priv->reg_lock, flags);
161158 }
162159
@@ -192,7 +189,6 @@ static int w5300_command(struct w5300_priv *priv, u16 cmd) · 29 unmodified lines
192189 unsigned long timeout = jiffies + msecs_to_jiffies(100);
193190
194191 w5300_write(priv, W5300_S0_CR, cmd);
195− mmiowb();
196192
197193 while (w5300_read(priv, W5300_S0_CR) != 0) {
198194 if (time_after(jiffies, timeout))
@@ -241,18 +237,15 @@ static void w5300_write_macaddr(struct w5300_priv *priv) · 42 unmodified lines
241237 w5300_write(priv, W5300_SHARH,
242238 ndev->dev_addr[4] << 8 |
243239 ndev->dev_addr[5]);
244− mmiowb();
245240 }
246241
247242 static void w5300_hw_reset(struct w5300_priv *priv)
248243 {
249244 w5300_write_direct(priv, W5300_MR, MR_RST);
250− mmiowb();
251245 mdelay(5);
252246 w5300_write_direct(priv, W5300_MR, priv->indirect ?
253247 MR_WDF(7) | MR_PB | MR_IND :
254248 MR_WDF(7) | MR_PB);
255− mmiowb();
256249 w5300_write(priv, W5300_IMR, 0);
257250 w5300_write_macaddr(priv);
258251
@@ -264,24 +257,20 @@ static void w5300_hw_reset(struct w5300_priv *priv) · 5 unmodified lines
264257 w5300_write32(priv, W5300_TMSRL, 64 << 24);
265258 w5300_write32(priv, W5300_TMSRH, 0);
266259 w5300_write(priv, W5300_MTYPE, 0x00ff);
267− mmiowb();
268260 }
269261
270262 static void w5300_hw_start(struct w5300_priv *priv)
271263 {
272264 w5300_write(priv, W5300_S0_MR, priv->promisc ?
273265 S0_MR_MACRAW : S0_MR_MACRAW_MF);
274− mmiowb();
275266 w5300_command(priv, S0_CR_OPEN);
276267 w5300_write(priv, W5300_S0_IMR, S0_IR_RECV | S0_IR_SENDOK);
277268 w5300_write(priv, W5300_IMR, IR_S0);
278− mmiowb();
279269 }
280270
281271 static void w5300_hw_close(struct w5300_priv *priv)
282272 {
283273 w5300_write(priv, W5300_IMR, 0);
284− mmiowb();
285274 w5300_command(priv, S0_CR_CLOSE);
286275 }
287276
@@ -372,7 +361,6 @@ static netdev_tx_t w5300_start_tx(struct sk_buff *skb, struct net_device *ndev) · 84 unmodified lines
372361 netif_stop_queue(ndev);
373362
374363 w5300_write_frame(priv, skb->data, skb->len);
375− mmiowb();
376364 ndev->stats.tx_packets++;
377365 ndev->stats.tx_bytes += skb->len;
378366 dev_kfree_skb(skb);
@@ -419,7 +407,6 @@ static int w5300_napi_poll(struct napi_struct *napi, int budget) · 40 unmodified lines
419407 if (rx_count < budget) {
420408 napi_complete_done(napi, rx_count);
421409 w5300_write(priv, W5300_IMR, IR_S0);
422− mmiowb();
423410 }
424411
425412 return rx_count;
@@ -434,7 +421,6 @@ static irqreturn_t w5300_interrupt(int irq, void *ndev_instance) · 8 unmodified lines
434421 if (!ir)
435422 return IRQ_NONE;
436423 w5300_write(priv, W5300_S0_IR, ir);
437− mmiowb();
438424
439425 if (ir & S0_IR_SENDOK) {
440426 netif_dbg(priv, tx_done, ndev, "tx done\n");
@@ -444,7 +430,6 @@ static irqreturn_t w5300_interrupt(int irq, void *ndev_instance) · 3 unmodified lines
444430 if (ir & S0_IR_RECV) {
445431 if (napi_schedule_prep(&priv->napi)) {
446432 w5300_write(priv, W5300_IMR, 0);
447− mmiowb();
448433 __napi_schedule(&priv->napi);
449434 }
450435 }
drivers/net/wireless/ath/ath5k/base.c+0−4
@@ -837,7 +837,6 @@ ath5k_txbuf_setup(struct ath5k_hw *ah, struct ath5k_buf *bf, · 836 unmodified lines
837837
838838 txq->link = &ds->ds_link;
839839 ath5k_hw_start_tx_dma(ah, txq->qnum);
840− mmiowb();
841840 spin_unlock_bh(&txq->lock);
842841
843842 return 0;
@@ -2174,7 +2173,6 @@ ath5k_beacon_config(struct ath5k_hw *ah) · 1330 unmodified lines
21742173 }
21752174
21762175 ath5k_hw_set_imr(ah, ah->imask);
2177− mmiowb();
21782176 spin_unlock_bh(&ah->block);
21792177 }
21802178
@@ -2779,7 +2777,6 @@ int ath5k_start(struct ieee80211_hw *hw) · 598 unmodified lines
27792777
27802778 ret = 0;
27812779 done:
2782− mmiowb();
27832780 mutex_unlock(&ah->lock);
27842781
27852782 set_bit(ATH_STAT_STARTED, ah->status);
@@ -2839,7 +2836,6 @@ void ath5k_stop(struct ieee80211_hw *hw) · 53 unmodified lines
28392836 "putting device to sleep\n");
28402837 }
28412838
2842− mmiowb();
28432839 mutex_unlock(&ah->lock);
28442840
28452841 ath5k_stop_tasklets(ah);
drivers/net/wireless/ath/ath5k/mac80211-ops.c+0−2
@@ -263,7 +263,6 @@ ath5k_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, · 262 unmodified lines
263263 memcpy(common->curbssid, bss_conf->bssid, ETH_ALEN);
264264 common->curaid = 0;
265265 ath5k_hw_set_bssid(ah);
266− mmiowb();
267266 }
268267
269268 if (changes & BSS_CHANGED_BEACON_INT)
@@ -528,7 +527,6 @@ ath5k_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, · 258 unmodified lines
528527 ret = -EINVAL;
529528 }
530529
531− mmiowb();
532530 mutex_unlock(&ah->lock);
533531 return ret;
534532 }
drivers/net/wireless/broadcom/b43/main.c+0−7
@@ -485,7 +485,6 @@ static void b43_ram_write(struct b43_wldev *dev, u16 offset, u32 val) · 484 unmodified lines
485485 val = swab32(val);
486486
487487 b43_write32(dev, B43_MMIO_RAM_CONTROL, offset);
488− mmiowb();
489488 b43_write32(dev, B43_MMIO_RAM_DATA, val);
490489 }
491490
@@ -656,9 +655,7 @@ static void b43_tsf_write_locked(struct b43_wldev *dev, u64 tsf) · 164 unmodified lines
656655 /* The hardware guarantees us an atomic write, if we
657656 * write the low register first. */
658657 b43_write32(dev, B43_MMIO_REV3PLUS_TSF_LOW, low);
659− mmiowb();
660658 b43_write32(dev, B43_MMIO_REV3PLUS_TSF_HIGH, high);
661− mmiowb();
662659 }
663660
664661 void b43_tsf_write(struct b43_wldev *dev, u64 tsf)
@@ -1822,11 +1819,9 @@ static void b43_beacon_update_trigger_work(struct work_struct *work) · 1157 unmodified lines
18221819 if (b43_bus_host_is_sdio(dev->dev)) {
18231820 /* wl->mutex is enough. */
18241821 b43_do_beacon_update_trigger_work(dev);
1825− mmiowb();
18261822 } else {
18271823 spin_lock_irq(&wl->hardirq_lock);
18281824 b43_do_beacon_update_trigger_work(dev);
1829− mmiowb();
18301825 spin_unlock_irq(&wl->hardirq_lock);
18311826 }
18321827 }
@@ -2078,7 +2073,6 @@ static irqreturn_t b43_interrupt_thread_handler(int irq, void *dev_id) · 245 unmodified lines
20782073
20792074 mutex_lock(&dev->wl->mutex);
20802075 b43_do_interrupt_thread(dev);
2081− mmiowb();
20822076 mutex_unlock(&dev->wl->mutex);
20832077
20842078 return IRQ_HANDLED;
@@ -2143,7 +2137,6 @@ static irqreturn_t b43_interrupt_handler(int irq, void *dev_id) · 58 unmodified lines
21432137
21442138 spin_lock(&dev->wl->hardirq_lock);
21452139 ret = b43_do_interrupt(dev);
2146− mmiowb();
21472140 spin_unlock(&dev->wl->hardirq_lock);
21482141
21492142 return ret;
drivers/net/wireless/broadcom/b43/sysfs.c+0−1
@@ -129,7 +129,6 @@ static ssize_t b43_attr_interfmode_store(struct device *dev, · 128 unmodified lines
129129 } else
130130 err = -ENOSYS;
131131
132− mmiowb();
133132 mutex_unlock(&wldev->wl->mutex);
134133
135134 return err ? err : count;
drivers/net/wireless/broadcom/b43legacy/ilt.c+0−2
@@ -315,14 +315,12 @@ const u16 b43legacy_ilt_sigmasqr2[B43legacy_ILT_SIGMASQR_SIZE] = { · 314 unmodified lines
315315 void b43legacy_ilt_write(struct b43legacy_wldev *dev, u16 offset, u16 val)
316316 {
317317 b43legacy_phy_write(dev, B43legacy_PHY_ILT_G_CTRL, offset);
318− mmiowb();
319318 b43legacy_phy_write(dev, B43legacy_PHY_ILT_G_DATA1, val);
320319 }
321320
322321 void b43legacy_ilt_write32(struct b43legacy_wldev *dev, u16 offset, u32 val)
323322 {
324323 b43legacy_phy_write(dev, B43legacy_PHY_ILT_G_CTRL, offset);
325− mmiowb();
326324 b43legacy_phy_write(dev, B43legacy_PHY_ILT_G_DATA2,
327325 (val & 0xFFFF0000) >> 16);
328326 b43legacy_phy_write(dev, B43legacy_PHY_ILT_G_DATA1,
drivers/net/wireless/broadcom/b43legacy/main.c+0−20
@@ -264,7 +264,6 @@ static void b43legacy_ram_write(struct b43legacy_wldev *dev, u16 offset, · 263 unmodified lines
264264 val = swab32(val);
265265
266266 b43legacy_write32(dev, B43legacy_MMIO_RAM_CONTROL, offset);
267− mmiowb();
268267 b43legacy_write32(dev, B43legacy_MMIO_RAM_DATA, val);
269268 }
270269
@@ -341,14 +340,11 @@ void b43legacy_shm_write32(struct b43legacy_wldev *dev, · 70 unmodified lines
341340 if (offset & 0x0003) {
342341 /* Unaligned access */
343342 b43legacy_shm_control_word(dev, routing, offset >> 2);
344− mmiowb();
345343 b43legacy_write16(dev,
346344 B43legacy_MMIO_SHM_DATA_UNALIGNED,
347345 (value >> 16) & 0xffff);
348− mmiowb();
349346 b43legacy_shm_control_word(dev, routing,
350347 (offset >> 2) + 1);
351− mmiowb();
352348 b43legacy_write16(dev, B43legacy_MMIO_SHM_DATA,
353349 value & 0xffff);
354350 return;
@@ -356,7 +352,6 @@ void b43legacy_shm_write32(struct b43legacy_wldev *dev, · 1 unmodified line
356352 offset >>= 2;
357353 }
358354 b43legacy_shm_control_word(dev, routing, offset);
359− mmiowb();
360355 b43legacy_write32(dev, B43legacy_MMIO_SHM_DATA, value);
361356 }
362357
@@ -368,7 +363,6 @@ void b43legacy_shm_write16(struct b43legacy_wldev *dev, u16 routing, u16 offset, · 5 unmodified lines
368363 if (offset & 0x0003) {
369364 /* Unaligned access */
370365 b43legacy_shm_control_word(dev, routing, offset >> 2);
371− mmiowb();
372366 b43legacy_write16(dev,
373367 B43legacy_MMIO_SHM_DATA_UNALIGNED,
374368 value);
@@ -377,7 +371,6 @@ void b43legacy_shm_write16(struct b43legacy_wldev *dev, u16 routing, u16 offset, · 2 unmodified lines
377371 offset >>= 2;
378372 }
379373 b43legacy_shm_control_word(dev, routing, offset);
380− mmiowb();
381374 b43legacy_write16(dev, B43legacy_MMIO_SHM_DATA, value);
382375 }
383376
@@ -471,7 +464,6 @@ static void b43legacy_time_lock(struct b43legacy_wldev *dev) · 87 unmodified lines
471464 status = b43legacy_read32(dev, B43legacy_MMIO_MACCTL);
472465 status |= B43legacy_MACCTL_TBTTHOLD;
473466 b43legacy_write32(dev, B43legacy_MMIO_MACCTL, status);
474− mmiowb();
475467 }
476468
477469 static void b43legacy_time_unlock(struct b43legacy_wldev *dev)
@@ -494,10 +486,8 @@ static void b43legacy_tsf_write_locked(struct b43legacy_wldev *dev, u64 tsf) · 16 unmodified lines
494486 u32 hi = (tsf & 0xFFFFFFFF00000000ULL) >> 32;
495487
496488 b43legacy_write32(dev, B43legacy_MMIO_REV3PLUS_TSF_LOW, 0);
497− mmiowb();
498489 b43legacy_write32(dev, B43legacy_MMIO_REV3PLUS_TSF_HIGH,
499490 hi);
500− mmiowb();
501491 b43legacy_write32(dev, B43legacy_MMIO_REV3PLUS_TSF_LOW,
502492 lo);
503493 } else {
@@ -507,13 +497,9 @@ static void b43legacy_tsf_write_locked(struct b43legacy_wldev *dev, u64 tsf) · 3 unmodified lines
507497 u16 v3 = (tsf & 0xFFFF000000000000ULL) >> 48;
508498
509499 b43legacy_write16(dev, B43legacy_MMIO_TSF_0, 0);
510− mmiowb();
511500 b43legacy_write16(dev, B43legacy_MMIO_TSF_3, v3);
512− mmiowb();
513501 b43legacy_write16(dev, B43legacy_MMIO_TSF_2, v2);
514− mmiowb();
515502 b43legacy_write16(dev, B43legacy_MMIO_TSF_1, v1);
516− mmiowb();
517503 b43legacy_write16(dev, B43legacy_MMIO_TSF_0, v0);
518504 }
519505 }
@@ -1250,7 +1236,6 @@ static void b43legacy_beacon_update_trigger_work(struct work_struct *work) · 730 unmodified lines
12501236 /* The handler might have updated the IRQ mask. */
12511237 b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK,
12521238 dev->irq_mask);
1253− mmiowb();
12541239 spin_unlock_irq(&wl->irq_lock);
12551240 }
12561241 mutex_unlock(&wl->mutex);
@@ -1346,7 +1331,6 @@ static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev) · 89 unmodified lines
13461331 dma_reason[2], dma_reason[3],
13471332 dma_reason[4], dma_reason[5]);
13481333 b43legacy_controller_restart(dev, "DMA error");
1349− mmiowb();
13501334 spin_unlock_irqrestore(&dev->wl->irq_lock, flags);
13511335 return;
13521336 }
@@ -1396,7 +1380,6 @@ static void b43legacy_interrupt_tasklet(struct b43legacy_wldev *dev) · 43 unmodified lines
13961380 handle_irq_transmit_status(dev);
13971381
13981382 b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK, dev->irq_mask);
1399− mmiowb();
14001383 spin_unlock_irqrestore(&dev->wl->irq_lock, flags);
14011384 }
14021385
@@ -1488,7 +1471,6 @@ static irqreturn_t b43legacy_interrupt_handler(int irq, void *dev_id) · 85 unmodified lines
14881471 dev->irq_reason = reason;
14891472 tasklet_schedule(&dev->isr_tasklet);
14901473 out:
1491− mmiowb();
14921474 spin_unlock(&dev->wl->irq_lock);
14931475
14941476 return ret;
@@ -2781,7 +2763,6 @@ static int b43legacy_op_dev_config(struct ieee80211_hw *hw, · 1286 unmodified lines
27812763
27822764 spin_lock_irqsave(&wl->irq_lock, flags);
27832765 b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK, dev->irq_mask);
2784− mmiowb();
27852766 spin_unlock_irqrestore(&wl->irq_lock, flags);
27862767 out_unlock_mutex:
27872768 mutex_unlock(&wl->mutex);
@@ -2900,7 +2881,6 @@ static void b43legacy_op_bss_info_changed(struct ieee80211_hw *hw, · 112 unmodified lines
29002881 spin_lock_irqsave(&wl->irq_lock, flags);
29012882 b43legacy_write32(dev, B43legacy_MMIO_GEN_IRQ_MASK, dev->irq_mask);
29022883 /* XXX: why? */
2903− mmiowb();
29042884 spin_unlock_irqrestore(&wl->irq_lock, flags);
29052885 out_unlock_mutex:
29062886 mutex_unlock(&wl->mutex);
drivers/net/wireless/broadcom/b43legacy/phy.c+0−1
@@ -134,7 +134,6 @@ u16 b43legacy_phy_read(struct b43legacy_wldev *dev, u16 offset) · 133 unmodified lines
134134 void b43legacy_phy_write(struct b43legacy_wldev *dev, u16 offset, u16 val)
135135 {
136136 b43legacy_write16(dev, B43legacy_MMIO_PHY_CONTROL, offset);
137− mmiowb();
138137 b43legacy_write16(dev, B43legacy_MMIO_PHY_DATA, val);
139138 }
140139
drivers/net/wireless/broadcom/b43legacy/pio.h+0−1
@@ -92,7 +92,6 @@ void b43legacy_pio_write(struct b43legacy_pioqueue *queue, · 91 unmodified lines
9292 u16 offset, u16 value)
9393 {
9494 b43legacy_write16(queue->dev, queue->mmio_base + offset, value);
95− mmiowb();
9695 }
9796
9897
drivers/net/wireless/broadcom/b43legacy/radio.c+0−4
@@ -95,7 +95,6 @@ void b43legacy_radio_lock(struct b43legacy_wldev *dev) · 94 unmodified lines
9595 B43legacy_WARN_ON(status & B43legacy_MACCTL_RADIOLOCK);
9696 status |= B43legacy_MACCTL_RADIOLOCK;
9797 b43legacy_write32(dev, B43legacy_MMIO_MACCTL, status);
98− mmiowb();
9998 udelay(10);
10099 }
101100
@@ -108,7 +107,6 @@ void b43legacy_radio_unlock(struct b43legacy_wldev *dev) · 6 unmodified lines
108107 B43legacy_WARN_ON(!(status & B43legacy_MACCTL_RADIOLOCK));
109108 status &= ~B43legacy_MACCTL_RADIOLOCK;
110109 b43legacy_write32(dev, B43legacy_MMIO_MACCTL, status);
111− mmiowb();
112110 }
113111
114112 u16 b43legacy_radio_read16(struct b43legacy_wldev *dev, u16 offset)
@@ -141,7 +139,6 @@ u16 b43legacy_radio_read16(struct b43legacy_wldev *dev, u16 offset) · 26 unmodified lines
141139 void b43legacy_radio_write16(struct b43legacy_wldev *dev, u16 offset, u16 val)
142140 {
143141 b43legacy_write16(dev, B43legacy_MMIO_RADIO_CONTROL, offset);
144− mmiowb();
145142 b43legacy_write16(dev, B43legacy_MMIO_RADIO_DATA_LOW, val);
146143 }
147144
@@ -333,7 +330,6 @@ u8 b43legacy_radio_aci_scan(struct b43legacy_wldev *dev) · 185 unmodified lines
333330 void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val)
334331 {
335332 b43legacy_phy_write(dev, B43legacy_PHY_NRSSILT_CTRL, offset);
336− mmiowb();
337333 b43legacy_phy_write(dev, B43legacy_PHY_NRSSILT_DATA, (u16)val);
338334 }
339335
drivers/net/wireless/broadcom/b43legacy/sysfs.c+0−1
@@ -143,7 +143,6 @@ static ssize_t b43legacy_attr_interfmode_store(struct device *dev, · 142 unmodified lines
143143 if (err)
144144 b43legacyerr(wldev->wl, "Interference Mitigation not "
145145 "supported by device\n");
146− mmiowb();
147146 spin_unlock_irqrestore(&wldev->wl->irq_lock, flags);
148147 mutex_unlock(&wldev->wl->mutex);
149148
drivers/net/wireless/intel/iwlegacy/common.h+0−7
@@ -2030,13 +2030,6 @@ static inline void · 2029 unmodified lines
20302030 _il_release_nic_access(struct il_priv *il)
20312031 {
20322032 _il_clear_bit(il, CSR_GP_CNTRL, CSR_GP_CNTRL_REG_FLAG_MAC_ACCESS_REQ);
2033− /*
2034− * In above we are reading CSR_GP_CNTRL register, what will flush any
2035− * previous writes, but still want write, which clear MAC_ACCESS_REQ
2036− * bit, be performed on PCI bus before any other writes scheduled on
2037− * different CPUs (after we drop reg_lock).
2038− */
2039− mmiowb();
20402033 }
20412034
20422035 static inline u32
drivers/net/wireless/intel/iwlwifi/pcie/trans.c+0−1
@@ -2067,7 +2067,6 @@ static void iwl_trans_pcie_release_nic_access(struct iwl_trans *trans, · 2066 unmodified lines
20672067 * MAC_ACCESS_REQ bit to be performed before any other writes
20682068 * scheduled on different CPUs (after we drop reg_lock).
20692069 */
2070− mmiowb();
20712070 out:
20722071 spin_unlock_irqrestore(&trans_pcie->reg_lock, *flags);
20732072 }
drivers/ntb/hw/idt/ntb_hw_idt.c+0−7
@@ -358,8 +358,6 @@ static void idt_sw_write(struct idt_ntb_dev *ndev, · 357 unmodified lines
358358 iowrite32((u32)reg, ndev->cfgspc + (ptrdiff_t)IDT_NT_GASAADDR);
359359 /* Put the new value of the register */
360360 iowrite32(data, ndev->cfgspc + (ptrdiff_t)IDT_NT_GASADATA);
361− /* Make sure the PCIe transactions are executed */
362− mmiowb();
363361 /* Unlock GASA registers operations */
364362 spin_unlock_irqrestore(&ndev->gasa_lock, irqflags);
365363 }
@@ -750,7 +748,6 @@ static void idt_ntb_local_link_enable(struct idt_ntb_dev *ndev) · 384 unmodified lines
750748 spin_lock_irqsave(&ndev->mtbl_lock, irqflags);
751749 idt_nt_write(ndev, IDT_NT_NTMTBLADDR, ndev->part);
752750 idt_nt_write(ndev, IDT_NT_NTMTBLDATA, mtbldata);
753− mmiowb();
754751 spin_unlock_irqrestore(&ndev->mtbl_lock, irqflags);
755752
756753 /* Notify the peers by setting and clearing the global signal bit */
@@ -778,7 +775,6 @@ static void idt_ntb_local_link_disable(struct idt_ntb_dev *ndev) · 21 unmodified lines
778775 spin_lock_irqsave(&ndev->mtbl_lock, irqflags);
779776 idt_nt_write(ndev, IDT_NT_NTMTBLADDR, ndev->part);
780777 idt_nt_write(ndev, IDT_NT_NTMTBLDATA, 0);
781− mmiowb();
782778 spin_unlock_irqrestore(&ndev->mtbl_lock, irqflags);
783779
784780 /* Notify the peers by setting and clearing the global signal bit */
@@ -1339,7 +1335,6 @@ static int idt_ntb_peer_mw_set_trans(struct ntb_dev *ntb, int pidx, int widx, · 554 unmodified lines
13391335 idt_nt_write(ndev, IDT_NT_LUTLDATA, (u32)addr);
13401336 idt_nt_write(ndev, IDT_NT_LUTMDATA, (u32)(addr >> 32));
13411337 idt_nt_write(ndev, IDT_NT_LUTUDATA, data);
1342− mmiowb();
13431338 spin_unlock_irqrestore(&ndev->lut_lock, irqflags);
13441339 /* Limit address isn't specified since size is fixed for LUT */
13451340 }
@@ -1393,7 +1388,6 @@ static int idt_ntb_peer_mw_clear_trans(struct ntb_dev *ntb, int pidx, · 47 unmodified lines
13931388 idt_nt_write(ndev, IDT_NT_LUTLDATA, 0);
13941389 idt_nt_write(ndev, IDT_NT_LUTMDATA, 0);
13951390 idt_nt_write(ndev, IDT_NT_LUTUDATA, 0);
1396− mmiowb();
13971391 spin_unlock_irqrestore(&ndev->lut_lock, irqflags);
13981392 }
13991393
@@ -1812,7 +1806,6 @@ static int idt_ntb_peer_msg_write(struct ntb_dev *ntb, int pidx, int midx, · 412 unmodified lines
18121806 /* Set the route and send the data */
18131807 idt_sw_write(ndev, partdata_tbl[ndev->part].msgctl[midx], swpmsgctl);
18141808 idt_nt_write(ndev, ntdata_tbl.msgs[midx].out, msg);
1815− mmiowb();
18161809 /* Unlock the messages routing table */
18171810 spin_unlock_irqrestore(&ndev->msg_locks[midx], irqflags);
18181811
drivers/ntb/test/ntb_perf.c+0−3
@@ -284,11 +284,9 @@ static int perf_spad_cmd_send(struct perf_peer *peer, enum perf_cmd cmd, · 283 unmodified lines
284284 ntb_peer_spad_write(perf->ntb, peer->pidx,
285285 PERF_SPAD_HDATA(perf->gidx),
286286 upper_32_bits(data));
287− mmiowb();
288287 ntb_peer_spad_write(perf->ntb, peer->pidx,
289288 PERF_SPAD_CMD(perf->gidx),
290289 cmd);
291− mmiowb();
292290 ntb_peer_db_set(perf->ntb, PERF_SPAD_NOTIFY(peer->gidx));
293291
294292 dev_dbg(&perf->ntb->dev, "DB ring peer %#llx\n",
@@ -379,7 +377,6 @@ static int perf_msg_cmd_send(struct perf_peer *peer, enum perf_cmd cmd, · 84 unmodified lines
379377
380378 ntb_peer_msg_write(perf->ntb, peer->pidx, PERF_MSG_HDATA,
381379 upper_32_bits(data));
382− mmiowb();
383380
384381 /* This call shall trigger peer message event */
385382 ntb_peer_msg_write(perf->ntb, peer->pidx, PERF_MSG_CMD, cmd);
drivers/scsi/bfa/bfa.h+1−2
@@ -62,8 +62,7 @@ void bfa_isr_unhandled(struct bfa_s *bfa, struct bfi_msg_s *m); · 61 unmodified lines
6262 ((__bfa)->iocfc.cfg.drvcfg.num_reqq_elems - 1); \
6363 writel((__bfa)->iocfc.req_cq_pi[__reqq], \
6464 (__bfa)->iocfc.bfa_regs.cpe_q_pi[__reqq]); \
65− mmiowb(); \
66− } while (0)
65+ } while (0)
6766
6867 #define bfa_rspq_pi(__bfa, __rspq) \
6968 (*(u32 *)((__bfa)->iocfc.rsp_cq_shadow_pi[__rspq].kva))
drivers/scsi/bfa/bfa_hw_cb.c+0−2
@@ -61,7 +61,6 @@ bfa_hwcb_rspq_ack_msix(struct bfa_s *bfa, int rspq, u32 ci) · 60 unmodified lines
6161
6262 bfa_rspq_ci(bfa, rspq) = ci;
6363 writel(ci, bfa->iocfc.bfa_regs.rme_q_ci[rspq]);
64− mmiowb();
6564 }
6665
6766 void
@@ -72,7 +71,6 @@ bfa_hwcb_rspq_ack(struct bfa_s *bfa, int rspq, u32 ci) · 4 unmodified lines
7271
7372 bfa_rspq_ci(bfa, rspq) = ci;
7473 writel(ci, bfa->iocfc.bfa_regs.rme_q_ci[rspq]);
75− mmiowb();
7674 }
7775
7876 void
drivers/scsi/bfa/bfa_hw_ct.c+0−2
@@ -81,7 +81,6 @@ bfa_hwct_rspq_ack(struct bfa_s *bfa, int rspq, u32 ci) · 80 unmodified lines
8181
8282 bfa_rspq_ci(bfa, rspq) = ci;
8383 writel(ci, bfa->iocfc.bfa_regs.rme_q_ci[rspq]);
84− mmiowb();
8584 }
8685
8786 /*
@@ -94,7 +93,6 @@ bfa_hwct2_rspq_ack(struct bfa_s *bfa, int rspq, u32 ci) · 6 unmodified lines
9493 {
9594 bfa_rspq_ci(bfa, rspq) = ci;
9695 writel(ci, bfa->iocfc.bfa_regs.rme_q_ci[rspq]);
97− mmiowb();
9896 }
9997
10098 void
drivers/scsi/bnx2fc/bnx2fc_hwi.c+0−2
@@ -991,7 +991,6 @@ void bnx2fc_arm_cq(struct bnx2fc_rport *tgt) · 990 unmodified lines
991991 FCOE_CQE_TOGGLE_BIT_SHIFT);
992992 msg = *((u32 *)rx_db);
993993 writel(cpu_to_le32(msg), tgt->ctx_base);
994− mmiowb();
995994
996995 }
997996
@@ -1409,7 +1408,6 @@ void bnx2fc_ring_doorbell(struct bnx2fc_rport *tgt) · 411 unmodified lines
14091408 (tgt->sq_curr_toggle_bit << 15);
14101409 msg = *((u32 *)sq_db);
14111410 writel(cpu_to_le32(msg), tgt->ctx_base);
1412− mmiowb();
14131411
14141412 }
14151413
drivers/scsi/bnx2i/bnx2i_hwi.c+0−3
@@ -253,7 +253,6 @@ void bnx2i_put_rq_buf(struct bnx2i_conn *bnx2i_conn, int count) · 252 unmodified lines
253253 writew(ep->qp.rq_prod_idx,
254254 ep->qp.ctx_base + CNIC_RECV_DOORBELL);
255255 }
256− mmiowb();
257256 }
258257
259258
@@ -279,8 +278,6 @@ static void bnx2i_ring_sq_dbell(struct bnx2i_conn *bnx2i_conn, int count) · 19 unmodified lines
279278 bnx2i_ring_577xx_doorbell(bnx2i_conn);
280279 } else
281280 writew(count, ep->qp.ctx_base + CNIC_SEND_DOORBELL);
282−
283− mmiowb();
284281 }
285282
286283
drivers/scsi/megaraid/megaraid_sas_base.c+0−1
@@ -815,7 +815,6 @@ megasas_fire_cmd_skinny(struct megasas_instance *instance, · 814 unmodified lines
815815 &(regs)->inbound_high_queue_port);
816816 writel((lower_32_bits(frame_phys_addr) | (frame_count<<1))|1,
817817 &(regs)->inbound_low_queue_port);
818− mmiowb();
819818 spin_unlock_irqrestore(&instance->hba_lock, flags);
820819 }
821820
drivers/scsi/megaraid/megaraid_sas_fusion.c+0−1
@@ -242,7 +242,6 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance, · 241 unmodified lines
242242 &instance->reg_set->inbound_low_queue_port);
243243 writel(le32_to_cpu(req_desc->u.high),
244244 &instance->reg_set->inbound_high_queue_port);
245− mmiowb();
246245 spin_unlock_irqrestore(&instance->hba_lock, flags);
247246 #endif
248247 }
drivers/scsi/mpt3sas/mpt3sas_base.c+0−1
@@ -3333,7 +3333,6 @@ _base_mpi_ep_writeq(__u64 b, volatile void __iomem *addr, · 3332 unmodified lines
33333333 spin_lock_irqsave(writeq_lock, flags);
33343334 __raw_writel((u32)(b), addr);
33353335 __raw_writel((u32)(b >> 32), (addr + 4));
3336− mmiowb();
33373336 spin_unlock_irqrestore(writeq_lock, flags);
33383337 }
33393338
drivers/scsi/qedf/qedf_io.c+0−1
@@ -807,7 +807,6 @@ void qedf_ring_doorbell(struct qedf_rport *fcport) · 806 unmodified lines
807807 writel(*(u32 *)&dbell, fcport->p_doorbell);
808808 /* Make sure SQ index is updated so f/w prcesses requests in order */
809809 wmb();
810− mmiowb();
811810 }
812811
813812 static void qedf_trace_io(struct qedf_rport *fcport, struct qedf_ioreq *io_req,
drivers/scsi/qedi/qedi_fw.c+0−1
@@ -985,7 +985,6 @@ static void qedi_ring_doorbell(struct qedi_conn *qedi_conn) · 984 unmodified lines
985985 * others they are two different assembly operations.
986986 */
987987 wmb();
988− mmiowb();
989988 QEDI_INFO(&qedi_conn->qedi->dbg_ctx, QEDI_LOG_MP_REQ,
990989 "prod_idx=0x%x, fw_prod_idx=0x%x, cid=0x%x\n",
991990 qedi_conn->ep->sq_prod_idx, qedi_conn->ep->fw_sq_prod_idx,
drivers/scsi/qla1280.c+0−5
@@ -3004,8 +3004,6 @@ qla1280_64bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp) · 3003 unmodified lines
30043004 sp->flags |= SRB_SENT;
30053005 ha->actthreads++;
30063006 WRT_REG_WORD(&reg->mailbox4, ha->req_ring_index);
3007− /* Enforce mmio write ordering; see comment in qla1280_isp_cmd(). */
3008− mmiowb();
30093007
30103008 out:
30113009 if (status)
@@ -3254,8 +3252,6 @@ qla1280_32bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp) · 242 unmodified lines
32543252 sp->flags |= SRB_SENT;
32553253 ha->actthreads++;
32563254 WRT_REG_WORD(&reg->mailbox4, ha->req_ring_index);
3257− /* Enforce mmio write ordering; see comment in qla1280_isp_cmd(). */
3258− mmiowb();
32593255
32603256 out:
32613257 if (status)
@@ -3379,7 +3375,6 @@ qla1280_isp_cmd(struct scsi_qla_host *ha) · 117 unmodified lines
33793375 * See Documentation/driver-api/device-io.rst for more information.
33803376 */
33813377 WRT_REG_WORD(&reg->mailbox4, ha->req_ring_index);
3382− mmiowb();
33833378
33843379 LEAVE("qla1280_isp_cmd");
33853380 }
drivers/ssb/pci.c+0−1
@@ -305,7 +305,6 @@ static int sprom_do_write(struct ssb_bus *bus, const u16 *sprom) · 304 unmodified lines
305305 else if (i % 2)
306306 pr_cont(".");
307307 writew(sprom[i], bus->mmio + bus->sprom_offset + (i * 2));
308− mmiowb();
309308 msleep(20);
310309 }
311310 err = pci_read_config_dword(pdev, SSB_SPROMCTL, &spromctl);
drivers/ssb/pcmcia.c+0−4
@@ -338,7 +338,6 @@ static void ssb_pcmcia_write8(struct ssb_device *dev, u16 offset, u8 value) · 337 unmodified lines
338338 err = select_core_and_segment(dev, &offset);
339339 if (likely(!err))
340340 writeb(value, bus->mmio + offset);
341− mmiowb();
342341 spin_unlock_irqrestore(&bus->bar_lock, flags);
343342 }
344343
@@ -352,7 +351,6 @@ static void ssb_pcmcia_write16(struct ssb_device *dev, u16 offset, u16 value) · 7 unmodified lines
352351 err = select_core_and_segment(dev, &offset);
353352 if (likely(!err))
354353 writew(value, bus->mmio + offset);
355− mmiowb();
356354 spin_unlock_irqrestore(&bus->bar_lock, flags);
357355 }
358356
@@ -368,7 +366,6 @@ static void ssb_pcmcia_write32(struct ssb_device *dev, u16 offset, u32 value) · 9 unmodified lines
368366 writew((value & 0x0000FFFF), bus->mmio + offset);
369367 writew(((value & 0xFFFF0000) >> 16), bus->mmio + offset + 2);
370368 }
371− mmiowb();
372369 spin_unlock_irqrestore(&bus->bar_lock, flags);
373370 }
374371
@@ -424,7 +421,6 @@ static void ssb_pcmcia_block_write(struct ssb_device *dev, const void *buffer, · 49 unmodified lines
424421 WARN_ON(1);
425422 }
426423 unlock:
427− mmiowb();
428424 spin_unlock_irqrestore(&bus->bar_lock, flags);
429425 }
430426 #endif /* CONFIG_SSB_BLOCKIO */
drivers/staging/comedi/drivers/mite.c+0−3
@@ -371,7 +371,6 @@ static unsigned int mite_get_status(struct mite_channel *mite_chan) · 370 unmodified lines
371371 writel(CHOR_CLRDONE,
372372 mite->mmio + MITE_CHOR(mite_chan->channel));
373373 }
374− mmiowb();
375374 spin_unlock_irqrestore(&mite->lock, flags);
376375 return status;
377376 }
@@ -451,7 +450,6 @@ void mite_dma_arm(struct mite_channel *mite_chan) · 73 unmodified lines
451450 mite_chan->done = 0;
452451 /* arm */
453452 writel(CHOR_START, mite->mmio + MITE_CHOR(mite_chan->channel));
454− mmiowb();
455453 spin_unlock_irqrestore(&mite->lock, flags);
456454 }
457455 EXPORT_SYMBOL_GPL(mite_dma_arm);
@@ -638,7 +636,6 @@ void mite_release_channel(struct mite_channel *mite_chan) · 180 unmodified lines
638636 CHCR_CLR_LC_IE | CHCR_CLR_CONT_RB_IE,
639637 mite->mmio + MITE_CHCR(mite_chan->channel));
640638 mite_chan->ring = NULL;
641− mmiowb();
642639 }
643640 spin_unlock_irqrestore(&mite->lock, flags);
644641 }
drivers/staging/comedi/drivers/ni_660x.c+0−2
@@ -320,7 +320,6 @@ static inline void ni_660x_set_dma_channel(struct comedi_device *dev, · 319 unmodified lines
320320 ni_660x_write(dev, chip, devpriv->dma_cfg[chip] |
321321 NI660X_DMA_CFG_RESET(mite_channel),
322322 NI660X_DMA_CFG);
323− mmiowb();
324323 }
325324
326325 static inline void ni_660x_unset_dma_channel(struct comedi_device *dev,
@@ -333,7 +332,6 @@ static inline void ni_660x_unset_dma_channel(struct comedi_device *dev, · 6 unmodified lines
333332 devpriv->dma_cfg[chip] &= ~NI660X_DMA_CFG_SEL_MASK(mite_channel);
334333 devpriv->dma_cfg[chip] |= NI660X_DMA_CFG_SEL_NONE(mite_channel);
335334 ni_660x_write(dev, chip, devpriv->dma_cfg[chip], NI660X_DMA_CFG);
336− mmiowb();
337335 }
338336
339337 static int ni_660x_request_mite_channel(struct comedi_device *dev,
drivers/staging/comedi/drivers/ni_mio_common.c+0−1
@@ -547,7 +547,6 @@ static inline void ni_set_bitfield(struct comedi_device *dev, int reg, · 546 unmodified lines
547547 reg);
548548 break;
549549 }
550− mmiowb();
551550 spin_unlock_irqrestore(&devpriv->soft_reg_copy_lock, flags);
552551 }
553552
drivers/staging/comedi/drivers/ni_pcidio.c+0−2
@@ -310,7 +310,6 @@ static int ni_pcidio_request_di_mite_channel(struct comedi_device *dev) · 309 unmodified lines
310310 writeb(primary_DMAChannel_bits(devpriv->di_mite_chan->channel) |
311311 secondary_DMAChannel_bits(devpriv->di_mite_chan->channel),
312312 dev->mmio + DMA_LINE_CONTROL_GROUP1);
313− mmiowb();
314313 spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);
315314 return 0;
316315 }
@@ -327,7 +326,6 @@ static void ni_pcidio_release_di_mite_channel(struct comedi_device *dev) · 10 unmodified lines
327326 writeb(primary_DMAChannel_bits(0) |
328327 secondary_DMAChannel_bits(0),
329328 dev->mmio + DMA_LINE_CONTROL_GROUP1);
330− mmiowb();
331329 }
332330 spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);
333331 }
drivers/staging/comedi/drivers/ni_tio.c+0−1
@@ -234,7 +234,6 @@ static void ni_tio_set_bits_transient(struct ni_gpct *counter, · 233 unmodified lines
234234 regs[reg] &= ~mask;
235235 regs[reg] |= (value & mask);
236236 ni_tio_write(counter, regs[reg] | transient, reg);
237− mmiowb();
238237 spin_unlock_irqrestore(&counter_dev->regs_lock, flags);
239238 }
240239 }
drivers/staging/comedi/drivers/s626.c+0−2
@@ -108,7 +108,6 @@ static void s626_mc_enable(struct comedi_device *dev, · 107 unmodified lines
108108 {
109109 unsigned int val = (cmd << 16) | cmd;
110110
111− mmiowb();
112111 writel(val, dev->mmio + reg);
113112 }
114113
@@ -116,7 +115,6 @@ static void s626_mc_disable(struct comedi_device *dev, · 1 unmodified line
116115 unsigned int cmd, unsigned int reg)
117116 {
118117 writel(cmd << 16, dev->mmio + reg);
119− mmiowb();
120118 }
121119
122120 static bool s626_mc_test(struct comedi_device *dev,
drivers/tty/serial/men_z135_uart.c+0−1
@@ -353,7 +353,6 @@ static void men_z135_handle_tx(struct men_z135_port *uart) · 352 unmodified lines
353353
354354 memcpy_toio(port->membase + MEN_Z135_TX_RAM, &xmit->buf[xmit->tail], n);
355355 xmit->tail = (xmit->tail + n) & (UART_XMIT_SIZE - 1);
356− mmiowb();
357356
358357 iowrite32(n & 0x3ff, port->membase + MEN_Z135_TX_CTRL);
359358
drivers/tty/serial/serial_txx9.c+0−1
@@ -248,7 +248,6 @@ static void serial_txx9_initialize(struct uart_port *port) · 247 unmodified lines
248248 sio_out(up, TXX9_SIFCR, TXX9_SIFCR_SWRST);
249249 /* TX4925 BUG WORKAROUND. Accessing SIOC register
250250 * immediately after soft reset causes bus error. */
251− mmiowb();
252251 udelay(1);
253252 while ((sio_in(up, TXX9_SIFCR) & TXX9_SIFCR_SWRST) && --tmout)
254253 udelay(1);
drivers/usb/early/xhci-dbc.c+0−4
@@ -533,8 +533,6 @@ static int xdbc_handle_external_reset(void) · 532 unmodified lines
533533
534534 xdbc_mem_init();
535535
536− mmiowb();
537−
538536 ret = xdbc_start();
539537 if (ret < 0)
540538 goto reset_out;
@@ -587,8 +585,6 @@ static int __init xdbc_early_setup(void) · 46 unmodified lines
587585
588586 xdbc_mem_init();
589587
590− mmiowb();
591−
592588 ret = xdbc_start();
593589 if (ret < 0) {
594590 writel(0, &xdbc.xdbc_reg->control);
drivers/usb/host/xhci-dbgcap.c+0−2
@@ -421,8 +421,6 @@ static int xhci_dbc_mem_init(struct xhci_hcd *xhci, gfp_t flags) · 420 unmodified lines
421421 string_length = xhci_dbc_populate_strings(dbc->string);
422422 xhci_dbc_init_contexts(xhci, string_length);
423423
424− mmiowb();
425−
426424 xhci_dbc_eps_init(xhci);
427425 dbc->state = DS_INITIALIZED;
428426
include/linux/qed/qed_if.h+0−2
@@ -1338,7 +1338,6 @@ static inline u16 qed_sb_update_sb_idx(struct qed_sb_info *sb_info) · 1337 unmodified lines
13381338 }
13391339
13401340 /* Let SB update */
1341− mmiowb();
13421341 return rc;
13431342 }
13441343
@@ -1374,7 +1373,6 @@ static inline void qed_sb_ack(struct qed_sb_info *sb_info, · 29 unmodified lines
13741373 /* Both segments (interrupts & acks) are written to same place address;
13751374 * Need to guarantee all commands will be received (in-order) by HW.
13761375 */
1377− mmiowb();
13781376 barrier();
13791377 }
13801378
sound/soc/txx9/txx9aclc-ac97.c+0−1
@@ -102,7 +102,6 @@ static void txx9aclc_ac97_cold_reset(struct snd_ac97 *ac97) · 101 unmodified lines
102102 u32 ready = ACINT_CODECRDY(ac97->num) | ACINT_REGACCRDY;
103103
104104 __raw_writel(ACCTL_ENLINK, base + ACCTLDIS);
105− mmiowb();
106105 udelay(1);
107106 __raw_writel(ACCTL_ENLINK, base + ACCTLEN);
108107 /* wait for primary codec ready status */

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t