History

kernel: avoid overflow in cmp_range

Avoid overflow possibility. [ The overflow is purely theoretical, since this is used for memory ranges that aren't even close to using the full 64 bits, but this is the right thing to do regardless. - Linus ]

Louis Langholtz committed 11 years ago

Commit fc7f0dd1 parent 7ad4b4a1 file · +5 −5Browse files

Unified · Split

kernel/range.c+5−5
@@ -113,12 +113,12 @@ static int cmp_range(const void *x1, const void *x2) · 112 unmodified lines
113113 {
114114 const struct range *r1 = x1;
115115 const struct range *r2 = x2;
116− s64 start1, start2;
117116
118− start1 = r1->start;
119− start2 = r2->start;
120−
121− return start1 - start2;
117+ if (r1->start < r2->start)
118+ return -1;
119+ if (r1->start > r2->start)
120+ return 1;
121+ return 0;
122122 }
123123
124124 int clean_sort_range(struct range *range, int az)

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t