drm/imagination: Move dereference after NULL check in pvr_mmu_backing_page_init()

This code dereferences "page->pvr_dev" and then checked for NULL on the next line. Re-order it to avoid a potential NULL pointer dereference.

Dan Carpenter committed 2 years ago

Commit fca94481 parent b84135e1 file · +3 −1Browse files

Unified · Split

 static void
 pvr_mmu_backing_page_fini(struct pvr_mmu_backing_page *page)
 {
-	struct device *dev = from_pvr_device(page->pvr_dev)->dev;
+	struct device *dev;
 	/* Do nothing if no allocation is present. */
 	if (!page->pvr_dev)
 		return;
+	dev = from_pvr_device(page->pvr_dev)->dev;
 	dma_unmap_page(dev, page->dma_addr, PVR_MMU_BACKING_PAGE_SIZE,
 		       DMA_TO_DEVICE);

Keyboard shortcuts