History

memremap: remove the dev field in struct dev_pagemap

The dev field in struct dev_pagemap is only used to print dev_name in two places, which are at best nice to have. Just remove the field and thus the name in those two messages.

Christoph Hellwig committed 7 years ago

Commit fdc029b1 parent 0c385194 files · +2 −8Browse files

Unified · Split

4 files
  1. include/linux/memremap.h +0 −1
  2. kernel/memremap.c +1 −5
  3. mm/page_alloc.c +1 −1
  4. tools/testing/nvdimm/test/iomap.c +0 −1
include/linux/memremap.h+0−1
@@ -109,7 +109,6 @@ struct dev_pagemap { · 108 unmodified lines
109109 struct percpu_ref *ref;
110110 struct percpu_ref internal_ref;
111111 struct completion done;
112− struct device *dev;
113112 enum memory_type type;
114113 unsigned int flags;
115114 u64 pci_p2pdma_bus_offset;
kernel/memremap.c+1−5
@@ -96,7 +96,6 @@ static void dev_pagemap_cleanup(struct dev_pagemap *pgmap) · 95 unmodified lines
9696 static void devm_memremap_pages_release(void *data)
9797 {
9898 struct dev_pagemap *pgmap = data;
99− struct device *dev = pgmap->dev;
10099 struct resource *res = &pgmap->res;
101100 unsigned long pfn;
102101 int nid;
@@ -123,8 +122,7 @@ static void devm_memremap_pages_release(void *data) · 20 unmodified lines
123122
124123 untrack_pfn(NULL, PHYS_PFN(res->start), resource_size(res));
125124 pgmap_array_delete(res);
126− dev_WARN_ONCE(dev, pgmap->altmap.alloc,
127− "%s: failed to free all reserved pages\n", __func__);
125+ WARN_ONCE(pgmap->altmap.alloc, "failed to free all reserved pages\n");
128126 }
129127
130128 static void dev_pagemap_percpu_release(struct percpu_ref *ref)
@@ -245,8 +243,6 @@ void *devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) · 114 unmodified lines
245243 goto err_array;
246244 }
247245
248− pgmap->dev = dev;
249−
250246 error = xa_err(xa_store_range(&pgmap_array, PHYS_PFN(res->start),
251247 PHYS_PFN(res->end), pgmap, GFP_KERNEL));
252248 if (error)
mm/page_alloc.c+1−1
@@ -5982,7 +5982,7 @@ void __ref memmap_init_zone_device(struct zone *zone, · 5981 unmodified lines
59825982 }
59835983 }
59845984
5985− pr_info("%s initialised, %lu pages in %ums\n", dev_name(pgmap->dev),
5985+ pr_info("%s initialised %lu pages in %ums\n", __func__,
59865986 size, jiffies_to_msecs(jiffies - start));
59875987 }
59885988
tools/testing/nvdimm/test/iomap.c+0−1
@@ -132,7 +132,6 @@ void *__wrap_devm_memremap_pages(struct device *dev, struct dev_pagemap *pgmap) · 131 unmodified lines
132132 if (!nfit_res)
133133 return devm_memremap_pages(dev, pgmap);
134134
135− pgmap->dev = dev;
136135 if (!pgmap->ref) {
137136 if (pgmap->ops && (pgmap->ops->kill || pgmap->ops->cleanup))
138137 return ERR_PTR(-EINVAL);

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t