In the case of get_user_pages_fast() returning fewer pages than requested, rio_dma_transfer() does not quite do the right thing. It attempts to release all the pages that were requested, rather than just the pages that were pinned. Fix the error handling so that only the pages that were successfully pinned are released.
Unified · Split
| @@ -877,6 +877,11 @@ rio_dma_transfer(struct file *filp, u32 transfer_mode, · 876 unmodified lines | |||
| 877 | rmcd_error("pinned %ld out of %ld pages", | 877 | rmcd_error("pinned %ld out of %ld pages", |
| 878 | pinned, nr_pages); | 878 | pinned, nr_pages); |
| 879 | ret = -EFAULT; | 879 | ret = -EFAULT; |
| 880 | /* | ||
| 881 | * Set nr_pages up to mean "how many pages to unpin, in | ||
| 882 | * the error handler: | ||
| 883 | */ | ||
| 884 | nr_pages = pinned; | ||
| 880 | goto err_pg; | 885 | goto err_pg; |
| 881 | } | 886 | } |
| 882 | 887 | ||