History

[codex] fix terminal dimension validation (#2411)

Julius Marminge committed 6 months ago

Commit 02903f21 parent 22b7d8c2 files · +16 −5Browse files

Unified · Split

2 files
  1. packages/contracts/src/terminal.test.ts +12 −1
  2. packages/contracts/src/terminal.ts +4 −4
packages/contracts/src/terminal.test.ts+12−1
@@ -38,13 +38,24 @@ describe("TerminalOpenInput", () => { · 37 unmodified lines
3838 ).toBe(true);
3939 });
4040
41+ it("accepts ultrawide terminal dimensions from xterm fit", () => {
42+ expect(
43+ decodes(TerminalOpenInput, {
44+ threadId: "thread-1",
45+ cwd: "/tmp/project",
46+ cols: 423,
47+ rows: 40,
48+ }),
49+ ).toBe(true);
50+ });
51+
4152 it("rejects invalid bounds", () => {
4253 expect(
4354 decodes(TerminalOpenInput, {
4455 threadId: "thread-1",
4556 cwd: "/tmp/project",
4657 cols: 10,
47− rows: 2,
58+ rows: 0,
4859 }),
4960 ).toBe(false);
5061 });
packages/contracts/src/terminal.ts+4−4
@@ -4,11 +4,11 @@ import { TrimmedNonEmptyString } from "./baseSchemas.ts"; · 3 unmodified lines
44 export const DEFAULT_TERMINAL_ID = "default";
55
66 const TrimmedNonEmptyStringSchema = TrimmedNonEmptyString;
7−const TerminalColsSchema = Schema.Int.check(Schema.isGreaterThanOrEqualTo(20)).check(
8− Schema.isLessThanOrEqualTo(400),
7+const TerminalColsSchema = Schema.Int.check(Schema.isGreaterThanOrEqualTo(1)).check(
8+ Schema.isLessThanOrEqualTo(1000),
99 );
10−const TerminalRowsSchema = Schema.Int.check(Schema.isGreaterThanOrEqualTo(5)).check(
11− Schema.isLessThanOrEqualTo(200),
10+const TerminalRowsSchema = Schema.Int.check(Schema.isGreaterThanOrEqualTo(1)).check(
11+ Schema.isLessThanOrEqualTo(500),
1212 );
1313 const TerminalIdSchema = TrimmedNonEmptyStringSchema.check(Schema.isMaxLength(128));
1414 const TerminalEnvKeySchema = Schema.String.check(

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t