Cap benchmark follow-up pass override for perf safety

Cursor Agent committed 9 months ago

Commit 0afaeeb1 parent 073c1152 files · +12 −1Browse files

Unified · Split

2 files

@@ -161,6 +161,15 @@ describe("resolveBenchmarkFollowUpPassCount", () => { · 160 unmodified lines
161	).toBe(0);	161	).toBe(0);
162	});	162	});
163		163
		164	it("caps explicit overrides to avoid runaway workload", () => {
		165	expect(
		166	resolveBenchmarkFollowUpPassCount({
		167	T3CODE_DESKTOP_PERF_BENCHMARK_FOLLOW_UP_PASSES: "99",
		168	CI: "false",
		169	}),
		170	).toBe(5);
		171	});
		172
164	it("ignores malformed overrides and falls back to CI default", () => {	173	it("ignores malformed overrides and falls back to CI default", () => {
165	expect(	174	expect(
166	resolveBenchmarkFollowUpPassCount({	175	resolveBenchmarkFollowUpPassCount({

 const TRUE_VALUES = new Set(["1", "true", "yes", "on"]);
 const FALSE_VALUES = new Set(["0", "false", "no", "off"]);
+const MAX_BENCHMARK_FOLLOW_UP_PASSES = 5;
 function parseBooleanLike(value: string | undefined): boolean | null {
   const normalized = value?.trim().toLowerCase();
 export function resolveBenchmarkFollowUpPassCount(env: PerfBenchmarkEnv): number {
   const raw = env.T3CODE_DESKTOP_PERF_BENCHMARK_FOLLOW_UP_PASSES?.trim();
   if (raw && /^\d+$/.test(raw)) {
-    return Number.parseInt(raw, 10);
+    const parsed = Number.parseInt(raw, 10);
+    return Math.min(parsed, MAX_BENCHMARK_FOLLOW_UP_PASSES);
   }
   return isCiEnvironment(env.CI) ? 0 : 1;
 }