fix(server): stop showing commit/push/PR notices as errors in the work log (#5559)

Theo Browne committed 3 months ago

Commit 0ec4fbc1 parent ea50b692 files · +27 −3Browse files

Unified · Split

2 files

@@ -2021,6 +2021,24 @@ describe("ClaudeAdapterLive", () => { · 2020 unmodified lines
2021	session_id: "session",	2021	session_id: "session",
2022	uuid: "roster",	2022	uuid: "roster",
2023	},	2023	},
		2024	{
		2025	type: "system",
		2026	subtype: "vcs_state_changed",
		2027	kind: "push",
		2028	cwd: "/tmp/worktree",
		2029	session_id: "session",
		2030	uuid: "vcs",
		2031	},
		2032	{
		2033	type: "system",
		2034	subtype: "code_change_published",
		2035	provider: "github",
		2036	url: "https://github.com/pingdotgg/t3code/pull/1",
		2037	repo: "pingdotgg/t3code",
		2038	identifier: "1",
		2039	session_id: "session",
		2040	uuid: "ccp",
		2041	},
2024	{	2042	{
2025	type: "system",	2043	type: "system",
2026	subtype: "task_updated",	2044	subtype: "task_updated",

     // error rows in client work logs. `background_tasks_changed` is a roster
     // snapshot ({tasks: [...]}) — the task_* lifecycle events carry the
     // authoritative per-agent data and the typed background_tasks control
-    // request is the reconciliation source.
+    // request is the reconciliation source. `vcs_state_changed`
-    if ((message.subtype as string) === "background_tasks_changed") {
+    // ({kind: commit|push|rebase}) and `code_change_published`
-      return;
+    // ({provider, url, repo}) are informational CLI notices; the work log
+    // already shows the underlying git/gh tool calls.
+    switch (message.subtype as string) {
+      case "background_tasks_changed":
+      case "vcs_state_changed":
+      case "code_change_published":
+        return;
     }
     switch (message.subtype) {