Support yes/no env aliases in perf toggle parser

Cursor Agent committed 8 months ago

Commit 1cb08a21 parent c0f80772 files · +37 −6Browse files

Unified · Split

2 files

@@ -36,6 +36,18 @@ describe("shouldRunTerminalPerfInteractions", () => { · 35 unmodified lines
36	CI: "true",	36	CI: "true",
37	}),	37	}),
38	).toBe(true);	38	).toBe(true);
		39	expect(
		40	shouldRunTerminalPerfInteractions({
		41	T3CODE_DESKTOP_PERF_RUN_TERMINAL: " yes ",
		42	CI: "true",
		43	}),
		44	).toBe(true);
		45	expect(
		46	shouldRunTerminalPerfInteractions({
		47	T3CODE_DESKTOP_PERF_RUN_TERMINAL: "ON",
		48	CI: "true",
		49	}),
		50	).toBe(true);
39	});	51	});
40		52
41	it("supports explicit false values", () => {	53	it("supports explicit false values", () => {
@@ -57,6 +69,18 @@ describe("shouldRunTerminalPerfInteractions", () => { · 15 unmodified lines
57	CI: "false",	69	CI: "false",
58	}),	70	}),
59	).toBe(false);	71	).toBe(false);
		72	expect(
		73	shouldRunTerminalPerfInteractions({
		74	T3CODE_DESKTOP_PERF_RUN_TERMINAL: " no ",
		75	CI: "false",
		76	}),
		77	).toBe(false);
		78	expect(
		79	shouldRunTerminalPerfInteractions({
		80	T3CODE_DESKTOP_PERF_RUN_TERMINAL: "OFF",
		81	CI: "false",
		82	}),
		83	).toBe(false);
60	expect(	84	expect(
61	shouldRunTerminalPerfInteractions({	85	shouldRunTerminalPerfInteractions({
62	T3CODE_DESKTOP_PERF_RUN_TERMINAL: "0",	86	T3CODE_DESKTOP_PERF_RUN_TERMINAL: "0",

   CI?: string | undefined;
 };
-const CI_TRUE_VALUES = new Set(["1", "true", "yes", "on"]);
+const TRUE_VALUES = new Set(["1", "true", "yes", "on"]);
+const FALSE_VALUES = new Set(["0", "false", "no", "off"]);
-function isCiEnvironment(value: string | undefined): boolean {
+function parseBooleanLike(value: string | undefined): boolean | null {
   const normalized = value?.trim().toLowerCase();
-  return normalized ? CI_TRUE_VALUES.has(normalized) : false;
+  if (!normalized) return null;
+  if (TRUE_VALUES.has(normalized)) return true;
+  if (FALSE_VALUES.has(normalized)) return false;
+  return null;
+}
+function isCiEnvironment(value: string | undefined): boolean {
+  return parseBooleanLike(value) === true;
 }
 /**
  * flaky PTY-dependent interactions in ephemeral Linux runners.
  */
 export function shouldRunTerminalPerfInteractions(env: PerfToggleEnv): boolean {
-  const raw = env.T3CODE_DESKTOP_PERF_RUN_TERMINAL?.trim().toLowerCase();
+  const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_TERMINAL);
-  if (raw === "1" || raw === "true") return true;
+  if (toggleOverride !== null) return toggleOverride;
-  if (raw === "0" || raw === "false") return false;
   return !isCiEnvironment(env.CI);
 }