History

refactor(web): keep feature component helpers private (#10226)

Julius Marminge committed 2 months ago

Commit 226abe51 parent fdcc49131 files · +46 −79Browse files

Showing the changes to apps/web/src/components/pullRequest (4 of 31 files). Show all

Unified · Split

4 files
  1. apps/web/src/components/pullRequest/PullRequestCodeTab.tsx +1 −1
  2. apps/web/src/components/pullRequest/pullRequestLinkContextMenu.ts +1 −1
  3. apps/web/src/components/pullRequest/pullRequestList.logic.ts +1 −1
  4. apps/web/src/components/pullRequest/pullRequestListPreferences.ts +1 −1
apps/web/src/components/pullRequest/PullRequestCodeTab.tsx+1−1
@@ -187,7 +187,7 @@ function getReviewPositionAnchor(position: PullRequestReviewPosition): { · 186 unmodified lines
187 * host sit under the line they were written on, and a new comment joins the review being187 * host sit under the line they were written on, and a new comment joins the review being
188 * drafted rather than being posted as it is typed.188 * drafted rather than being posted as it is typed.
189 */189 */
190export function PullRequestCodeTab({190function PullRequestCodeTab({
191 environmentId,191 environmentId,
192 reference,192 reference,
193 detail,193 detail,
apps/web/src/components/pullRequest/pullRequestLinkContextMenu.ts+1−1
@@ -8,7 +8,7 @@ import { toastManager } from "../ui/toast"; · 7 unmodified lines
8export type PullRequestLinkContextMenuAction = "copy-link" | "open-external";8export type PullRequestLinkContextMenuAction = "copy-link" | "open-external";
9 9
10/** Named for the host rather than "externally": the point is where you will land. */10/** Named for the host rather than "externally": the point is where you will land. */
11export const OPEN_ON_HOST_LABELS: Partial<Record<string, string>> = {11const OPEN_ON_HOST_LABELS: Partial<Record<string, string>> = {
12 github: "Open on GitHub",12 github: "Open on GitHub",
13 gitlab: "Open on GitLab",13 gitlab: "Open on GitLab",
14 bitbucket: "Open on Bitbucket",14 bitbucket: "Open on Bitbucket",
apps/web/src/components/pullRequest/pullRequestList.logic.ts+1−1
@@ -67,7 +67,7 @@ export type PullRequestViewers = PullRequestListResult["viewers"]; · 66 unmodified lines
67/** A row plus the environment that read it, where the caller has one to give. */67/** A row plus the environment that read it, where the caller has one to give. */
68type ScopedEntry = PullRequestListEntry & { readonly environmentId?: string };68type ScopedEntry = PullRequestListEntry & { readonly environmentId?: string };
69 69
70export const pullRequestViewerKey = (entry: ScopedEntry): string =>70const pullRequestViewerKey = (entry: ScopedEntry): string =>
71 `${entry.environmentId ?? ""} ${entry.host}`;71 `${entry.environmentId ?? ""} ${entry.host}`;
72 72
73const GROUP_LABELS: Record<PullRequestGroupKey, string> = {73const GROUP_LABELS: Record<PullRequestGroupKey, string> = {
apps/web/src/components/pullRequest/pullRequestListPreferences.ts+1−1
@@ -37,7 +37,7 @@ export type PullRequestListPreferencePatch = { · 36 unmodified lines
37 [Key in keyof PullRequestListPreferences]?: PullRequestListPreferences[Key] | undefined;37 [Key in keyof PullRequestListPreferences]?: PullRequestListPreferences[Key] | undefined;
38};38};
39 39
40export const DEFAULT_PULL_REQUEST_LIST_PREFERENCES = {40const DEFAULT_PULL_REQUEST_LIST_PREFERENCES = {
41 involvement: "all",41 involvement: "all",
42 state: "open",42 state: "open",
43} as const satisfies PullRequestListPreferences;43} as const satisfies PullRequestListPreferences;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t