fix(claude): redact launch arguments from protocol logs

Fixes review: https://github.com/pingdotgg/t3code/pull/2829#discussion_r3471595059

Julius Marminge committed 3 months ago

Commit 3bc39bc1 parent ef19b9d2 files · +7 −2Browse files

Unified · Split

2 files

@@ -497,6 +497,9 @@ describe("ClaudeAdapterV2 native protocol logging", () => { · 496 unmodified lines
497	497	env: {
498	498	ANTHROPIC_API_KEY: "secret",
499	499	},
	500	+ extraArgs: {
	501	+ "append-system-prompt": "secret launch prompt",
	502	+ },
500	503	canUseTool: (_toolName, input, callbackOptions) =>
501	504	Promise.resolve({
502	505	behavior: "allow",
@@ -517,7 +520,9 @@ describe("ClaudeAdapterV2 native protocol logging", () => { · 14 unmodified lines
517	520	cwd: "/workspace",
518	521	hasCanUseTool: true,
519	522	hasEnvironment: true,
	523	+ hasExtraArgs: true,
520	524	});
	525	+ assert.notInclude(JSON.stringify(loggedClaudeQueryOptions(options)), "secret launch prompt");
521	526	});
522	527	});
523	528

@@ -344,7 +344,7 @@ export interface ClaudeAgentSdkLoggedQueryOptions { · 343 unmodified lines
344	344	readonly effort?: ClaudeAgentSdkQueryOptions["effort"];
345	345	readonly includePartialMessages?: true;
346	346	readonly pathToClaudeCodeExecutable?: ClaudeAgentSdkQueryOptions["pathToClaudeCodeExecutable"];
347		− readonly extraArgs?: ClaudeAgentSdkQueryOptions["extraArgs"];
	347	+ readonly hasExtraArgs?: true;
348	348	readonly allowDangerouslySkipPermissions?: true;
349	349	readonly hasCanUseTool?: true;
350	350	readonly hasEnvironment?: true;
@@ -436,7 +436,7 @@ export function loggedClaudeQueryOptions( · 85 unmodified lines
436	436	...(options.pathToClaudeCodeExecutable === undefined
437	437	? {}
438	438	: { pathToClaudeCodeExecutable: options.pathToClaudeCodeExecutable }),
439		− ...(options.extraArgs === undefined ? {} : { extraArgs: options.extraArgs }),
	439	+ ...(options.extraArgs === undefined ? {} : { hasExtraArgs: true }),
440	440	...(options.allowDangerouslySkipPermissions === true
441	441	? { allowDangerouslySkipPermissions: true }
442	442	: {}),

Keyboard shortcuts