History

Fix sidebar terminal shortcut state subscription

Cursor Agent committed 5 months ago

Commit 41556cc1 parent a6edad11 file · +9 −14Browse files

Unified · Split

apps/web/src/components/Sidebar.tsx+9−14
@@ -2810,6 +2810,11 @@ export default function Sidebar() { · 2809 unmodified lines
28102810 select: (params) => resolveThreadRouteRef(params),
28112811 });
28122812 const routeThreadKey = routeThreadRef ? scopedThreadKey(routeThreadRef) : null;
2813+ const activeThreadTerminalOpen = useTerminalUiStateStore((state) =>
2814+ routeThreadRef
2815+ ? selectThreadTerminalUiState(state.terminalUiStateByThreadKey, routeThreadRef).terminalOpen
2816+ : false,
2817+ );
28132818 const keybindings = useServerKeybindings();
28142819 const openAddProjectCommandPalette = useCommandPaletteStore((store) => store.openAddProject);
28152820 const [expandedThreadListsByProject, setExpandedThreadListsByProject] = useState<
@@ -2926,15 +2931,10 @@ export default function Sidebar() { · 110 unmodified lines
29262931 const getCurrentSidebarShortcutContext = useCallback(
29272932 () => ({
29282933 terminalFocus: isTerminalFocused(),
2929− terminalOpen: routeThreadRef
2930− ? selectThreadTerminalUiState(
2931− useTerminalUiStateStore.getState().terminalUiStateByThreadKey,
2932− routeThreadRef,
2933− ).terminalOpen
2934− : false,
2934+ terminalOpen: activeThreadTerminalOpen,
29352935 modelPickerOpen,
29362936 }),
2937− [modelPickerOpen, routeThreadRef],
2937+ [activeThreadTerminalOpen, modelPickerOpen],
29382938 );
29392939 const newThreadShortcutLabelOptions = useMemo(
29402940 () => ({
@@ -3134,15 +3134,10 @@ export default function Sidebar() { · 193 unmodified lines
31343134 const sidebarShortcutContext = useMemo(
31353135 () => ({
31363136 terminalFocus: false,
3137− terminalOpen: routeThreadRef
3138− ? selectThreadTerminalUiState(
3139− useTerminalUiStateStore.getState().terminalUiStateByThreadKey,
3140− routeThreadRef,
3141− ).terminalOpen
3142− : false,
3137+ terminalOpen: activeThreadTerminalOpen,
31433138 modelPickerOpen,
31443139 }),
3145− [modelPickerOpen, routeThreadRef],
3140+ [activeThreadTerminalOpen, modelPickerOpen],
31463141 );
31473142 const threadJumpLabelByKey = useMemo(
31483143 () =>