History

Avoid popup-open false errors on mobile browsers

- Stop throwing when `window.open` returns `null` in `wsNativeApi` - Keep opening external links in a new tab and rely on browser popup policy

Julius Marminge committed 8 months ago

Commit 4e54afb1 parent 82dd65f1 file · +3 −4Browse files

Unified · Split

apps/web/src/wsNativeApi.ts+3−4
@@ -153,10 +153,9 @@ export function createWsNativeApi(): NativeApi { · 152 unmodified lines
153 return;153 return;
154 }154 }
155 155
156 const popup = window.open(url, "_blank", "noopener,noreferrer");156 // Some mobile browsers can return null here even when the tab opens.
157 if (!popup) {157 // Avoid false negatives and let the browser handle popup policy.
158 throw new Error("Unable to open link. Allow popups and try again.");158 window.open(url, "_blank", "noopener,noreferrer");
159 }
160 },159 },
161 },160 },
162 git: {161 git: {