test(web): keep pull request menu items private (#10016)

Julius Marminge committed 2 months ago

Commit 4e59b061 parent 1449dec2 files · +2 −9Browse files

Unified · Split

2 files

 import { describe, expect, it } from "vite-plus/test";
-import { openOnHostLabel, pullRequestLinkContextMenuItems } from "./pullRequestLinkContextMenu";
+import { openOnHostLabel } from "./pullRequestLinkContextMenu";
 describe("pull request link context menu", () => {
-  it("offers the copy first and the host's own page after it", () => {
-    expect(pullRequestLinkContextMenuItems("Open on GitHub")).toEqual([
-      { id: "copy-link", label: "Copy link", icon: "copy" },
-      { id: "open-external", label: "Open on GitHub" },
-    ]);
-  });
   it("names every host it knows, and says nothing false about one it does not", () => {
     expect(openOnHostLabel("github")).toBe("Open on GitHub");
     expect(openOnHostLabel("gitlab")).toBe("Open on GitLab");

@@ -19,7 +19,7 @@ export const openOnHostLabel = (provider: string): string => · 18 unmodified lines
19	OPEN_ON_HOST_LABELS[provider] ?? "Open on host";	19	OPEN_ON_HOST_LABELS[provider] ?? "Open on host";
20		20
21	/** Copy first: it is the reason to right-click a number rather than click it. */	21	/** Copy first: it is the reason to right-click a number rather than click it. */
22	export function pullRequestLinkContextMenuItems(	22	function pullRequestLinkContextMenuItems(
23	openLabel: string,	23	openLabel: string,
24	): readonly ContextMenuItem<PullRequestLinkContextMenuAction>[] {	24	): readonly ContextMenuItem<PullRequestLinkContextMenuAction>[] {
25	return [	25	return [