fix: avoid duplicating streamed assistant completion text (#465)

James committed 8 months ago

Commit 57aa6bf1 parent 40a7f4b2 files · +6 −1Browse files

Unified · Split

2 files

@@ -834,6 +834,7 @@ describe("ProviderRuntimeIngestion", () => { · 833 unmodified lines
834	payload: {	834	payload: {
835	itemType: "assistant_message",	835	itemType: "assistant_message",
836	status: "completed",	836	status: "completed",
		837	detail: "hello live",
837	},	838	},
838	});	839	});
839		840

       if (assistantCompletion) {
         const assistantMessageId = assistantCompletion.messageId;
         const turnId = toTurnId(event.turnId);
+        const existingAssistantMessage = thread.messages.find((entry) => entry.id === assistantMessageId);
+        const shouldApplyFallbackCompletionText =
+          !existingAssistantMessage ||
+          existingAssistantMessage.text.length === 0;
         if (turnId) {
           yield* rememberAssistantMessageId(thread.id, turnId, assistantMessageId);
         }
           createdAt: now,
           commandTag: "assistant-complete",
           finalDeltaCommandTag: "assistant-delta-finalize",
-          ...(assistantCompletion.fallbackText !== undefined
+          ...(assistantCompletion.fallbackText !== undefined && shouldApplyFallbackCompletionText
             ? { fallbackText: assistantCompletion.fallbackText }
             : {}),
         });