History

fix(web): handle unlinked PRs when copying panel links

shivam committed 2 months ago

Commit 70981751 parent d4dd1901 file · +16 −9Browse files

Unified · Split

apps/web/src/hooks/useOpenPanelPullRequestUrl.ts+16−9
@@ -8,7 +8,7 @@ import { · 7 unmodified lines
88 } from "../components/pullRequest/pullRequestDetail.logic";
99 import { gitHubPullRequestBrowserUrl } from "../lib/openPullRequestLink";
1010 import { selectActiveRightPanelSurface, useRightPanelStore } from "../rightPanelStore";
11−import { useProject } from "../state/entities";
11+import { useProject, useServerConfigs } from "../state/entities";
1212 import { pullRequestEnvironment } from "../state/pullRequests";
1313 import { useEnvironmentQuery } from "../state/query";
1414
@@ -20,17 +20,22 @@ export function useOpenPanelPullRequestUrl(threadRef: ScopedThreadRef | null) { · 5 unmodified lines
2020 const environmentId = reference?.environmentId
2121 ? EnvironmentId.make(reference.environmentId)
2222 : threadRef?.environmentId;
23+ const serverConfigs = useServerConfigs();
2324 const project = useProject(
24− reference && environmentId
25+ reference && reference.projectId !== null && environmentId
2526 ? scopeProjectRef(environmentId, ProjectId.make(reference.projectId))
2627 : null,
2728 );
2829 const detail = useEnvironmentQuery(
29− reference && environmentId
30+ reference &&
31+ environmentId &&
32+ (reference.projectId !== null ||
33+ serverConfigs.get(environmentId)?.environment.capabilities.unlinkedGitHubPullRequests ===
34+ true)
3035 ? pullRequestEnvironment.detail({
3136 environmentId,
3237 input: {
33− projectId: ProjectId.make(reference.projectId),
38+ projectId: reference.projectId === null ? null : ProjectId.make(reference.projectId),
3439 repository: reference.repository,
3540 number: reference.number,
3641 },
@@ -51,10 +56,12 @@ export function useOpenPanelPullRequestUrl(threadRef: ScopedThreadRef | null) { · 14 unmodified lines
5156 return reference
5257 ? (resolveDisplayedPullRequestDetail({ live: detail, cached: cachedDetail, reference })?.url ??
5358 reference.url ??
54− gitHubPullRequestBrowserUrl(
55− project?.repositoryIdentity,
56− reference.repository,
57− reference.number,
58− ))
59+ (reference.projectId === null
60+ ? `https://github.com/${reference.repository}/pull/${reference.number}`
61+ : gitHubPullRequestBrowserUrl(
62+ project?.repositoryIdentity,
63+ reference.repository,
64+ reference.number,
65+ )))
5966 : undefined;
6067 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t