Fix redundant extractModelSelectionOptions call and prevent silent model options injection on session restart

- ChatView: Store extractModelSelectionOptions result in a local variable instead of calling it twice with identical arguments in selectedModelSelection useMemo - ProviderCommandReactor: Only derive model options from requestedModelSelection (explicit user request), not from thread.modelSelection fallback, to prevent silent injection of persisted options during runtime-mode-triggered session restarts

Cursor Agent committed 7 months ago

Commit 73c8d111 parent 07e86e92 files · +10 −14Browse files

Unified · Split

2 files

apps/server/src/orchestration/Layers/ProviderCommandReactor.ts +4 −1
apps/web/src/components/ChatView.tsx +6 −13

apps/server/src/orchestration/Layers/ProviderCommandReactor.ts+4−1

     const desiredModelSelection = requestedModelSelection ?? thread.modelSelection;
     const desiredModel = desiredModelSelection.model;
     const desiredModelOptions =
-      options?.modelOptions ?? toProviderModelOptions(desiredModelSelection);
+      options?.modelOptions ??
+      (requestedModelSelection !== undefined
+        ? toProviderModelOptions(requestedModelSelection)
+        : undefined);
     const effectiveCwd = resolveThreadWorkspaceCwd({
       thread,
       projects: readModel.projects,

apps/web/src/components/ChatView.tsx+6−13

   );
   const selectedPromptEffort = composerProviderState.promptEffort;
   const selectedModelOptionsForDispatch = composerProviderState.modelOptionsForDispatch;
-  const selectedModelSelection = useMemo<ModelSelection>(
+  const selectedModelSelection = useMemo<ModelSelection>(() => {
-    () => ({
+    const options = extractModelSelectionOptions(selectedProvider, selectedModelOptionsForDispatch);
+    return {
       provider: selectedProvider,
       model: selectedModel,
-      ...(extractModelSelectionOptions(selectedProvider, selectedModelOptionsForDispatch)
+      ...(options ? { options } : {}),
-        ? {
+    };
-            options: extractModelSelectionOptions(
+  }, [selectedModel, selectedModelOptionsForDispatch, selectedProvider]);
-              selectedProvider,
-              selectedModelOptionsForDispatch,
-            ),
-          }
-        : {}),
-    }),
-    [selectedModel, selectedModelOptionsForDispatch, selectedProvider],
-  );
   const providerOptionsForDispatch = useMemo(() => getProviderStartOptions(settings), [settings]);
   const selectedModelForPicker = selectedModel;
   const modelOptionsByProvider = useMemo(