| @@ -34,6 +34,12 @@ function isCiEnvironment(value: string | undefined): boolean { · 33 unmodified lines |
| 34 | return parseBooleanLike(value) === true; | 34 | return parseBooleanLike(value) === true; |
| 35 | } | 35 | } |
| 36 | | 36 | |
| | 37 | function resolveBooleanToggle(rawValue: string | undefined, ciValue: string | undefined): boolean { |
| | 38 | const toggleOverride = parseBooleanLike(rawValue); |
| | 39 | if (toggleOverride !== null) return toggleOverride; |
| | 40 | return !isCiEnvironment(ciValue); |
| | 41 | } |
| | 42 | |
| 37 | /** | 43 | /** |
| 38 | * Controls whether desktop perf automation should include terminal shortcuts. | 44 | * Controls whether desktop perf automation should include terminal shortcuts. |
| 39 | * | 45 | * |
| @@ -46,21 +52,15 @@ function isCiEnvironment(value: string | undefined): boolean { · 6 unmodified lines |
| 46 | * flaky PTY-dependent interactions in ephemeral Linux runners. | 52 | * flaky PTY-dependent interactions in ephemeral Linux runners. |
| 47 | */ | 53 | */ |
| 48 | export function shouldRunTerminalPerfInteractions(env: PerfToggleEnv): boolean { | 54 | export function shouldRunTerminalPerfInteractions(env: PerfToggleEnv): boolean { |
| 49 | const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_TERMINAL); | 55 | return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_TERMINAL, env.CI); |
| 50 | if (toggleOverride !== null) return toggleOverride; | | |
| 51 | return !isCiEnvironment(env.CI); | | |
| 52 | } | 56 | } |
| 53 | | 57 | |
| 54 | export function shouldRunOptionalRendererPerfInteractions(env: OptionalRendererToggleEnv): boolean { | 58 | export function shouldRunOptionalRendererPerfInteractions(env: OptionalRendererToggleEnv): boolean { |
| 55 | const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER); | 59 | return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_OPTIONAL_RENDERER, env.CI); |
| 56 | if (toggleOverride !== null) return toggleOverride; | | |
| 57 | return !isCiEnvironment(env.CI); | | |
| 58 | } | 60 | } |
| 59 | | 61 | |
| 60 | export function shouldRunBenchmarkThreadSweep(env: BenchmarkSweepToggleEnv): boolean { | 62 | export function shouldRunBenchmarkThreadSweep(env: BenchmarkSweepToggleEnv): boolean { |
| 61 | const toggleOverride = parseBooleanLike(env.T3CODE_DESKTOP_PERF_RUN_BENCHMARK_SWEEP); | 63 | return resolveBooleanToggle(env.T3CODE_DESKTOP_PERF_RUN_BENCHMARK_SWEEP, env.CI); |
| 62 | if (toggleOverride !== null) return toggleOverride; | | |
| 63 | return !isCiEnvironment(env.CI); | | |
| 64 | } | 64 | } |
| 65 | | 65 | |
| 66 | export function resolveBenchmarkFollowUpPassCount(env: PerfBenchmarkEnv): number { | 66 | export function resolveBenchmarkFollowUpPassCount(env: PerfBenchmarkEnv): number { |