refactor(server): use Effect filesystem for workspace reads

Cursor Agent committed 3 months ago

Commit 7c8c0b61 parent ecb35f72 files · +108 −91Browse files

Showing the changes to apps/server/src/workspace/WorkspaceFileSystem.test.ts (1 of 2 files). Show all

Unified · Split

apps/server/src/workspace/WorkspaceFileSystem.test.ts+34−6

 import * as NodeServices from "@effect/platform-node/NodeServices";
-import { it, describe, expect } from "@effect/vitest";
+import { assert, it, describe, expect } from "@effect/vitest";
 import * as Effect from "effect/Effect";
 import * as FileSystem from "effect/FileSystem";
 import * as Layer from "effect/Layer";
 import * as Path from "effect/Path";
+import * as PlatformError from "effect/PlatformError";
 import * as ServerConfig from "../config.ts";
 import * as VcsDriverRegistry from "../vcs/VcsDriverRegistry.ts";
       }),
     );
+    it.effect("limits previews while preserving the full file byte length", () =>
+      Effect.gen(function* () {
+        const workspaceFileSystem = yield* WorkspaceFileSystem.WorkspaceFileSystem;
+        const cwd = yield* makeTempDir;
+        const contents = "a".repeat(1024 * 1024 + 1);
+        yield* writeTextFile(cwd, "large.txt", contents);
+        const result = yield* workspaceFileSystem.readFile({
+          cwd,
+          relativePath: "large.txt",
+        });
+        assert.strictEqual(result.contents.length, 1024 * 1024);
+        assert.strictEqual(result.byteLength, contents.length);
+        assert.strictEqual(result.truncated, true);
+      }),
+    );
     it.effect("rejects reads outside the workspace root", () =>
       Effect.gen(function* () {
         const workspaceFileSystem = yield* WorkspaceFileSystem.WorkspaceFileSystem;
           .readFile({ cwd, relativePath: "missing.txt" })
           .pipe(Effect.flip);
-        expect(error).toBeInstanceOf(WorkspaceFileSystem.WorkspaceFileSystemOperationError);
+        assert.instanceOf(error, WorkspaceFileSystem.WorkspaceFileSystemOperationError);
-        expect(error).toMatchObject({
+        assert.deepEqual(
+          {
+            workspaceRoot: error.workspaceRoot,
+            relativePath: error.relativePath,
+            resolvedPath: error.resolvedPath,
+            operationPath: error.operationPath,
+            operation: error.operation,
+          },
+          {
           workspaceRoot: cwd,
           relativePath: "missing.txt",
           resolvedPath,
           operationPath: resolvedPath,
           operation: "realpath-target",
-        });
+          },
-        expect(error.cause).toBeInstanceOf(Error);
+        );
-        expect((error.cause as NodeJS.ErrnoException).code).toBe("ENOENT");
+        assert.instanceOf(error.cause, PlatformError.PlatformError);
+        assert.strictEqual(error.cause.reason._tag, "NotFound");
       }),
     );
   });