Tighten test fixtures for terminal options and event typing

- Pass subprocess test options only when defined in `terminalManager` tests - Narrow web store terminal event fixtures to `started`/`activity` event shapes

Julius Marminge committed 9 months ago

Commit 804572c1 parent ddc4a932 files · +13 −4Browse files

Showing the changes to apps (2 of 2 files). Show all

Unified · Split

2 files

apps/server/src/terminalManager.test.ts +4 −2
apps/web/src/store.test.ts +9 −2

apps/server/src/terminalManager.test.ts+4−2

       ptyAdapter,
       historyLineLimit,
       shellResolver: options.shellResolver ?? (() => "/bin/bash"),
-      subprocessChecker: options.subprocessChecker,
+      ...(options.subprocessChecker ? { subprocessChecker: options.subprocessChecker } : {}),
-      subprocessPollIntervalMs: options.subprocessPollIntervalMs,
+      ...(options.subprocessPollIntervalMs
+        ? { subprocessPollIntervalMs: options.subprocessPollIntervalMs }
+        : {}),
     });
     return { logsDir, ptyAdapter, manager };
   }

apps/web/src/store.test.ts+9−2

 import { DEFAULT_THREAD_TERMINAL_HEIGHT, DEFAULT_THREAD_TERMINAL_ID } from "./types";
 import type { Thread } from "./types";
+type TerminalStartedEvent = Extract<TerminalEvent, { type: "started" }>;
+type TerminalActivityEvent = Extract<TerminalEvent, { type: "activity" }>;
 function makeSession(overrides: Partial<ProviderSession> = {}): ProviderSession {
   return {
     sessionId: "sess-1",
   };
 }
-function makeTerminalStartedEvent(overrides: Partial<TerminalEvent> = {}): TerminalEvent {
+function makeTerminalStartedEvent(
+  overrides: Partial<TerminalStartedEvent> = {},
+): TerminalStartedEvent {
   return {
     type: "started",
     threadId: "thread-local-1",
   };
 }
-function makeTerminalActivityEvent(overrides: Partial<TerminalEvent> = {}): TerminalEvent {
+function makeTerminalActivityEvent(
+  overrides: Partial<TerminalActivityEvent> = {},
+): TerminalActivityEvent {
   return {
     type: "activity",
     threadId: "thread-local-1",