History

refactor(shared): keep search ranking comparator private (#10031)

Julius Marminge committed 2 months ago

Commit 86f07991 parent f5d9d122 files · +1 −3Browse files

Unified · Split

2 files
  1. packages/shared/src/searchRanking.test.ts +0 −2
  2. packages/shared/src/searchRanking.ts +1 −1
packages/shared/src/searchRanking.test.ts+0−2
@@ -1,7 +1,6 @@
1import { describe, expect, it } from "vite-plus/test";1import { describe, expect, it } from "vite-plus/test";
2 2
3import {3import {
4 compareRankedSearchResults,
5 insertRankedSearchResult,4 insertRankedSearchResult,
6 normalizeSearchQuery,5 normalizeSearchQuery,
7 scoreQueryMatch,6 scoreQueryMatch,
@@ -90,6 +89,5 @@ describe("insertRankedSearchResult", () => { · 82 unmodified lines
90 insertRankedSearchResult(ranked, { item: "c", score: 30, tieBreaker: "c" }, 2);89 insertRankedSearchResult(ranked, { item: "c", score: 30, tieBreaker: "c" }, 2);
91 90
92 expect(ranked.map((entry) => entry.item)).toEqual(["a", "b"]);91 expect(ranked.map((entry) => entry.item)).toEqual(["a", "b"]);
93 expect(compareRankedSearchResults(ranked[0]!, ranked[1]!)).toBeLessThan(0);
94 });92 });
95});93});
packages/shared/src/searchRanking.ts+1−1
@@ -135,7 +135,7 @@ export function scoreQueryMatch(input: { · 134 unmodified lines
135 return null;135 return null;
136}136}
137 137
138export function compareRankedSearchResults<T>(138function compareRankedSearchResults<T>(
139 left: RankedSearchResult<T>,139 left: RankedSearchResult<T>,
140 right: RankedSearchResult<T>,140 right: RankedSearchResult<T>,
141): number {141): number {