History

Refactor collection handling for mobile remote connect

- Replace chained array transforms with explicit loops across mobile and server paths - Tighten provider, git, and orchestration parsing while preserving behavior - Improve remote-connect UI data shaping and thread activity filtering

Julius Marminge committed 6 months ago

Commit 90fea7b1 parent 7793bd654 files · +768 −546Browse files

Showing the changes to apps/server/src/sourceControl/SourceControlProviderDiscovery.ts (1 of 54 files). Show all

Unified · Split

apps/server/src/sourceControl/SourceControlProviderDiscovery.ts+15−6
@@ -96,15 +96,24 @@ export function unknownAuth(detail?: string): SourceControlProviderAuth { · 95 unmodified lines
9696 }
9797
9898 export function combinedAuthOutput(input: SourceControlAuthProbeInput): string {
99− return [input.stdout, input.stderr].filter((entry) => entry.trim().length > 0).join("\n");
99+ const parts: string[] = [];
100+ for (const entry of [input.stdout, input.stderr]) {
101+ if (entry.trim().length > 0) {
102+ parts.push(entry);
103+ }
104+ }
105+ return parts.join("\n");
100106 }
101107
102108 function sanitizedAuthLines(text: string): ReadonlyArray<string> {
103− return text
104− .split(/\r?\n/)
105− .map((entry) => entry.trim())
106− .filter((entry) => entry.length > 0)
107− .filter((entry) => !/^[-\s]*token(?:\s+scopes?)?:/iu.test(entry));
109+ const lines: string[] = [];
110+ for (const entry of text.split(/\r?\n/)) {
111+ const line = entry.trim();
112+ if (line.length === 0) continue;
113+ if (/^[-\s]*token(?:\s+scopes?)?:/iu.test(line)) continue;
114+ lines.push(line);
115+ }
116+ return lines;
108117 }
109118
110119 export function firstSafeAuthLine(text: string): string | undefined {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t