Fix snapshot sync bypassing recovery coordinator and dead loading state

- Remove refreshActiveSnapshot from unarchiveThread: the EventRouter's recovery coordinator already handles thread.unarchived events via fallbackToSnapshotRecovery, which properly updates latestSequence. Calling syncServerReadModel directly left the coordinator stale, causing already-applied events to be re-processed and potentially corrupting streaming message content via double concatenation. - Fix archived threads loading state: placeholderData always returned EMPTY_ARCHIVED_THREADS on first load, making isPending permanently false and the loading UI unreachable. Now only uses previous query data as placeholder, allowing isPending to be true on first fetch.

Cursor Agent committed 7 months ago

Commit 95dd2b61 parent bbe5e142 files · +2 −13Browse files

Unified · Split

2 files

apps/web/src/hooks/useThreadActions.ts +1 −10
apps/web/src/lib/orchestrationReactQuery.ts +1 −3

apps/web/src/hooks/useThreadActions.ts+1−10

 export function useThreadActions() {
   const appSettings = useSettings();
-  const syncServerReadModel = useStore((store) => store.syncServerReadModel);
   const clearComposerDraftForThread = useComposerDraftStore((store) => store.clearDraftThread);
   const clearProjectDraftThreadById = useComposerDraftStore(
     (store) => store.clearProjectDraftThreadById,
   const queryClient = useQueryClient();
   const removeWorktreeMutation = useMutation(gitRemoveWorktreeMutationOptions({ queryClient }));
-  const refreshActiveSnapshot = useCallback(async () => {
-    const api = readNativeApi();
-    if (!api) return;
-    const snapshot = await api.orchestration.getActiveSnapshot();
-    syncServerReadModel(snapshot);
-  }, [syncServerReadModel]);
   const archiveThread = useCallback(
     async (threadId: ThreadId) => {
       const api = readNativeApi();
         commandId: newCommandId(),
         threadId,
       });
-      await refreshActiveSnapshot();
       void queryClient.invalidateQueries({ queryKey: orchestrationQueryKeys.archivedThreads() });
     },
-    [queryClient, refreshActiveSnapshot],
+    [queryClient],
   );
   const deleteThread = useCallback(

apps/web/src/lib/orchestrationReactQuery.ts+1−3

-import type { OrchestrationListArchivedThreadsResult } from "@t3tools/contracts";
 import { queryOptions } from "@tanstack/react-query";
 import { ensureNativeApi } from "~/nativeApi";
 };
 const DEFAULT_ARCHIVED_THREADS_STALE_TIME = 15_000;
-const EMPTY_ARCHIVED_THREADS: OrchestrationListArchivedThreadsResult = [];
 export function archivedThreadsQueryOptions() {
   return queryOptions({
       return api.orchestration.listArchivedThreads();
     },
     staleTime: DEFAULT_ARCHIVED_THREADS_STALE_TIME,
-    placeholderData: (previous) => previous ?? EMPTY_ARCHIVED_THREADS,
+    placeholderData: (previous) => previous,
   });
 }