History

Remove mobile Cmd/Ctrl+B sidebar toggle shortcut

- Remove global keydown listener from `SidebarProvider` - Keep sidebar toggling to explicit UI interactions only

Julius Marminge committed 8 months ago

Commit 9a2fc6f1 parent d1e95801 file · +0 −15Browse files

Unified · Split

apps/web/src/components/ui/sidebar.tsx+0−15
@@ -24,7 +24,6 @@ const SIDEBAR_COOKIE_MAX_AGE = 60 * 60 * 24 * 7; · 23 unmodified lines
2424 const SIDEBAR_WIDTH = "16rem";
2525 const SIDEBAR_WIDTH_MOBILE = "calc(100vw - var(--spacing(3)))";
2626 const SIDEBAR_WIDTH_ICON = "3rem";
27−const SIDEBAR_KEYBOARD_SHORTCUT = "b";
2827 const SIDEBAR_RESIZE_DEFAULT_MIN_WIDTH = 16 * 16;
2928
3029 type SidebarContextProps = {
@@ -129,20 +128,6 @@ function SidebarProvider({ · 98 unmodified lines
129128 return isMobile ? setOpenMobile((open) => !open) : setOpen((open) => !open);
130129 }, [isMobile, setOpen]);
131130
132− // Adds a keyboard shortcut to toggle the sidebar.
133− React.useEffect(() => {
134− const handleKeyDown = (event: KeyboardEvent) => {
135− if (!isMobile) return;
136− if (event.key === SIDEBAR_KEYBOARD_SHORTCUT && (event.metaKey || event.ctrlKey)) {
137− event.preventDefault();
138− toggleSidebar();
139− }
140− };
141−
142− window.addEventListener("keydown", handleKeyDown);
143− return () => window.removeEventListener("keydown", handleKeyDown);
144− }, [isMobile, toggleSidebar]);
145−
146131 // We add a state so that we can do data-state="expanded" or "collapsed".
147132 // This makes it easier to style the sidebar with Tailwind classes.
148133 const state = open ? "expanded" : "collapsed";