History

Refactor recoverable Effect fallbacks to orElseSucceed (#2968)

Julius Marminge committed 5 months agov0.0.25-nightly.20260605.473

Commit 9da430c1 parent a084fbb42 files · +182 −318Browse files

Showing the changes to apps/server/src/sourceControl/SourceControlRepositoryService.ts (1 of 42 files). Show all

Unified · Split

apps/server/src/sourceControl/SourceControlRepositoryService.ts+2−4
@@ -277,12 +277,10 @@ export const make = Effect.fn("makeSourceControlRepositoryService")(function* () · 276 unmodified lines
277277 })
278278 .pipe(
279279 Effect.map(() => true),
280− Effect.catch(() => Effect.succeed(false)),
280+ Effect.orElseSucceed(() => false),
281281 );
282282 if (!hasCommits) {
283− const details = yield* git
284− .statusDetails(input.cwd)
285− .pipe(Effect.catch(() => Effect.succeed(null)));
283+ const details = yield* git.statusDetails(input.cwd).pipe(Effect.orElseSucceed(() => null));
286284 return {
287285 repository: toRepositoryInfo(providerKind, urls),
288286 remoteName,