History

[codex] Structure Bitbucket API errors (#3457)

Julius Marminge committed 4 months ago

Commit a3dadc01 parent 1a592773 files · +239 −49Browse files

Showing the changes to apps/server/src/sourceControl/BitbucketSourceControlProvider.test.ts (1 of 3 files). Show all

Unified · Split

apps/server/src/sourceControl/BitbucketSourceControlProvider.test.ts+4−5
@@ -53,11 +53,10 @@ it.effect("maps Bitbucket PR summaries into provider-neutral change requests", ( · 52 unmodified lines
5353
5454 it.effect("adds repository context while retaining Bitbucket API causes", () =>
5555 Effect.gen(function* () {
56− const cause = new BitbucketApi.BitbucketApiError({
56+ const upstreamCause = new Error("raw upstream failure");
57+ const cause = new BitbucketApi.BitbucketRequestError({
5758 operation: "getRepository",
58− detail: "upstream detail that should remain in the cause",
59− status: 503,
60− cause: new Error("raw upstream failure"),
59+ cause: upstreamCause,
6160 });
6261 const provider = yield* makeProvider({
6362 getRepositoryCloneUrls: () => Effect.fail(cause),
@@ -86,7 +85,7 @@ it.effect("adds repository context while retaining Bitbucket API causes", () => · 22 unmodified lines
8685 },
8786 );
8887 assert.strictEqual(error.cause, cause);
89− assert.equal(error.message.includes(cause.detail), false);
88+ assert.equal(error.message.includes(upstreamCause.message), false);
9089 }),
9190 );
9291