History

Use mock layers for Git VCS driver tests

- Replace ad hoc `succeed` casts with `Layer.mock` in integration and reactor tests - Keep Git VCS driver fixtures type-safe while preserving existing test behavior

Julius Marminge committed 6 months ago

Commit b449d781 parent 6406e212 files · +4 −4Browse files

Unified · Split

2 files
  1. apps/server/integration/OrchestrationEngineHarness.integration.ts +2 −2
  2. apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts +2 −2
apps/server/integration/OrchestrationEngineHarness.integration.ts+2−2
@@ -308,10 +308,10 @@ export const makeOrchestrationIntegrationHarness = ( · 307 unmodified lines
308 Layer.provideMerge(runtimeServicesLayer),308 Layer.provideMerge(runtimeServicesLayer),
309 Layer.provideMerge(serverSettingsLayer),309 Layer.provideMerge(serverSettingsLayer),
310 );310 );
311 const gitVcsDriverLayer = Layer.succeed(GitVcsDriver.GitVcsDriver, {311 const gitVcsDriverLayer = Layer.mock(GitVcsDriver.GitVcsDriver)({
312 renameBranch: (input: Parameters<GitVcsDriver.GitVcsDriverShape["renameBranch"]>[0]) =>312 renameBranch: (input: Parameters<GitVcsDriver.GitVcsDriverShape["renameBranch"]>[0]) =>
313 Effect.succeed({ branch: input.newBranch }),313 Effect.succeed({ branch: input.newBranch }),
314 } as unknown as GitVcsDriver.GitVcsDriverShape);314 });
315 const textGenerationLayer = Layer.succeed(TextGeneration, {315 const textGenerationLayer = Layer.succeed(TextGeneration, {
316 generateBranchName: () => Effect.succeed({ branch: "update" }),316 generateBranchName: () => Effect.succeed({ branch: "update" }),
317 generateThreadTitle: () => Effect.succeed({ title: "New thread" }),317 generateThreadTitle: () => Effect.succeed({ title: "New thread" }),
apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts+2−2
@@ -325,9 +325,9 @@ describe("ProviderCommandReactor", () => { · 324 unmodified lines
325 Layer.provideMerge(orchestrationLayer),325 Layer.provideMerge(orchestrationLayer),
326 Layer.provideMerge(Layer.succeed(ProviderService, service)),326 Layer.provideMerge(Layer.succeed(ProviderService, service)),
327 Layer.provideMerge(327 Layer.provideMerge(
328 Layer.succeed(GitVcsDriver.GitVcsDriver, {328 Layer.mock(GitVcsDriver.GitVcsDriver)({
329 renameBranch,329 renameBranch,
330 } as unknown as GitVcsDriver.GitVcsDriverShape),330 }),
331 ),331 ),
332 Layer.provideMerge(332 Layer.provideMerge(
333 Layer.succeed(GitStatusBroadcaster, {333 Layer.succeed(GitStatusBroadcaster, {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t