History

test: stop path and platform tests depending on the host OS (#9564)

Julius Marminge committed 2 months ago

Commit cc607531 parent bfef97310 files · +65 −33Browse files

Showing the changes to scripts (2 of 10 files). Show all

Unified · Split

2 files
  1. scripts/mobile-showcase.test.ts +14 −6
  2. scripts/mobile-showcase.ts +2 −1
scripts/mobile-showcase.test.ts+14−6
@@ -1,3 +1,5 @@
1+// @effect-diagnostics nodeBuiltinImport:off - expectations mirror the host path joins the script under test performs.
2+import * as NodePath from "node:path";
13 import { assert, it } from "@effect/vitest";
24 import { PNG } from "pngjs";
35
@@ -167,8 +169,14 @@ it("expands both appearances into independent upload-ready directories", () => { · 163 unmodified lines
167169 directory: showcaseCaptureDirectory("/captures", capture),
168170 })),
169171 [
170− { appearance: "light", directory: "/captures/apple/iphone-test/light/t3-code" },
171− { appearance: "dark", directory: "/captures/apple/iphone-test/dark/t3-code" },
172+ {
173+ appearance: "light",
174+ directory: NodePath.join("/captures", "apple", "iphone-test", "light", "t3-code"),
175+ },
176+ {
177+ appearance: "dark",
178+ directory: NodePath.join("/captures", "apple", "iphone-test", "dark", "t3-code"),
179+ },
172180 ],
173181 );
174182 });
@@ -192,10 +200,10 @@ it("expands themes into independent upload-ready directories per appearance", () · 17 unmodified lines
192200 showcaseCaptureDirectory("/captures", capture),
193201 ),
194202 [
195− "/captures/apple/iphone-test/light/ocean",
196− "/captures/apple/iphone-test/light/ember",
197− "/captures/apple/iphone-test/dark/ocean",
198− "/captures/apple/iphone-test/dark/ember",
203+ NodePath.join("/captures", "apple", "iphone-test", "light", "ocean"),
204+ NodePath.join("/captures", "apple", "iphone-test", "light", "ember"),
205+ NodePath.join("/captures", "apple", "iphone-test", "dark", "ocean"),
206+ NodePath.join("/captures", "apple", "iphone-test", "dark", "ember"),
199207 ],
200208 );
201209 });
scripts/mobile-showcase.ts+2−1
@@ -53,7 +53,8 @@ export function resolveAndroidSdkRoot( · 52 unmodified lines
5353 const configured = environment.ANDROID_HOME ?? environment.ANDROID_SDK_ROOT;
5454 if (configured) return configured;
5555 const home = environment.HOME ?? environment.USERPROFILE ?? "";
56− return NodePath.join(home, platform === "darwin" ? "Library/Android/sdk" : "Android/Sdk");
56+ const path = platform === "win32" ? NodePath.win32 : NodePath.posix;
57+ return path.join(home, platform === "darwin" ? "Library/Android/sdk" : "Android/Sdk");
5758 }
5859
5960 const ANDROID_SDK_ROOT = resolveAndroidSdkRoot(NodeProcess.env);