Inline Electron project picker check in Sidebar

- Replace `shouldOpenProjectFolderPickerImmediately` with direct `isElectron` usage - Remove obsolete `Sidebar.logic.ts` and its tests

Julius Marminge committed 8 months ago

Commit ce7b24b1 parent 5c286ca3 files · +1 −33Browse files

Unified · Split

3 files

@@ -1,24 +0,0 @@
1	import { describe, expect, it } from "vitest";
2	import { shouldOpenProjectFolderPickerImmediately } from "./Sidebar.logic";
3
4	describe("shouldOpenProjectFolderPickerImmediately", () => {
5	it("opens the folder picker immediately in Electron", () => {
6	expect(
7	shouldOpenProjectFolderPickerImmediately({
8	isElectron: true,
9	}),
10	).toBe(true);
11	});
12
13	it("still opens the folder picker immediately for mobile-width Electron layouts", () => {
14	expect(
15	shouldOpenProjectFolderPickerImmediately({
16	isElectron: true,
17	}),
18	).toBe(true);
19	});
20
21	it("keeps manual project entry outside Electron", () => {
22	expect(shouldOpenProjectFolderPickerImmediately({ isElectron: false })).toBe(false);
23	});
24	});

@@ -1,5 +0,0 @@
1	export function shouldOpenProjectFolderPickerImmediately(input: {
2	isElectron: boolean;
3	}): boolean {
4	return input.isElectron;
5	}

 } from "./desktopUpdate.logic";
 import { Alert, AlertAction, AlertDescription, AlertTitle } from "./ui/alert";
 import { Button } from "./ui/button";
-import { shouldOpenProjectFolderPickerImmediately } from "./Sidebar.logic";
 import { Collapsible, CollapsibleContent, CollapsibleTrigger } from "./ui/collapsible";
 import { Tooltip, TooltipPopup, TooltipTrigger } from "./ui/tooltip";
 import {
   const renamingCommittedRef = useRef(false);
   const renamingInputRef = useRef<HTMLInputElement | null>(null);
   const [desktopUpdateState, setDesktopUpdateState] = useState<DesktopUpdateState | null>(null);
-  const shouldBrowseForProjectImmediately = shouldOpenProjectFolderPickerImmediately({
+  const shouldBrowseForProjectImmediately = isElectron;
-    isElectron,
-  });
   const shouldShowProjectPathEntry = addingProject && !shouldBrowseForProjectImmediately;
   const pendingApprovalByThreadId = useMemo(() => {
     const map = new Map<ThreadId, boolean>();