History

fix(mobile): skip unsupported shared settings targets (#9381)

Simone committed 2 months ago

Commit cfddb421 parent 57626eb6 files · +119 −69Browse files

Showing the changes to docs (2 of 6 files). Show all

Unified · Split

2 files
  1. docs/internals/overview.md +4 −3
  2. docs/user/thread-sidebar.md +7 −5
docs/internals/overview.md+4−3
@@ -90,9 +90,10 @@ A turn is complete when its session leaves `running` status, projected by · 89 unmodified lines
9090 does not define turn end.
9191
9292 Thread settlement is server-owned. Each server's own settings control PR and inactivity
93−settlement. Those keys are user preferences, so clients write them to every connected environment
94−(`SHARED_SERVER_SETTING_KEYS` in `packages/client-runtime/src/state/sharedSettings.ts`) and warn
95−when a connected environment drifts.
93+settlement. Those keys are user preferences, so clients write them to every shared-settings sync
94+target (`SHARED_SERVER_SETTING_KEYS` in `packages/client-runtime/src/state/sharedSettings.ts`) and
95+warn when another target drifts. A target must have an active connection and advertise the
96+`threadAutoSettlement` capability, which signals that the server can hold every shared key.
9697 [`ThreadSettlementReactor`][settlement] checks threads at startup, when those settings change, and
9798 once per minute, including when no client is connected. It dispatches the guarded internal
9899 `thread.auto-settle` command, which uses the existing settlement event lifecycle. Automatic
docs/user/thread-sidebar.md+7−5
@@ -22,11 +22,13 @@ available, the inactivity rule still applies. A manual un-settle also keeps the · 21 unmodified lines
2222 sorts by the moment you settled it. A thread that settled on its own sorts by its last message or
2323 turn, not by when the server noticed it was inactive.
2424
25−Change these rules in **Settings > General**. The change is written to every environment you are
26−connected to at that moment. An environment that is offline keeps its old value. When a connected
27−environment holds a different value, **Settings > General** shows a warning that names it. Choose
28−**Apply to all** to write your current values to every connected environment. The same applies to
29−the new-thread workspace mode and the source control writing style.
25+Change these rules in **Settings > General**. The change is written to every connected environment
26+whose server supports shared settings. An environment that is offline or needs a server update
27+keeps its old value and does not appear in mismatch warnings. When a connected environment whose
28+server supports shared settings holds a different value, **Settings > General** shows a warning
29+that names it. Choose **Apply to all** to write your current values to the environments named in
30+the warning. The same applies to the new-thread workspace mode and the source control writing
31+style.
3032
3133 A settings change affects future settlement and does not reopen a settled thread. Settings saved
3234 by older clients on one device no longer control this behavior.