History

ci: reject unused files and dependencies with Knip (#9962)

Julius Marminge committed 2 months ago

Commit d2c3e2e1 parent 00d46183 files · +14 −0Browse files

Unified · Split

3 files
  1. .github/workflows/ci.yml +4 −0
  2. docs/operations/development.md +9 −0
  3. package.json +1 −0
.github/workflows/ci.yml+4−0
@@ -45,6 +45,10 @@ jobs: · 44 unmodified lines
45 - name: Ensure Electron runtime is installed45 - name: Ensure Electron runtime is installed
46 run: vp run --filter @t3tools/desktop ensure:electron46 run: vp run --filter @t3tools/desktop ensure:electron
47 47
48 # Export cleanup is still a manual audit; files and dependencies have no baseline.
49 - name: Check unused files and dependencies
50 run: vp run knip:check
51
48 - name: Check52 - name: Check
49 run: vp check53 run: vp check
50 54
docs/operations/development.md+9−0
@@ -69,6 +69,15 @@ Use `vp run lint:mobile` for native mobile changes. CI owns the full suite; see · 68 unmodified lines
69The [manual Windows lane](../../.github/workflows/windows-tests.yml) is available for focused69The [manual Windows lane](../../.github/workflows/windows-tests.yml) is available for focused
70Windows investigation while that suite is not a required gate.70Windows investigation while that suite is not a required gate.
71 71
72### Unused code
73
74`vp run knip:check` runs the unused-file and dependency check enforced by CI.
75Use `vp run knip --workspace apps/web` to audit one workspace, including exports,
76or `vp run knip:production --workspace apps/web` to find code kept alive only by tests.
77The full export audit still has findings and is not a CI gate. Review callers before
78deleting code; production mode can also report development scripts and test fixtures.
79Runtime-discovered entrypoints and dependency exceptions belong in [knip.jsonc](../../knip.jsonc).
80
72## Desktop artifacts81## Desktop artifacts
73 82
74Local artifact builds are unsigned by default and write to `release/`:83Local artifact builds are unsigned by default and write to `release/`:
package.json+1−0
@@ -26,6 +26,7 @@ · 25 unmodified lines
26 "tc": "vp run -r --concurrency-limit 2 typecheck",26 "tc": "vp run -r --concurrency-limit 2 typecheck",
27 "lint": "vp lint --report-unused-disable-directives",27 "lint": "vp lint --report-unused-disable-directives",
28 "knip": "knip",28 "knip": "knip",
29 "knip:check": "knip --include files,dependencies --no-config-hints",
29 "knip:production": "knip --production",30 "knip:production": "knip --production",
30 "lint:mobile": "node scripts/mobile-native-static-check.ts",31 "lint:mobile": "node scripts/mobile-native-static-check.ts",
31 "test": "vp run -r test",32 "test": "vp run -r test",