Classify missing provider bindings

Julius Marminge committed 4 months ago

Commit d59b5911 parent 4934dc23 files · +28 −6Browse files

Unified · Split

3 files

apps/server/src/provider/Errors.ts +2 −0
apps/server/src/provider/ProviderSessionDirectory.test.ts +12 −0
apps/server/src/provider/ProviderSessionDirectory.ts +14 −6

@@ -171,6 +171,8 @@ export class ProviderSessionNotFoundError extends Schema.TaggedErrorClass<Provid · 170 unmodified lines
171	}	171	}
172	}	172	}
173		173
		174	export const isProviderSessionNotFoundError = Schema.is(ProviderSessionNotFoundError);
		175
174	/**	176	/**
175	* ProviderSessionDirectoryPersistenceError - Session directory persistence failure.	177	* ProviderSessionDirectoryPersistenceError - Session directory persistence failure.
176	*/	178	*/

apps/server/src/provider/ProviderSessionDirectory.test.ts+12−0

   SqlitePersistenceMemory,
 } from "../persistence/Layers/Sqlite.ts";
 import * as ProviderSessionRuntime from "../persistence/ProviderSessionRuntime.ts";
+import { isProviderSessionNotFoundError } from "./Errors.ts";
 import * as ProviderSessionDirectory from "./ProviderSessionDirectory.ts";
 function makeDirectoryLayer<E, R>(persistenceLayer: Layer.Layer<SqlClient.SqlClient, E, R>) {
       assert.deepEqual(threadIds, [nextThreadId]);
     }));
+  it("reports a missing provider binding as a domain not-found error", () =>
+    Effect.gen(function* () {
+      const directory = yield* ProviderSessionDirectory.ProviderSessionDirectory;
+      const threadId = ThreadId.make("thread-missing");
+      const error = yield* directory.getProvider(threadId).pipe(Effect.flip);
+      assert(isProviderSessionNotFoundError(error));
+      assert.equal(error.threadId, threadId);
+    }));
   it("persists runtime fields and merges payload updates", () =>
     Effect.gen(function* () {
       const directory = yield* ProviderSessionDirectory.ProviderSessionDirectory;

apps/server/src/provider/ProviderSessionDirectory.ts+14−6

 import * as Option from "effect/Option";
 import * as Schema from "effect/Schema";
-import { ProviderSessionDirectoryPersistenceError, ProviderValidationError } from "./Errors.ts";
+import {
+  ProviderSessionDirectoryPersistenceError,
+  ProviderSessionNotFoundError,
+  ProviderValidationError,
+} from "./Errors.ts";
 import * as ProviderSessionRuntime from "../persistence/ProviderSessionRuntime.ts";
 export interface ProviderRuntimeBinding {
   readonly lastSeenAt: string;
 }
-export type ProviderSessionDirectoryReadError = ProviderSessionDirectoryPersistenceError;
+export type ProviderSessionDirectoryReadError =
+  | ProviderSessionDirectoryPersistenceError
+  | ProviderSessionNotFoundError;
 export type ProviderSessionDirectoryWriteError =
   | ProviderValidationError
     ) => Effect.Effect<ProviderDriverKind, ProviderSessionDirectoryReadError>;
     readonly getBinding: (
       threadId: ThreadId,
-    ) => Effect.Effect<Option.Option<ProviderRuntimeBinding>, ProviderSessionDirectoryReadError>;
+    ) => Effect.Effect<
+      Option.Option<ProviderRuntimeBinding>,
+      ProviderSessionDirectoryPersistenceError
+    >;
     readonly listThreadIds: () => Effect.Effect<
       ReadonlyArray<ThreadId>,
       ProviderSessionDirectoryPersistenceError
           onSome: (value) => Effect.succeed(value.provider),
           onNone: () =>
             Effect.fail(
-              new ProviderSessionDirectoryPersistenceError({
+              new ProviderSessionNotFoundError({
-                operation: "ProviderSessionDirectory.getProvider",
+                threadId,
-                detail: `No persisted provider binding found for thread '${threadId}'.`,
               }),
             ),
         }),