- Wire `it.layer` to `GitHubCliLive` in `GitHubCli.test.ts` - Remove redundant `Effect.provide(GitHubCliLive)` calls in individual tests
Unified · Split
| @@ -1,5 +1,5 @@ | |||
| 1 | import { assert, it } from "@effect/vitest"; | 1 | import { assert, it } from "@effect/vitest"; |
| 2 | import { Effect, Layer } from "effect"; | 2 | import { Effect } from "effect"; |
| 3 | import { afterEach, expect, vi } from "vitest"; | 3 | import { afterEach, expect, vi } from "vitest"; |
| 4 | 4 | ||
| 5 | vi.mock("../../processRunner", () => ({ | 5 | vi.mock("../../processRunner", () => ({ |
| @@ -11,7 +11,7 @@ import { GitHubCli } from "../Services/GitHubCli.ts"; · 5 unmodified lines | |||
| 11 | import { GitHubCliLive } from "./GitHubCli.ts"; | 11 | import { GitHubCliLive } from "./GitHubCli.ts"; |
| 12 | 12 | ||
| 13 | const mockedRunProcess = vi.mocked(runProcess); | 13 | const mockedRunProcess = vi.mocked(runProcess); |
| 14 | const layer = it.layer(Layer.empty); | 14 | const layer = it.layer(GitHubCliLive); |
| 15 | 15 | ||
| 16 | afterEach(() => { | 16 | afterEach(() => { |
| 17 | mockedRunProcess.mockReset(); | 17 | mockedRunProcess.mockReset(); |
| @@ -49,7 +49,7 @@ layer("GitHubCliLive", (it) => { · 31 unmodified lines | |||
| 49 | cwd: "/repo", | 49 | cwd: "/repo", |
| 50 | reference: "#42", | 50 | reference: "#42", |
| 51 | }); | 51 | }); |
| 52 | }).pipe(Effect.provide(GitHubCliLive)); | 52 | }); |
| 53 | 53 | ||
| 54 | assert.deepStrictEqual(result, { | 54 | assert.deepStrictEqual(result, { |
| 55 | number: 42, | 55 | number: 42, |
| @@ -96,7 +96,7 @@ layer("GitHubCliLive", (it) => { · 40 unmodified lines | |||
| 96 | cwd: "/repo", | 96 | cwd: "/repo", |
| 97 | repository: "octocat/codething-mvp", | 97 | repository: "octocat/codething-mvp", |
| 98 | }); | 98 | }); |
| 99 | }).pipe(Effect.provide(GitHubCliLive)); | 99 | }); |
| 100 | 100 | ||
| 101 | assert.deepStrictEqual(result, { | 101 | assert.deepStrictEqual(result, { |
| 102 | nameWithOwner: "octocat/codething-mvp", | 102 | nameWithOwner: "octocat/codething-mvp", |
| @@ -120,7 +120,7 @@ layer("GitHubCliLive", (it) => { · 17 unmodified lines | |||
| 120 | cwd: "/repo", | 120 | cwd: "/repo", |
| 121 | reference: "4888", | 121 | reference: "4888", |
| 122 | }); | 122 | }); |
| 123 | }).pipe(Effect.provide(GitHubCliLive), Effect.flip); | 123 | }).pipe(Effect.flip); |
| 124 | 124 | ||
| 125 | assert.equal(error.message.includes("Pull request not found"), true); | 125 | assert.equal(error.message.includes("Pull request not found"), true); |
| 126 | }), | 126 | }), |