feat(web): make right panel maximize bindable (#5091)

El-Hussein Abdelraouf committed 3 months ago

Commit e17f2441 parent 62bb9748 files · +42 −7Browse files

Unified · Split

8 files

@@ -203,6 +203,7 @@ it.layer(NodeServices.layer)("keybindings", (it) => { · 202 unmodified lines
203	assert.equal(defaultsByCommand.get("projectSearch.toggle"), "mod+shift+f");	203	assert.equal(defaultsByCommand.get("projectSearch.toggle"), "mod+shift+f");
204	assert.equal(defaultsByCommand.get("sidebar.toggle"), "mod+b");	204	assert.equal(defaultsByCommand.get("sidebar.toggle"), "mod+b");
205	assert.equal(defaultsByCommand.get("rightPanel.toggle"), "mod+alt+b");	205	assert.equal(defaultsByCommand.get("rightPanel.toggle"), "mod+alt+b");
		206	assert.isFalse(defaultsByCommand.has("rightPanel.toggleMaximized"));
206	assert.equal(defaultsByCommand.get("terminal.splitVertical"), "mod+shift+d");	207	assert.equal(defaultsByCommand.get("terminal.splitVertical"), "mod+shift+d");
207	assert.equal(defaultsByCommand.get("modelPicker.jump.1"), "mod+1");	208	assert.equal(defaultsByCommand.get("modelPicker.jump.1"), "mod+1");
208	assert.equal(defaultsByCommand.get("modelPicker.jump.9"), "mod+9");	209	assert.equal(defaultsByCommand.get("modelPicker.jump.9"), "mod+9");

         return;
       }
+      if (command === "rightPanel.toggleMaximized") {
+        event.preventDefault();
+        event.stopPropagation();
+        toggleRightPanelMaximized();
+        return;
+      }
       if (command === "terminal.split") {
         event.preventDefault();
         event.stopPropagation();
     keybindings,
     onToggleDiff,
     toggleRightPanel,
+    toggleRightPanelMaximized,
     toggleTerminalVisibility,
     composerRef,
   ]);

     expect(options).not.toContain("customModeActive");
   });
-  it("builds command options from defaults and resolved project bindings", () => {
+  it("builds command options from built-in commands and resolved project bindings", () => {
     const options = buildKeybindingCommandOptions([
       {
         command: "script.setup-db.run",
       },
     ] satisfies ResolvedKeybindingsConfig);
-    expect(options).toEqual(expect.arrayContaining(["chat.new", "script.setup-db.run"]));
+    expect(options).toEqual(
+      expect.arrayContaining(["chat.new", "rightPanel.toggleMaximized", "script.setup-db.run"]),
+    );
   });
   it("reports unknown when variables without rejecting parseable expressions", () => {

 import {
+  STATIC_KEYBINDING_COMMANDS,
   type KeybindingCommand,
   type KeybindingShortcut,
   type KeybindingWhenNode,
 export function buildKeybindingCommandOptions(
   keybindings: ResolvedKeybindingsConfig,
 ): ReadonlyArray<KeybindingCommandOption> {
-  const commands = new Set<KeybindingCommand>();
+  const commands = new Set<KeybindingCommand>(STATIC_KEYBINDING_COMMANDS);
-  for (const binding of DEFAULT_RESOLVED_KEYBINDINGS) {
-    commands.add(binding.command);
-  }
   for (const binding of keybindings) {
     commands.add(binding.command);
   }

@@ -679,6 +679,22 @@ describe("resolveShortcutCommand", () => { · 678 unmodified lines
679	);	679	);
680	});	680	});
681		681
		682	it("resolves a custom right panel maximize binding", () => {
		683	const keybindings = compile([
		684	{
		685	shortcut: modShortcut("m", { shiftKey: true }),
		686	command: "rightPanel.toggleMaximized",
		687	},
		688	]);
		689
		690	assert.strictEqual(
		691	resolveShortcutCommand(event({ key: "m", metaKey: true, shiftKey: true }), keybindings, {
		692	platform: "MacIntel",
		693	}),
		694	"rightPanel.toggleMaximized",
		695	);
		696	});
		697
682	it("matches bracket shortcuts using the physical key code", () => {	698	it("matches bracket shortcuts using the physical key code", () => {
683	assert.strictEqual(	699	assert.strictEqual(
684	resolveShortcutCommand(	700	resolveShortcutCommand(

@@ -47,6 +47,9 @@ Use Inspect to pick an element in the app and reveal its color token. Inspec · 46 unmodified lines
47	successful pick; its hover glow and badge preview the element and token that click will select.	47	successful pick; its hover glow and badge preview the element and token that click will select.
48	Cancel or `Escape` exits Inspect and clears its selection and spotlight.	48	Cancel or `Escape` exits Inspect and clears its selection and spotlight.
49		49
		50	`rightPanel.toggleMaximized` maximizes or restores the open right panel. It has no default shortcut,
		51	so add one in Settings → Keybindings if you want to use it.
		52
50	The command palette searches active thread titles, projects, branches, user messages, and final	53	The command palette searches active thread titles, projects, branches, user messages, and final
51	agent responses across connected environments. Message matches show one labeled excerpt while	54	agent responses across connected environments. Message matches show one labeled excerpt while
52	keeping the thread's project, branch, and machine context visible. Message search begins after two	55	keeping the thread's project, branch, and machine context visible. Message search begins after two

     });
     assert.strictEqual(parsedRightPanelToggle.command, "rightPanel.toggle");
+    const parsedRightPanelToggleMaximized = yield* decode(KeybindingRule, {
+      key: "mod+shift+m",
+      command: "rightPanel.toggleMaximized",
+    });
+    assert.strictEqual(parsedRightPanelToggleMaximized.command, "rightPanel.toggleMaximized");
     const parsedClose = yield* decode(KeybindingRule, {
       key: "mod+w",
       command: "terminal.close",

 ] as const;
 export type ModelPickerKeybindingCommand = (typeof MODEL_PICKER_KEYBINDING_COMMANDS)[number];
-const STATIC_KEYBINDING_COMMANDS = [
+export const STATIC_KEYBINDING_COMMANDS = [
   "sidebar.toggle",
   "terminal.toggle",
   "terminal.split",
   "terminal.new",
   "terminal.close",
   "rightPanel.toggle",
+  "rightPanel.toggleMaximized",
   "diff.toggle",
   "preview.toggle",
   "preview.refresh",

Keyboard shortcuts