History

Remove dead provider parameter from startProviderSession closure

The startProviderSession closure declared a provider?: ProviderKind parameter in its input type, but the function body never read it — it unconditionally uses the outer preferredProvider instead. Remove the dead parameter to avoid misleading future callers.

Cursor Agent committed 7 months ago

Commit e7ae3f41 parent 97ff0ac1 file · +1 −4Browse files

Unified · Split

apps/server/src/orchestration/Layers/ProviderCommandReactor.ts+1−4
@@ -260,10 +260,7 @@ const make = Effect.gen(function* () { · 259 unmodified lines
260 .listSessions()260 .listSessions()
261 .pipe(Effect.map((sessions) => sessions.find((session) => session.threadId === threadId)));261 .pipe(Effect.map((sessions) => sessions.find((session) => session.threadId === threadId)));
262 262
263 const startProviderSession = (input?: {263 const startProviderSession = (input?: { readonly resumeCursor?: unknown }) =>
264 readonly resumeCursor?: unknown;
265 readonly provider?: ProviderKind;
266 }) =>
267 providerService.startSession(threadId, {264 providerService.startSession(threadId, {
268 threadId,265 threadId,
269 ...(preferredProvider ? { provider: preferredProvider } : {}),266 ...(preferredProvider ? { provider: preferredProvider } : {}),

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t