Switch review preview timestamps to DateTimeUtc

- Emit Effect DateTime values from review and git diff previews - Tighten the contract to require UTC datetime output

Julius Marminge committed 6 months ago

Commit f73b8bc1 parent 92368024 files · +12 −16Browse files

Unified · Split

4 files

-import { Context, Effect, Layer } from "effect";
+import { Context, DateTime, Effect, Layer } from "effect";
 import {
   VcsUnsupportedOperationError,
   type ReviewDiffPreviewResult,
 } from "@t3tools/contracts";
-import { GitVcsDriver } from "../vcs/GitVcsDriver.ts";
+import * as GitVcsDriver from "../vcs/GitVcsDriver.ts";
 import * as VcsDriverRegistry from "../vcs/VcsDriverRegistry.ts";
 export interface ReviewServiceShape {
   "t3/review/ReviewService",
 ) {}
-function emptyDiffPreview(input: ReviewDiffPreviewInput): ReviewDiffPreviewResult {
-  return {
-    cwd: input.cwd,
-    generatedAt: new Date().toISOString(),
-    sources: [],
-  };
-}
 export const make = Effect.fn("makeReviewService")(function* () {
   const vcsRegistry = yield* VcsDriverRegistry.VcsDriverRegistry;
-  const git = yield* GitVcsDriver;
+  const git = yield* GitVcsDriver.GitVcsDriver;
   const getDiffPreview: ReviewServiceShape["getDiffPreview"] = Effect.fn(
     "ReviewService.getDiffPreview",
   )(function* (input) {
     const handle = yield* vcsRegistry.detect({ cwd: input.cwd, requestedKind: "auto" });
     if (!handle) {
-      return emptyDiffPreview(input);
+      return {
+        cwd: input.cwd,
+        generatedAt: yield* DateTime.now,
+        sources: [],
+      };
     }
     const getDriverDiffPreview = handle.driver.getDiffPreview;

@@ -2526,7 +2526,7 @@ it.layer(NodeServices.layer)("server router seam", (it) => { · 2525 unmodified lines
2526	getDiffPreview: (input) =>	2526	getDiffPreview: (input) =>
2527	Effect.succeed({	2527	Effect.succeed({
2528	cwd: input.cwd,	2528	cwd: input.cwd,
2529	generatedAt: new Date(0).toISOString(),	2529	generatedAt: DateTime.nowUnsafe(),
2530	sources: [	2530	sources: [
2531	{	2531	{
2532	id: "working-tree",	2532	id: "working-tree",

@@ -1702,7 +1702,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function* · 1701 unmodified lines
1702	if (!details.isRepo) {	1702	if (!details.isRepo) {
1703	return {	1703	return {
1704	cwd: input.cwd,	1704	cwd: input.cwd,
1705	generatedAt: new Date().toISOString(),	1705	generatedAt: yield* DateTime.now,
1706	sources: [],	1706	sources: [],
1707	};	1707	};
1708	}	1708	}
@@ -1791,7 +1791,7 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function* · 82 unmodified lines
1791		1791
1792	return {	1792	return {
1793	cwd: input.cwd,	1793	cwd: input.cwd,
1794	generatedAt: new Date().toISOString(),	1794	generatedAt: yield* DateTime.now,
1795	sources,	1795	sources,
1796	};	1796	};
1797	});	1797	});

@@ -26,7 +26,7 @@ export type ReviewDiffPreviewSource = typeof ReviewDiffPreviewSource.Type; · 25 unmodified lines
26		26
27	export const ReviewDiffPreviewResult = Schema.Struct({	27	export const ReviewDiffPreviewResult = Schema.Struct({
28	cwd: TrimmedNonEmptyString,	28	cwd: TrimmedNonEmptyString,
29	generatedAt: Schema.String,	29	generatedAt: Schema.DateTimeUtc,
30	sources: Schema.Array(ReviewDiffPreviewSource),	30	sources: Schema.Array(ReviewDiffPreviewSource),
31	});	31	});
32	export type ReviewDiffPreviewResult = typeof ReviewDiffPreviewResult.Type;	32	export type ReviewDiffPreviewResult = typeof ReviewDiffPreviewResult.Type;