fix: use || instead of ?? for binaryPath to handle empty string default

Cursor Agent committed 7 months ago

Commit f74ee021 parent a9aa5c42 files · +2 −2Browse files

Unified · Split

2 files

apps/server/src/git/Layers/ClaudeTextGeneration.ts +1 −1
apps/server/src/git/Layers/CodexTextGeneration.ts +1 −1

apps/server/src/git/Layers/ClaudeTextGeneration.ts+1−1

@@ -95,7 +95,7 @@ const makeClaudeTextGeneration = Effect.gen(function* () { · 94 unmodified lines
95		95
96	const runClaudeCommand = Effect.gen(function* () {	96	const runClaudeCommand = Effect.gen(function* () {
97	const command = ChildProcess.make(	97	const command = ChildProcess.make(
98	claudeSettings?.binaryPath ?? "claude",	98	claudeSettings?.binaryPath \|\| "claude",
99	[	99	[
100	"-p",	100	"-p",
101	"--output-format",	101	"--output-format",

apps/server/src/git/Layers/CodexTextGeneration.ts+1−1

@@ -153,7 +153,7 @@ const makeCodexTextGeneration = Effect.gen(function* () { · 152 unmodified lines
153	const reasoningEffort =	153	const reasoningEffort =
154	modelSelection.options?.reasoningEffort ?? CODEX_GIT_TEXT_GENERATION_REASONING_EFFORT;	154	modelSelection.options?.reasoningEffort ?? CODEX_GIT_TEXT_GENERATION_REASONING_EFFORT;
155	const command = ChildProcess.make(	155	const command = ChildProcess.make(
156	codexSettings?.binaryPath ?? "codex",	156	codexSettings?.binaryPath \|\| "codex",
157	[	157	[
158	"exec",	158	"exec",
159	"--ephemeral",	159	"--ephemeral",