History

Run checks before release commit and set desktop buildVersion

- Move install, lint, typecheck, and test steps ahead of release commit/tag in `release.yml` - Add `buildVersion` to staged desktop `package.json` and set it to the app version

Julius Marminge committed 8 months ago

Commit fa0205c1 parent 8a20bd72 files · +14 −12Browse files

Unified · Split

2 files
  1. .github/workflows/release.yml +12 −12
  2. scripts/build-desktop-artifact.ts +2 −0
.github/workflows/release.yml+12−12
@@ -84,6 +84,18 @@ jobs: · 83 unmodified lines
8484 if: github.event_name == 'workflow_dispatch'
8585 run: bun install
8686
87+ - name: Install dependencies
88+ run: bun install --frozen-lockfile
89+
90+ - name: Lint
91+ run: bun run lint
92+
93+ - name: Typecheck
94+ run: bun run typecheck
95+
96+ - name: Test
97+ run: bun run test
98+
8799 - name: Commit and push release version + tag
88100 if: github.event_name == 'workflow_dispatch'
89101 shell: bash
@@ -117,18 +129,6 @@ jobs: · 27 unmodified lines
117129 echo "value=${GITHUB_SHA}" >> "$GITHUB_OUTPUT"
118130 fi
119131
120− - name: Install dependencies
121− run: bun install --frozen-lockfile
122−
123− - name: Lint
124− run: bun run lint
125−
126− - name: Typecheck
127− run: bun run typecheck
128−
129− - name: Test
130− run: bun run test
131−
132132 build:
133133 name: Build ${{ matrix.label }}
134134 needs: preflight
scripts/build-desktop-artifact.ts+2−0
@@ -99,6 +99,7 @@ interface ResolvedBuildOptions { · 98 unmodified lines
9999 interface StagePackageJson {
100100 readonly name: string;
101101 readonly version: string;
102+ readonly buildVersion: string;
102103 readonly private: true;
103104 readonly description: string;
104105 readonly author: string;
@@ -488,6 +489,7 @@ const buildDesktopArtifact = Effect.fn(function* (options: ResolvedBuildOptions) · 383 unmodified lines
488489 const stagePackageJson: StagePackageJson = {
489490 name: "t3-code-desktop",
490491 version: appVersion,
492+ buildVersion: appVersion,
491493 private: true,
492494 description: "T3 Code desktop build",
493495 author: "T3 Tools",