fix(web): remove inserted citations on cancel (#10518)

Exotic committed 2 months ago

Commit fe07ffe1 parent 8b2838e2 files · +19 −7Browse files

Unified · Split

2 files

apps/web/src/components/ComposerCitationNode.tsx +11 −6
apps/web/src/components/chat/AssistantCitationChip.tsx +8 −1

apps/web/src/components/ComposerCitationNode.tsx+11−6

 export type ComposerCitationCommentTarget = {
   nodeKey: NodeKey;
   sourceAnchor?: AssistantCitationSourceAnchor;
+  removeOnCancel?: boolean;
 };
 export const ComposerCitationCommentContext = createContext<{
   let offset = 0;
   for (const node of paragraph.getChildren()) {
     if (offset === request.citationStart && node instanceof ComposerCitationNode) {
-      return { nodeKey: node.getKey(), sourceAnchor: request.sourceAnchor };
+      return {
+        nodeKey: node.getKey(),
+        sourceAnchor: request.sourceAnchor,
+        removeOnCancel: true,
+      };
     }
     offset += node.getTextContentSize();
   }
 function ComposerCitationDecorator(props: { citation: AssistantCitation; nodeKey: NodeKey }) {
   const [editor] = useLexicalComposerContext();
   const commentContext = use(ComposerCitationCommentContext);
+  const commentTarget =
+    commentContext.openComment?.nodeKey === props.nodeKey ? commentContext.openComment : null;
   const onSaveComment = (comment: string): boolean => {
     if (!editor.isEditable()) return false;
     let accepted = false;
       <AssistantCitationChip
         citation={props.citation}
         commentEditor={{
-          open: commentContext.openComment?.nodeKey === props.nodeKey,
+          open: commentTarget !== null,
-          sourceAnchor:
+          sourceAnchor: commentTarget?.sourceAnchor,
-            commentContext.openComment?.nodeKey === props.nodeKey
-              ? commentContext.openComment.sourceAnchor
-              : undefined,
           onOpenChange: (open) => {
             if (open && !editor.isEditable()) return;
             commentContext.onOpenChange(props.nodeKey, open);
           },
+          ...(commentTarget?.removeOnCancel ? { onCancel: onRemove } : {}),
           onSave: onSaveComment,
           onSaveAndSend: (comment) => {
             if (!onSaveComment(comment)) return false;

apps/web/src/components/chat/AssistantCitationChip.tsx+8−1

     open: boolean;
     sourceAnchor?: AssistantCitationSourceAnchor | undefined;
     onOpenChange: (open: boolean) => void;
+    onCancel?: () => void;
     onSave: (comment: string) => boolean;
     onSaveAndSend?: (comment: string) => boolean;
   };
                       },
                     }
                   : {})}
-                onCancel={() => commentEditor.onOpenChange(false)}
+                onCancel={() => {
+                  if (commentEditor.onCancel) {
+                    commentEditor.onCancel();
+                  } else {
+                    commentEditor.onOpenChange(false);
+                  }
+                }}
               />
             </PopoverPopup>
           ) : null}