History

Final build issues from Mac (i.e. XCode)

arr committed 9 years ago

Commit 8d11a421 parent b0ff2264 files · +13 −9Browse files

Unified · Split

4 files
  1. src/asm/sbl_reader.cpp +6 −6
  2. src/include/builtin_module.h +1 −1
  3. src/include/vm_asm_sigkind.h +2 −2
  4. src/vm/thread.cpp +4 −0
src/asm/sbl_reader.cpp+6−6
@@ -125,7 +125,7 @@ namespace · 124 unmodified lines
125125 const std::string &type_table_t::resolve_table_index<std::string>(int32_t idx) const
126126 {
127127 const auto idx_local = idx & ~string_table_mask;
128− if (0 > idx_local || idx_local >= strings_table.size())
128+ if (idx_local >= strings_table.size())
129129 throw std::out_of_range{ "Invalid string table index" };
130130
131131 return strings_table[idx_local];
@@ -137,7 +137,7 @@ namespace · 5 unmodified lines
137137 if ((static_cast<uint32_t>(idx) & inner_type_table_mask) != 0)
138138 {
139139 const auto idx_local = idx & ~inner_type_table_mask;
140− if (0 > idx_local || idx_local >= inner_type_table.size())
140+ if (idx_local >= inner_type_table.size())
141141 throw std::out_of_range{ "Invalid inner type table index" };
142142
143143 return inner_type_table[idx_local];
@@ -155,7 +155,7 @@ namespace · 11 unmodified lines
155155 const source_ref_t &type_table_t::resolve_table_index<source_ref_t>(int32_t idx) const
156156 {
157157 const auto idx_local = idx & ~source_table_mask;
158− if (0 > idx_local || idx_local >= source_table.size())
158+ if (idx_local >= source_table.size())
159159 throw std::out_of_range{ "Invalid source table index" };
160160
161161 return source_table[idx_local];
@@ -165,7 +165,7 @@ namespace · 3 unmodified lines
165165 const name_source_size_t &type_table_t::resolve_table_index<name_source_size_t>(int32_t idx) const
166166 {
167167 const auto idx_local = idx & ~adt_table_mask;
168− if (0 > idx_local || idx_local >= adt_table.size())
168+ if (idx_local >= adt_table.size())
169169 throw std::out_of_range{ "Invalid adt table index" };
170170
171171 return adt_table[idx_local];
@@ -175,9 +175,9 @@ namespace · 3 unmodified lines
175175 const tuple_item_t &type_table_t::resolve_table_index<tuple_item_t>(int32_t idx) const
176176 {
177177 const auto idx_local = idx & ~tuple_type_mask;
178− if (0 > idx_local || idx_local >= tuple_table.size())
178+ if (idx_local >= tuple_table.size())
179179 throw std::out_of_range{ "Invalid tuple table index" };
180−
180+
181181 return tuple_table[idx_local];
182182 }
183183
src/include/builtin_module.h+1−1
@@ -28,7 +28,7 @@ namespace disvm · 27 unmodified lines
2828 struct vm_runtab_t
2929 {
3030 // Function identification
31− char *name;
31+ const char *name;
3232 uint32_t sig;
3333
3434 // Function pointer
src/include/vm_asm_sigkind.h+2−2
@@ -254,7 +254,7 @@ namespace disvm · 253 unmodified lines
254254 class Tadt_pick_tag final : public Tbasic_type<type_id_t::adt_pick_tag>
255255 {
256256 public: // static
257− static constexpr char *tag_delim();
257+ static constexpr const char *tag_delim();
258258 static constexpr char begin();
259259 static constexpr char end();
260260
@@ -267,7 +267,7 @@ namespace disvm · 6 unmodified lines
267267 Tadt_pick_tag(sig_stream_t &s) : _s{ std::move(s) } { }
268268 };
269269
270− constexpr char *Tadt_pick_tag::tag_delim() { return "=>"; }
270+ constexpr const char *Tadt_pick_tag::tag_delim() { return "=>"; }
271271 constexpr char Tadt_pick_tag::begin() { return '('; }
272272 constexpr char Tadt_pick_tag::end() { return ')'; }
273273
src/vm/thread.cpp+4−0
@@ -290,6 +290,10 @@ vm_thread_state_t vm_thread_t::execute(vm_t &vm, const uint32_t quanta) · 289 unmodified lines
290290 if (tool_dispatch != nullptr)
291291 tool_dispatch->on_thread_broken(*this);
292292 break;
293+
294+ default:
295+ // Let other thread states fall through
296+ break;
293297 }
294298
295299 return _registers.current_thread_state;