History

Merge pull request #40 from nphilipp/develop--py3k-fixes

Miscellaneous fixes for Python, mostly version 3

Paul Brossier committed 10 years ago

Commit 4041a6d2 parents 7c785e6 b8ed85e10 files · +34 −20Browse files

Showing the changes to python (10 of 10 files). Show all

Unified · Split

10 files
  1. python/VERSION +1 −1
  2. python/ext/aubio-types.h +5 −0
  3. python/ext/aubiowraphell.h +2 −2
  4. python/ext/py-cvec.c +1 −1
  5. python/ext/py-filter.c +1 −1
  6. python/ext/py-sink.c +1 −1
  7. python/ext/py-source.c +1 −1
  8. python/lib/aubio/midiconv.py +11 −8
  9. python/lib/gen_pyobject.py +1 −1
  10. python/lib/generator.py +10 −4
python/VERSION+1−1
@@ -1,7 +1,7 @@
11 AUBIO_MAJOR_VERSION=0
22 AUBIO_MINOR_VERSION=4
33 AUBIO_PATCH_VERSION=2
4−AUBIO_VERSION_STATUS='~alpha'
4+AUBIO_VERSION_STATUS='a0'
55 LIBAUBIO_LT_CUR=4
66 LIBAUBIO_LT_REV=1
77 LIBAUBIO_LT_AGE=1
python/ext/aubio-types.h+5−0
@@ -39,6 +39,11 @@ · 38 unmodified lines
3939 #define AUBIO_NPY_SMPL NPY_FLOAT
4040 #endif
4141
42+// compat with Python < 2.6
43+#ifndef Py_TYPE
44+#define Py_TYPE(ob) (((PyObject*)(ob))->ob_type)
45+#endif
46+
4247 // special python type for cvec
4348 typedef struct
4449 {
python/ext/aubiowraphell.h+2−2
@@ -13,7 +13,7 @@ Py_ ## NAME ## _init (Py_ ## NAME * self, PyObject * args, PyObject * kwds) \ · 12 unmodified lines
1313 { \
1414 self->o = new_aubio_## NAME ( PARAMS ); \
1515 if (self->o == NULL) { \
16− PyErr_SetString (PyExc_StandardError, "error creating object"); \
16+ PyErr_SetString (PyExc_RuntimeError, "error creating object"); \
1717 return -1; \
1818 } \
1919 \
@@ -25,7 +25,7 @@ static void \ · 5 unmodified lines
2525 Py_ ## NAME ## _del ( Py_ ## NAME * self) \
2626 { \
2727 del_aubio_ ## NAME (self->o); \
28− self->ob_type->tp_free ((PyObject *) self); \
28+ Py_TYPE(self)->tp_free ((PyObject *) self); \
2929 }
3030
3131 #define AUBIO_MEMBERS_START(NAME) \
python/ext/py-cvec.c+1−1
@@ -59,7 +59,7 @@ static void · 58 unmodified lines
5959 Py_cvec_del (Py_cvec * self)
6060 {
6161 del_cvec (self->o);
62− self->ob_type->tp_free ((PyObject *) self);
62+ Py_TYPE(self)->tp_free ((PyObject *) self);
6363 }
6464
6565 static PyObject *
python/ext/py-filter.c+1−1
@@ -57,7 +57,7 @@ Py_filter_del (Py_filter * self) · 56 unmodified lines
5757 {
5858 del_fvec(self->out);
5959 del_aubio_filter (self->o);
60− self->ob_type->tp_free ((PyObject *) self);
60+ Py_TYPE(self)->tp_free ((PyObject *) self);
6161 }
6262
6363 static PyObject *
python/ext/py-sink.c+1−1
@@ -115,7 +115,7 @@ Py_sink_init (Py_sink * self, PyObject * args, PyObject * kwds) · 114 unmodified lines
115115 aubio_sink_preset_samplerate ( self->o, self->samplerate );
116116 }
117117 if (self->o == NULL) {
118− PyErr_SetString (PyExc_StandardError, "error creating sink with this uri");
118+ PyErr_SetString (PyExc_RuntimeError, "error creating sink with this uri");
119119 return -1;
120120 }
121121 self->samplerate = aubio_sink_get_samplerate ( self->o );
python/ext/py-source.c+1−1
@@ -139,7 +139,7 @@ Py_source_init (Py_source * self, PyObject * args, PyObject * kwds) · 138 unmodified lines
139139 if (self->o == NULL) {
140140 char_t errstr[30 + strlen(self->uri)];
141141 sprintf(errstr, "error creating source with %s", self->uri);
142− PyErr_SetString (PyExc_StandardError, errstr);
142+ PyErr_SetString (PyExc_RuntimeError, errstr);
143143 return -1;
144144 }
145145 self->samplerate = aubio_source_get_samplerate ( self->o );
python/lib/aubio/midiconv.py+11−8
@@ -6,9 +6,11 @@ def note2midi(note): · 5 unmodified lines
66 _valid_modifiers = {None: 0, u'♮': 0, '#': +1, u'♯': +1, u'\udd2a': +2, 'b': -1, u'♭': -1, u'\ufffd': -2}
77 _valid_octaves = range(-1, 10)
88 if type(note) not in (str, unicode):
9− raise TypeError, "a string is required, got %s" % note
9+ raise TypeError("a string is required, got %s" % note)
1010 if not (1 < len(note) < 5):
11− raise ValueError, "string of 2 to 4 characters expected, got %d (%s)" % (len(note), note)
11+ raise ValueError(
12+ "string of 2 to 4 characters expected, got %d (%s)" %
13+ (len(note), note))
1214 notename, modifier, octave = [None]*3
1315
1416 if len(note) == 4:
@@ -26,23 +28,24 @@ def note2midi(note): · 11 unmodified lines
2628 octave = int(octave)
2729
2830 if notename not in _valid_notenames:
29− raise ValueError, "%s is not a valid note name" % notename
31+ raise ValueError("%s is not a valid note name" % notename)
3032 if modifier not in _valid_modifiers:
31− raise ValueError, "%s is not a valid modifier" % modifier
33+ raise ValueError("%s is not a valid modifier" % modifier)
3234 if octave not in _valid_octaves:
33− raise ValueError, "%s is not a valid octave" % octave
35+ raise ValueError("%s is not a valid octave" % octave)
3436
3537 midi = 12 + octave * 12 + _valid_notenames[notename] + _valid_modifiers[modifier]
3638 if midi > 127:
37− raise ValueError, "%s is outside of the range C-2 to G8" % note
39+ raise ValueError("%s is outside of the range C-2 to G8" % note)
3840 return midi
3941
4042 def midi2note(midi):
4143 " convert midi note number to note name, e.g. [0, 127] -> [C-1, G9] "
4244 if type(midi) != int:
43− raise TypeError, "an integer is required, got %s" % midi
45+ raise TypeError("an integer is required, got %s" % midi)
4446 if not (-1 < midi < 128):
45− raise ValueError, "an integer between 0 and 127 is excepted, got %d" % midi
47+ raise ValueError(
48+ "an integer between 0 and 127 is excepted, got %d" % midi)
4649 midi = int(midi)
4750 _valid_notenames = ['C', 'C#', 'D', 'D#', 'E', 'F', 'F#', 'G', 'G#', 'A', 'A#', 'B']
4851 return _valid_notenames[midi % 12] + str( midi / 12 - 1)
python/lib/gen_pyobject.py+1−1
@@ -70,7 +70,7 @@ def get_params_types_names(proto): · 69 unmodified lines
7070 example: proto = "int main (int argc, char ** argv)"
7171 returns: [['int', 'argc'], ['char **','argv']]
7272 """
73− return map(split_type, get_params(proto))
73+ return list(map(split_type, get_params(proto)))
7474
7575 def get_return_type(proto):
7676 import re
python/lib/generator.py+10−4
@@ -3,7 +3,7 @@ · 2 unmodified lines
33 """ This file generates a c file from a list of cpp prototypes. """
44
55 import os, sys, shutil
6−from gen_pyobject import write_msg, gen_new_init, gen_do, gen_members, gen_methods, gen_finish
6+from .gen_pyobject import write_msg, gen_new_init, gen_do, gen_members, gen_methods, gen_finish
77
88 def get_cpp_objects():
99
@@ -11,6 +11,7 @@ def get_cpp_objects(): · 1 unmodified line
1111
1212 cpp_output = filter(lambda y: len(y) > 1, cpp_output)
1313 cpp_output = filter(lambda y: not y.startswith('#'), cpp_output)
14+ cpp_output = list(cpp_output)
1415
1516 i = 1
1617 while 1:
@@ -85,9 +86,11 @@ def generate_object_files(output_path): · 68 unmodified lines
8586 object_methods = filter(lambda x: this_object in x, cpp_output)
8687 object_methods = [a.strip() for a in object_methods]
8788 object_methods = filter(lambda x: not x.startswith('typedef'), object_methods)
89+ object_methods = list(object_methods)
8890 #for method in object_methods:
8991 # write_msg(method)
90− new_methods = filter(lambda x: 'new_'+object_name in x, object_methods)
92+ new_methods = list(filter(
93+ lambda x: 'new_'+object_name in x, object_methods))
9194 if len(new_methods) > 1:
9295 write_msg("-- WARNING: more than one new method for", object_name)
9396 for method in new_methods:
@@ -98,7 +101,8 @@ def generate_object_files(output_path): · 4 unmodified lines
98101 for method in new_methods:
99102 write_msg(method)
100103
101− del_methods = filter(lambda x: 'del_'+object_name in x, object_methods)
104+ del_methods = list(filter(
105+ lambda x: 'del_'+object_name in x, object_methods))
102106 if len(del_methods) > 1:
103107 write_msg("-- WARNING: more than one del method for", object_name)
104108 for method in del_methods:
@@ -106,7 +110,8 @@ def generate_object_files(output_path): · 1 unmodified line
106110 elif len(del_methods) < 1:
107111 write_msg("-- WARNING: no del method for", object_name)
108112
109− do_methods = filter(lambda x: object_name+'_do' in x, object_methods)
113+ do_methods = list(filter(
114+ lambda x: object_name+'_do' in x, object_methods))
110115 if len(do_methods) > 1:
111116 pass
112117 #write_msg("-- WARNING: more than one do method for", object_name)
@@ -135,6 +140,7 @@ def generate_object_files(output_path): · 22 unmodified lines
135140 other_methods = filter(lambda x: x not in do_methods, other_methods)
136141 other_methods = filter(lambda x: x not in get_methods, other_methods)
137142 other_methods = filter(lambda x: x not in set_methods, other_methods)
143+ other_methods = list(other_methods)
138144
139145 if len(other_methods) > 0:
140146 write_msg("-- WARNING: some methods for", object_name, "were unidentified")

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t