History

[py] use universal_newlines=True to prevent decoding errors (see gh-247 gh-248)

Paul Brossier committed 7 years ago

Commit 66fff6c1 parent f55630c1 file · +5 −4Browse files

Showing the changes to python (1 of 1 file). Show all

Unified · Split

python/lib/gen_external.py+5−4
@@ -120,23 +120,24 @@ def get_cpp_output(header=header, usedouble=False): · 119 unmodified lines
120120 print("Running command: {:s}".format(" ".join(cpp_cmd)))
121121 proc = subprocess.Popen(cpp_cmd,
122122 stderr=subprocess.PIPE,
123− stdout=subprocess.PIPE)
123+ stdout=subprocess.PIPE,
124+ universal_newlines=True)
124125 assert proc, 'Proc was none'
125126 cpp_output = proc.stdout.read()
126127 err_output = proc.stderr.read()
127128 if err_output:
128129 print("Warning: preprocessor produced errors or warnings:\n%s" \
129− % err_output.decode('utf8'))
130+ % err_output)
130131 if not cpp_output:
131132 raise_msg = "preprocessor output is empty! Running command " \
132133 + "\"%s\" failed" % " ".join(cpp_cmd)
133134 if err_output:
134− raise_msg += " with stderr: \"%s\"" % err_output.decode('utf8')
135+ raise_msg += " with stderr: \"%s\"" % err_output
135136 else:
136137 raise_msg += " with no stdout or stderr"
137138 raise Exception(raise_msg)
138139 if not isinstance(cpp_output, list):
139− cpp_output = [l.strip() for l in cpp_output.decode('utf8').split('\n')]
140+ cpp_output = [l.strip() for l in cpp_output.split('\n')]
140141
141142 return cpp_output
142143

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t