History

python/lib/gen_code.py: improve del_ function, safer DECREF, fix indentation, emit RuntimeError

Paul Brossier committed 10 years ago

Commit 6a72ff01 parent 773a7f31 file · +9 −7Browse files

Showing the changes to python/lib/gen_code.py (1 of 1 file). Show all

Unified · Split

python/lib/gen_code.py+9−7
@@ -306,7 +306,7 @@ Py_{shortname}_init (Py_{shortname} * self, PyObject * args, PyObject * kwds) · 305 unmodified lines
306306 out += """
307307 // return -1 and set error string on failure
308308 if (self->o == NULL) {{
309− PyErr_Format (PyExc_Exception, "failed creating {shortname}");
309+ PyErr_Format (PyExc_RuntimeError, "failed creating {shortname}");
310310 return -1;
311311 }}
312312 """.format(paramchars = paramchars, paramvals = paramvals, **self.__dict__)
@@ -348,18 +348,20 @@ Py_{shortname}_del (Py_{shortname} * self, PyObject * unused) · 35 unmodified lines
348348 for input_param in self.do_inputs:
349349 if input_param['type'] == 'fmat_t *':
350350 out += """
351− free(self->{0[name]}.data);""".format(input_param)
351+ free(self->{0[name]}.data);""".format(input_param)
352352 for o in self.outputs:
353353 name = o['name']
354354 del_out = delfromtype_fn[o['type']]
355355 out += """
356− {del_out}(self->{name});""".format(del_out = del_out, name = name)
356+ if (self->{name}) {{
357+ {del_out}(self->{name});
358+ }}""".format(del_out = del_out, name = name)
357359 del_fn = get_name(self.del_proto)
358360 out += """
359− if (self->o) {{
360− {del_fn}(self->o);
361− }}
362− Py_TYPE(self)->tp_free((PyObject *) self);
361+ if (self->o) {{
362+ {del_fn}(self->o);
363+ }}
364+ Py_TYPE(self)->tp_free((PyObject *) self);
363365 }}
364366 """.format(del_fn = del_fn)
365367 return out

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t