remove restriction in MidiOut on message size; thanks mariobuoninfante for the fix

Ge Wang committed 5 years ago

Commit 2bfcc0d1 parent 96265323 files · +14 −5Browse files

Unified · Split

3 files

     mariobuoninfante for help in addressing this)
   - (fixed) reset Gen10 table to allow add/remove partials; thanks to
     mariobuoninfant
+  - (fixed) updated MidiOut and removed check in order to allow messages
+    of size less than or greater than 3 bytes; thanks to mariobuoninfante
+    for this issue report on Ubuntu Studio 64-bit; this fix addresses
+    the sending of MIDI clock, stop, continue, and SysEx -- also thank
+    you mariobuoninfante for the fix.
   - (deprecated) Chubgraph => (new) Chugraph;
     Chubgraph will continue to function, with a deprecation warning.
   - (documentation) updated embedded documentation text for all statically

@@ -402,6 +402,9 @@ t_CKBOOL MidiInManager::open( MidiIn * min, Chuck_VM * vm, t_CKINT device_num ) · 401 unmodified lines
402	return FALSE;	402	return FALSE;
403	}	403	}
404		404
		405	// clear ignore types \| 1.4.0.2 (mariobuoninfante)
		406	rtmin->ignoreTypes( false, false, false );
		407
405	// resize?	408	// resize?
406	if( device_num >= (t_CKINT)the_mins.capacity() )	409	if( device_num >= (t_CKINT)the_mins.capacity() )
407	{	410	{

@@ -1418,11 +1418,12 @@ void RtMidiOut :: sendMessage( std::vector<unsigned char> *message ) · 1417 unmodified lines
1418	snd_seq_ev_set_direct(&ev);	1418	snd_seq_ev_set_direct(&ev);
1419	for ( unsigned int i=0; i<nBytes; i++ ) data->buffer[i] = message->at(i);	1419	for ( unsigned int i=0; i<nBytes; i++ ) data->buffer[i] = message->at(i);
1420	result = snd_midi_event_encode( data->coder, data->buffer, (long)nBytes, &ev );	1420	result = snd_midi_event_encode( data->coder, data->buffer, (long)nBytes, &ev );
1421	if ( result < (int)nBytes ) {	1421	// commenting this out allows sending MIDI messages < and > 3 \| 1.4.0.2 (mariobuoninfante)
1422	errorString_ = "RtMidiOut::sendMessage: event parsing error!";	1422	// if( result < (int)nBytes ) {
1423	error( RtMidiError::WARNING );	1423	// errorString_ = "RtMidiOut::sendMessage: event parsing error!";
1424	return;	1424	// error( RtMidiError::WARNING );
1425	}	1425	// return;
		1426	// }
1426		1427
1427	// Send the event.	1428	// Send the event.
1428	result = snd_seq_event_output(data->seq, &ev);	1429	result = snd_seq_event_output(data->seq, &ev);

Keyboard shortcuts