History

vulkan_filter: use GENERAL image layout when no sampler is given

This allows using the generic filter code with STORAGE image inputs.

Lynne committed 1 year ago

Commit 042ed961 parent 1029f511 file · +16 −7Browse files

Showing the changes to libavfilter (1 of 1 file). Show all

Unified · Split

libavfilter/vulkan_filter.c+16−7
@@ -249,6 +249,9 @@ int ff_vk_filter_process_simple(FFVulkanContext *vkctx, FFVkExecPool *e, · 248 unmodified lines
249249 VkImageView out_views[AV_NUM_DATA_POINTERS];
250250 VkImageMemoryBarrier2 img_bar[37];
251251 int nb_img_bar = 0;
252+ VkImageLayout in_layout = sampler != VK_NULL_HANDLE ?
253+ VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL :
254+ VK_IMAGE_LAYOUT_GENERAL;
252255
253256 /* Update descriptors and init the exec context */
254257 FFVkExecContext *exec = ff_vk_exec_get(vkctx, e);
@@ -267,8 +270,8 @@ int ff_vk_filter_process_simple(FFVulkanContext *vkctx, FFVkExecPool *e, · 12 unmodified lines
267270 VK_PIPELINE_STAGE_2_COMPUTE_SHADER_BIT));
268271 RET(ff_vk_create_imageviews(vkctx, exec, in_views, in_f, FF_VK_REP_FLOAT));
269272 ff_vk_shader_update_img_array(vkctx, exec, shd, in_f, in_views, 0, 0,
270− VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
271− sampler);
273+ in_layout,
274+ sampler);
272275 }
273276
274277 /* Bind pipeline, update push data */
@@ -289,7 +292,7 @@ int ff_vk_filter_process_simple(FFVulkanContext *vkctx, FFVkExecPool *e, · 14 unmodified lines
289292 VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
290293 VK_PIPELINE_STAGE_2_COMPUTE_SHADER_BIT,
291294 VK_ACCESS_SHADER_READ_BIT,
292− VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
295+ in_layout,
293296 VK_QUEUE_FAMILY_IGNORED);
294297
295298 vk->CmdPipelineBarrier2(exec->buf, &(VkDependencyInfo) {
@@ -321,6 +324,9 @@ int ff_vk_filter_process_2pass(FFVulkanContext *vkctx, FFVkExecPool *e, · 25 unmodified lines
321324 VkImageView out_views[AV_NUM_DATA_POINTERS];
322325 VkImageMemoryBarrier2 img_bar[37];
323326 int nb_img_bar = 0;
327+ VkImageLayout in_layout = sampler != VK_NULL_HANDLE ?
328+ VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL :
329+ VK_IMAGE_LAYOUT_GENERAL;
324330
325331 /* Update descriptors and init the exec context */
326332 FFVkExecContext *exec = ff_vk_exec_get(vkctx, e);
@@ -344,7 +350,7 @@ int ff_vk_filter_process_2pass(FFVulkanContext *vkctx, FFVkExecPool *e, · 17 unmodified lines
344350 VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
345351 VK_PIPELINE_STAGE_2_COMPUTE_SHADER_BIT,
346352 VK_ACCESS_SHADER_READ_BIT,
347− VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
353+ in_layout,
348354 VK_QUEUE_FAMILY_IGNORED);
349355 ff_vk_frame_barrier(vkctx, exec, tmp, img_bar, &nb_img_bar,
350356 VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
@@ -373,7 +379,7 @@ int ff_vk_filter_process_2pass(FFVulkanContext *vkctx, FFVkExecPool *e, · 22 unmodified lines
373379 VkImageView *dst_views = !i ? tmp_views : out_views;
374380
375381 ff_vk_shader_update_img_array(vkctx, exec, shd, src_f, src_views, 0, 0,
376− !i ? VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL :
382+ !i ? in_layout :
377383 VK_IMAGE_LAYOUT_GENERAL,
378384 sampler);
379385 ff_vk_shader_update_img_array(vkctx, exec, shd, dst_f, dst_views, 0, 1,
@@ -409,6 +415,9 @@ int ff_vk_filter_process_Nin(FFVulkanContext *vkctx, FFVkExecPool *e, · 29 unmodified lines
409415 VkImageView out_views[AV_NUM_DATA_POINTERS];
410416 VkImageMemoryBarrier2 img_bar[128];
411417 int nb_img_bar = 0;
418+ VkImageLayout in_layout = sampler != VK_NULL_HANDLE ?
419+ VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL :
420+ VK_IMAGE_LAYOUT_GENERAL;
412421
413422 /* Update descriptors and init the exec context */
414423 FFVkExecContext *exec = ff_vk_exec_get(vkctx, e);
@@ -432,7 +441,7 @@ int ff_vk_filter_process_Nin(FFVulkanContext *vkctx, FFVkExecPool *e, · 17 unmodified lines
432441 VK_NULL_HANDLE);
433442 for (int i = 0; i < nb_in; i++)
434443 ff_vk_shader_update_img_array(vkctx, exec, shd, in[i], in_views[i], 0, i,
435− VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
444+ in_layout,
436445 sampler);
437446
438447 /* Bind pipeline, update push data */
@@ -453,7 +462,7 @@ int ff_vk_filter_process_Nin(FFVulkanContext *vkctx, FFVkExecPool *e, · 14 unmodified lines
453462 VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
454463 VK_PIPELINE_STAGE_2_COMPUTE_SHADER_BIT,
455464 VK_ACCESS_SHADER_READ_BIT,
456− VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL,
465+ in_layout,
457466 VK_QUEUE_FAMILY_IGNORED);
458467
459468 vk->CmdPipelineBarrier2(exec->buf, &(VkDependencyInfo) {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t