Do not pointlessly call ff_alloc_packet multiple times, and fix an infinite loop by clamping the maximum number of bits to target in the algorithm that does not use lambda.
Unified · Split
| @@ -721,6 +721,9 @@ static void search_for_quantizers_twoloop(AVCodecContext *avctx, · 720 unmodified lines | |||
| 721 | int allz = 0; | 721 | int allz = 0; |
| 722 | float minthr = INFINITY; | 722 | float minthr = INFINITY; |
| 723 | 723 | ||
| 724 | // for values above this the decoder might end up in an endless loop | ||
| 725 | // due to always having more bits than what can be encoded. | ||
| 726 | destbits = FFMIN(destbits, 5800); | ||
| 724 | //XXX: some heuristic to determine initial quantizers will reduce search time | 727 | //XXX: some heuristic to determine initial quantizers will reduce search time |
| 725 | //determine zero bands and upper limits | 728 | //determine zero bands and upper limits |
| 726 | for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) { | 729 | for (w = 0; w < sce->ics.num_windows; w += sce->ics.group_len[w]) { |
| @@ -571,13 +571,14 @@ static int aac_encode_frame(AVCodecContext *avctx, AVPacket *avpkt, · 570 unmodified lines | |||
| 571 | } | 571 | } |
| 572 | start_ch += chans; | 572 | start_ch += chans; |
| 573 | } | 573 | } |
| 574 | if ((ret = ff_alloc_packet(avpkt, 768 * s->channels))) { | ||
| 575 | av_log(avctx, AV_LOG_ERROR, "Error getting output packet\n"); | ||
| 576 | return ret; | ||
| 577 | } | ||
| 578 | |||
| 574 | do { | 579 | do { |
| 575 | int frame_bits; | 580 | int frame_bits; |
| 576 | 581 | ||
| 577 | if ((ret = ff_alloc_packet(avpkt, 768 * s->channels))) { | ||
| 578 | av_log(avctx, AV_LOG_ERROR, "Error getting output packet\n"); | ||
| 579 | return ret; | ||
| 580 | } | ||
| 581 | init_put_bits(&s->pb, avpkt->data, avpkt->size); | 582 | init_put_bits(&s->pb, avpkt->data, avpkt->size); |
| 582 | 583 | ||
| 583 | if ((avctx->frame_number & 0xFF)==1 && !(avctx->flags & CODEC_FLAG_BITEXACT)) | 584 | if ((avctx->frame_number & 0xFF)==1 && !(avctx->flags & CODEC_FLAG_BITEXACT)) |