History

lavf: deprecate av_format_inject_global_side_data()

This function would otherwise fail to build on the next major bump, as inject_global_side_data is marked for removal. It should also never be needed, as there is now a mechanism for supplying global side data to decoders directly.

Anton Khirnov committed 2 years ago

Commit 12e51161 parent cb80ec02 files · +10 −0Browse files

Unified · Split

2 files
  1. libavformat/avformat.h +8 −0
  2. libavformat/demux_utils.c +2 −0
libavformat/avformat.h+8−0
@@ -1929,6 +1929,7 @@ typedef struct AVFormatContext { · 1928 unmodified lines
19291929 int64_t duration_probesize;
19301930 } AVFormatContext;
19311931
1932+#if FF_API_AVSTREAM_SIDE_DATA
19321933 /**
19331934 * This function will cause global side data to be injected in the next packet
19341935 * of each stream as well as after any subsequent seek.
@@ -1938,8 +1939,15 @@ typedef struct AVFormatContext { · 3 unmodified lines
19381939 * in a @ref AVCodecContext.coded_side_data "decoder's side data" array if
19391940 * initialized with said stream's codecpar.
19401941 * @see av_packet_side_data_get()
1942+ *
1943+ * @deprecated this function should never be needed, as global side data is now
1944+ * exported in AVCodecParameters and should
1945+ * be propagated from demuxers to decoders via
1946+ * ::avcodec_parameters_to_context()
19411947 */
1948+attribute_deprecated
19421949 void av_format_inject_global_side_data(AVFormatContext *s);
1950+#endif
19431951
19441952 #if FF_API_GET_DUR_ESTIMATE_METHOD
19451953 /**
libavformat/demux_utils.c+2−0
@@ -81,6 +81,7 @@ AVChapter *avpriv_new_chapter(AVFormatContext *s, int64_t id, AVRational time_ba · 80 unmodified lines
8181 return chapter;
8282 }
8383
84+#if FF_API_AVSTREAM_SIDE_DATA
8485 void av_format_inject_global_side_data(AVFormatContext *s)
8586 {
8687 FFFormatContext *const si = ffformatcontext(s);
@@ -90,6 +91,7 @@ void av_format_inject_global_side_data(AVFormatContext *s) · 3 unmodified lines
9091 ffstream(st)->inject_global_side_data = 1;
9192 }
9293 }
94+#endif
9395
9496 int avformat_queue_attached_pictures(AVFormatContext *s)
9597 {

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t